Percona Server moved to https://jira.percona.com/projects/PS

Code review comment for lp:~dingqi-lxb/percona-server/5.5_log_queries_in_memory

  1. 5.5_log_queries_in_memory
  2. Merge into 5.5
Oleg Tsarev (tsarev) wrote :

4) This is Ok. Also please ask Baron about Lock_time
6) Not a "before", but "instead". You should not use direct utime_of_query calculation. Please replace any calculation by check of flag thd->server_status
7) This is mean you should not use copy-paste. Never.
9) Any perfomance consideration should not break the correct work
10) You can modify the slow_extended.patch and create event id on server-side. But this is requires consideration
11) Why you didn't add public interface for iteration instead of access to members?

Reply

« Back to merge proposal