Code review comment for lp:~dingqi-lxb/percona-server/5.5_log_queries_in_memory

林晓斌 (dingqi-lxb) wrote :

2. About innodb_trx_id. Generally, when the thd->innodb_trx_id is 0, the value of "INNODB_TRX_ID" should show NULL, so the thd->innodb_was_used will not be imported here.

7. Please add tests to sys_vars suite for the all added variables.
   The variable add in this plugin will not be seen in other test-case, it can only be seen the plugin is installed. So, is test-case in sys_vars suits necessary?

« Back to merge proposal