Merge lp:~dingqi-lxb/percona-server/5.5_error_code_histogram into lp:percona-server/5.5
Status: | Work in progress |
---|---|
Proposed branch: | lp:~dingqi-lxb/percona-server/5.5_error_code_histogram |
Merge into: | lp:percona-server/5.5 |
Diff against target: |
467 lines (+450/-0) 3 files modified
doc/source/diagnostics/error_code_histogram.rst (+39/-0) patches/error_code_histogram.patch (+410/-0) patches/series (+1/-0) |
To merge this branch: | bzr merge lp:~dingqi-lxb/percona-server/5.5_error_code_histogram |
Related bugs: | |
Related blueprints: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Oleg Tsarev (community) | 2011-12-12 | Needs Information on 2011-12-14 | |
Vadim Tkachenko | 2011-12-12 | Pending | |
Stewart Smith | 2011-12-12 | Pending | |
Review via email:
|
This proposal supersedes a proposal from 2011-12-07.
Description of the change
Oleg Tsarev (tsarev) wrote : | # |
Xiaobin,
May be better just patch the code instead of two plugins?
Installing of two plugins is overkill for this simple feature.
Let me know what you think about this
Oleg Tsarev (tsarev) wrote : | # |
Xiaobin,
May be better just patch the code instead of two plugins?
Installing of two plugins is overkill for this simple feature.
Let me know what you think about this
Oleg Tsarev (tsarev) wrote : | # |
Test failed in Jenkins:
http://
I canceled the build (Doesn't make sense wait another platforms)
Oleg Tsarev (tsarev) wrote : | # |
Xiaobin,
May be better just patch the code instead of two plugins?
Installing of two plugins is overkill for this simple feature.
Let me know what you think about this
林晓斌 (dingqi-lxb) wrote : | # |
> Xiaobin,
>
> May be better just patch the code instead of two plugins?
> Installing of two plugins is overkill for this simple feature.
>
> Let me know what you think about this
The feature needs an audit_plugin to "audit" and an INFORMATION_SCHEMA table to show the result.
Using plugin is the result discussed with Vadim , for the patch can be used in both Percona and original MySQL-Server.
Both patching the code and plugin form is ok to me.
1. Please add patch name to the patches/series file
2. Why plugin doesn't uninstall in test?
3. Please add documentation to the doc/ dir
4. s/syntex/syntax/g