Code review comment for lp:~dimitern/maas/1.2-node-view-shows-kernel-params

Revision history for this message
Dimiter Naydenov (dimitern) wrote :

I'm ready with the changes and tests - everything works with one exception - test_view_node_shows_tag_kernel_params still fails, because it assumes Node.get_effective_kernel_options() returns (Tag, kernel_opts) tuple when a tag has kernel_opts and is applied to a node. So, once https://code.launchpad.net/~jameinel/maas/1.2-kernel-option-tags lands, the failing test should pass.

« Back to merge proposal