Merge lp:~diegosarmentero/ubuntuone-windows-installer/help-button-removed into lp:ubuntuone-windows-installer

[Diego Sarmentero]

Removed Help Button from Installer non client area.

Removed Help Button from Installer non client area.

[lp:~diegosarmentero/ubuntuone-windows-installer/help-button-removed]

47. By Diego Sarmentero on 2011-09-02

Fixed some unnecessary complicated test.

48. By Diego Sarmentero on 2011-09-02

Removed commented code.

49. By Diego Sarmentero on 2011-09-02

Fixed operation to unset helpButtonHint flag.

[Roberto Alsina (ralsina)]

+1

review: Approve

[Natalia Bidart (nataliabidart)]

Lint issue in:

ubuntuone_installer/gui/qt/tests/test_gui.py:
    154: [C0111, MainWindowTestCase.test_wizard_init] Missing docstring

review: Needs Fixing

[lp:~diegosarmentero/ubuntuone-windows-installer/help-button-removed]

50. By Diego Sarmentero on 2011-09-06

Added missing docstring.

[Diego Sarmentero (diegosarmentero)]

> Lint issue in:
>
> ubuntuone_installer/gui/qt/tests/test_gui.py:
> 154: [C0111, MainWindowTestCase.test_wizard_init] Missing docstring

Fixed.

[Natalia Bidart (nataliabidart)]

Looks good!

review: Approve

=== modified file 'ubuntuone_installer/gui/qt/gui.py'
--- ubuntuone_installer/gui/qt/gui.py	2011-09-05 17:53:44 +0000
+++ ubuntuone_installer/gui/qt/gui.py	2011-09-06 13:12:29 +0000
@@ -270,6 +270,9 @@
         self.help_text = ""
 
         super(MainWindow, self).__init__()
+        # Set windows flags
+        flags = self.windowFlags() & ~QtCore.Qt.WindowContextHelpButtonHint
+        self.setWindowFlags(flags)
 
         self.setWindowTitle(APP_NAME)
         self.setMinimumHeight(590)

=== modified file 'ubuntuone_installer/gui/qt/tests/test_gui.py'
--- ubuntuone_installer/gui/qt/tests/test_gui.py	2011-09-05 17:53:44 +0000
+++ ubuntuone_installer/gui/qt/tests/test_gui.py	2011-09-06 13:12:29 +0000
@@ -151,6 +151,12 @@
         self.patch(qt.folders, "FoldersPanel", FakeFoldersPanel)
         super(MainWindowTestCase, self).setUp()
 
+    def test_wizard_init(self):
+        """Check the Wizard flags regarding to the context help button."""
+        flag = int(self.ui.windowFlags() &
+            QtCore.Qt.WindowContextHelpButtonHint)
+        self.assertEqual(flag, 0)
+
     def test_initialize_page(self):
         """Check the initializePage to ensure proper widgets visibility."""
         setup_page = self.ui.page(self.ui.setup_account_page_id)