Merge lp:~diegosarmentero/ubuntuone-control-panel/tab-shares-functions into lp:ubuntuone-control-panel

[Diego Sarmentero]

- Adding functionality to the Share Links Tab (LP: #1039142).

[Alejandro J. Cura (alecu)]

This is a huge branch, that could have been split in at least three branches. :-(

Please fix the commented lines in the last three testcases.
Does this need a freeze exception?

review: Needs Fixing

[lp:~diegosarmentero/ubuntuone-control-panel/tab-shares-functions]

352. By Diego Sarmentero on 2012-08-27

fixing docstrings

[Diego Sarmentero (diegosarmentero)]

> This is a huge branch, that could have been split in at least three branches.
> :-(

I know, we talk about the length of the branch with ralsina on friday.
A lot of parts are really trivial, comment, qss, xml and docstring anyway...

>
> Please fix the commented lines in the last three testcases.
> Does this need a freeze exception?

Docstrings fixed.

[lp:~diegosarmentero/ubuntuone-control-panel/tab-shares-functions]

353. By Diego Sarmentero on 2012-08-27

retrieving folders data asynchronously

[Alejandro J. Cura (alecu)]

Some comments so far:

5 docstrings are copypasted with: """Obtain the data to create the sync menu."""
Please make them unique.
---
There's an extra blank line after "class ShareLinksPanel" and its docstring.

[lp:~diegosarmentero/ubuntuone-control-panel/tab-shares-functions]

354. By Diego Sarmentero on 2012-08-27

enhanced line button updated

[Alejandro J. Cura (alecu)]

Let's move all QLabel font sizes and color styles used in <span>s into one file with all styling constants.
This is not blocking for this branch, so a new bug is being opened.

---

Empty lines before the docstrings in class ActionsButtons and class EnhancedLineEdit.

----

It's never a good idea to touch class variables in tests, because the state of the class variable is not resetted between tests. Please use regular instances for the fake objects instead every time you can, something like:

class FakeDesktopService(object):
    """Fake QDesktopService."""

    def __init__(self):
        self.opened_url = None

    def openUrl(self, url):
        """Fake openUrl."""
        self.opened_url = url

[...]

    def test_open_in_browser(self):
        """Test the execution of open_in_browser."""
        fake_desktop_service = FakeDesktopService()
        self.patch(QtGui, "QDesktopServices", fake_desktop_service)
        url = 'http://ubuntuone.com/asd123'
        self.ui.ui.line_copy_link.setText(url)
        self.ui._open_in_browser()
        expected = QtCore.QUrl(url)
        self.assertEqual(expected, fake_desktop_service.opened_url)

And similarly in the two tests in ActionsButtonsTestCase.

----

Please, fix the docstrings in:
 * test_move_to_main_list
 * test_get_public_files
 * test_copy

review: Needs Fixing

[lp:~diegosarmentero/ubuntuone-control-panel/tab-shares-functions]

355. By Diego Sarmentero on 2012-08-27

tests fixed

356. By Diego Sarmentero on 2012-08-27

fixing docstring

[Diego Sarmentero (diegosarmentero)]

> Let's move all QLabel font sizes and color styles used in <span>s into one
> file with all styling constants.
> This is not blocking for this branch, so a new bug is being opened.
>

I've created a different bug for this:
https://bugs.launchpad.net/ubuntuone-control-panel/+bug/1042228

> ---
>
> Empty lines before the docstrings in class ActionsButtons and class
> EnhancedLineEdit.
>
> ----
>
> It's never a good idea to touch class variables in tests, because the state of
> the class variable is not resetted between tests. Please use regular instances
> for the fake objects instead every time you can, something like:
>
> class FakeDesktopService(object):
> """Fake QDesktopService."""
>
> def __init__(self):
> self.opened_url = None
>
> def openUrl(self, url):
> """Fake openUrl."""
> self.opened_url = url
>
> [...]
>
> def test_open_in_browser(self):
> """Test the execution of open_in_browser."""
> fake_desktop_service = FakeDesktopService()
> self.patch(QtGui, "QDesktopServices", fake_desktop_service)
> url = 'http://ubuntuone.com/asd123'
> self.ui.ui.line_copy_link.setText(url)
> self.ui._open_in_browser()
> expected = QtCore.QUrl(url)
> self.assertEqual(expected, fake_desktop_service.opened_url)
>
>
> And similarly in the two tests in ActionsButtonsTestCase.
>
> ----
>
> Please, fix the docstrings in:
> * test_move_to_main_list
> * test_get_public_files
> * test_copy

Fixed

[Alejandro J. Cura (alecu)]

There are no tests for keyPressEvent and moveEvent in SearchBox.
And also keyPressEvent could benefit from being refactored into smaller functions that are more easily testable.

----

The UI completely freezes for about 15 seconds when starting. The window manager even dims it, as it does with unresponsive windows.

This does not happen on trunk.

----

Besides the above two issues, all tests pass and the code looks good so far.

review: Needs Fixing

[lp:~diegosarmentero/ubuntuone-control-panel/tab-shares-functions]

357. By Diego Sarmentero on 2012-08-27

FakeDesktopService improved

358. By Diego Sarmentero on 2012-08-27

fixing memory and performance issues

359. By Diego Sarmentero on 2012-08-27

tests fixed

[Diego Sarmentero (diegosarmentero)]

> There are no tests for keyPressEvent and moveEvent in SearchBox.
> And also keyPressEvent could benefit from being refactored into smaller
> functions that are more easily testable.
>
> ----
>
> The UI completely freezes for about 15 seconds when starting. The window
> manager even dims it, as it does with unresponsive windows.
>
> This does not happen on trunk.
>
> ----
>
> Besides the above two issues, all tests pass and the code looks good so far.

Fixed

[lp:~diegosarmentero/ubuntuone-control-panel/tab-shares-functions]

360. By Diego Sarmentero on 2012-08-27

deleting legacy code

361. By Diego Sarmentero on 2012-08-27

adding missing docstring

362. By Diego Sarmentero on 2012-08-27

fixed docstrings

[Alejandro J. Cura (alecu)]

There are "ifs" in _key_down_pressed and _key_up_pressed, but there's only one test for each.
Please add more tests that check all possible combinations.

----

There's no need for this to be a dict:
    self.fake_desktop_service.data['url']

It should be just a variable:
    self.fake_desktop_service.opened_url

review: Needs Fixing

[Roberto Alsina (ralsina)]

I get this backtrace:

Traceback (most recent call last):
  File "/home/ralsina/canonical/shares/ubuntuone/controlpanel/gui/qt/share_links_search.py", line 296, in run
    folders_data += self.get_folder_info(folder)
  File "/home/ralsina/canonical/shares/ubuntuone/controlpanel/gui/qt/share_links_search.py", line 316, in get_folder_info
    for root, _, files in os.walk(folder):
  File "/usr/lib/python2.7/os.py", line 294, in walk
    for x in walk(new_path, topdown, onerror, followlinks):
  File "/usr/lib/python2.7/os.py", line 284, in walk
    if isdir(join(top, name)):
  File "/usr/lib/python2.7/posixpath.py", line 71, in join
    path += '/' + b
UnicodeDecodeError: 'ascii' codec can't decode byte 0xf1 in position 17: ordinal not in range(128)

review: Needs Fixing

[Diego Sarmentero (diegosarmentero)]

> There are "ifs" in _key_down_pressed and _key_up_pressed, but there's only
> one test for each.
> Please add more tests that check all possible combinations.
>
> ----
>
> There's no need for this to be a dict:
> self.fake_desktop_service.data['url']
>
> It should be just a variable:
> self.fake_desktop_service.opened_url

Fixed

[lp:~diegosarmentero/ubuntuone-control-panel/tab-shares-functions]

363. By Diego Sarmentero on 2012-08-28

tests improved

[Roberto Alsina (ralsina)]

> I get this backtrace:
>
>
> Traceback (most recent call last):
> File "/home/ralsina/canonical/shares/ubuntuone/controlpanel/gui/qt/share_lin
> ks_search.py", line 296, in run
> folders_data += self.get_folder_info(folder)
> File "/home/ralsina/canonical/shares/ubuntuone/controlpanel/gui/qt/share_lin
> ks_search.py", line 316, in get_folder_info
> for root, _, files in os.walk(folder):
> File "/usr/lib/python2.7/os.py", line 294, in walk
> for x in walk(new_path, topdown, onerror, followlinks):
> File "/usr/lib/python2.7/os.py", line 284, in walk
> if isdir(join(top, name)):
> File "/usr/lib/python2.7/posixpath.py", line 71, in join
> path += '/' + b
> UnicodeDecodeError: 'ascii' codec can't decode byte 0xf1 in position 17:
> ordinal not in range(128)

This was caused by files with invalid utf-8 names, which is not as critical. Removing this needsfixing.

[Roberto Alsina (ralsina)]

The search box doesn't let you type spaces.

review: Needs Fixing

[Alejandro J. Cura (alecu)]

+1

review: Approve

[Roberto Alsina (ralsina)]

Removing objections, created separate bugs for them

review: Approve

=== added file 'data/delete_search.png'
Binary files data/delete_search.png	1970-01-01 00:00:00 +0000 and data/delete_search.png	2012-08-28 00:37:19 +0000 differ
=== modified file 'data/qt/images.qrc'
--- data/qt/images.qrc	2012-05-29 14:30:36 +0000
+++ data/qt/images.qrc	2012-08-28 00:37:19 +0000
@@ -25,6 +25,7 @@
     <file>../sync_status_syncing.png</file>
     <file>../twitter.png</file>
     <file>../facebook.png</file>
+    <file>../delete_search.png</file>
     <file>../Ubuntu-R.ttf</file>
     <file>../Ubuntu-B.ttf</file>
     <file>ubuntuone.qss</file>

=== added file 'data/qt/share_file.ui'
--- data/qt/share_file.ui	1970-01-01 00:00:00 +0000
+++ data/qt/share_file.ui	2012-08-28 00:37:19 +0000
@@ -0,0 +1,94 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<ui version="4.0">
+ <class>Form</class>
+ <widget class="QWidget" name="Form">
+  <property name="geometry">
+   <rect>
+    <x>0</x>
+    <y>0</y>
+    <width>519</width>
+    <height>58</height>
+   </rect>
+  </property>
+  <property name="windowTitle">
+   <string>Form</string>
+  </property>
+  <layout class="QHBoxLayout" name="horizontalLayout">
+   <item>
+    <layout class="QHBoxLayout" name="horizontalLayout_2">
+     <item>
+      <widget class="QLabel" name="lbl_icon">
+       <property name="text">
+        <string/>
+       </property>
+      </widget>
+     </item>
+     <item>
+      <layout class="QVBoxLayout" name="verticalLayout_3">
+       <item>
+        <widget class="QLabel" name="lbl_filename">
+         <property name="text">
+          <string>filename</string>
+         </property>
+        </widget>
+       </item>
+       <item>
+        <widget class="QLabel" name="lbl_path">
+         <property name="sizePolicy">
+          <sizepolicy hsizetype="Fixed" vsizetype="Fixed">
+           <horstretch>0</horstretch>
+           <verstretch>0</verstretch>
+          </sizepolicy>
+         </property>
+         <property name="font">
+          <font>
+           <pointsize>9</pointsize>
+          </font>
+         </property>
+         <property name="text">
+          <string>path</string>
+         </property>
+        </widget>
+       </item>
+      </layout>
+     </item>
+    </layout>
+   </item>
+   <item>
+    <spacer name="horizontalSpacer">
+     <property name="orientation">
+      <enum>Qt::Horizontal</enum>
+     </property>
+     <property name="sizeHint" stdset="0">
+      <size>
+       <width>40</width>
+       <height>20</height>
+      </size>
+     </property>
+    </spacer>
+   </item>
+   <item>
+    <widget class="QPushButton" name="btn_open">
+     <property name="sizePolicy">
+      <sizepolicy hsizetype="Fixed" vsizetype="Fixed">
+       <horstretch>0</horstretch>
+       <verstretch>0</verstretch>
+      </sizepolicy>
+     </property>
+     <property name="text">
+      <string>Open</string>
+     </property>
+    </widget>
+   </item>
+   <item>
+    <widget class="QPushButton" name="btn_disable">
+     <property name="text">
+      <string>Disable link</string>
+     </property>
+    </widget>
+   </item>
+  </layout>
+ </widget>
+ <resources/>
+ <connections/>
+</ui>

=== modified file 'data/qt/share_links.ui'
--- data/qt/share_links.ui	2012-08-20 17:51:54 +0000
+++ data/qt/share_links.ui	2012-08-28 00:37:19 +0000
@@ -6,13 +6,16 @@
    <rect>
     <x>0</x>
     <y>0</y>
-    <width>532</width>
-    <height>335</height>
+    <width>567</width>
+    <height>341</height>
    </rect>
   </property>
   <property name="windowTitle">
    <string>Form</string>
   </property>
+  <property name="styleSheet">
+   <string notr="true"/>
+  </property>
   <layout class="QVBoxLayout" name="verticalLayout">
    <property name="spacing">
     <number>15</number>
@@ -38,7 +41,7 @@
       <enum>QLayout::SetDefaultConstraint</enum>
      </property>
      <property name="leftMargin">
-      <number>10</number>
+      <number>15</number>
      </property>
      <item>
       <widget class="QLabel" name="search_files_lbl">
@@ -61,7 +64,7 @@
       </widget>
      </item>
      <item>
-      <widget class="QLineEdit" name="lineEdit">
+      <widget class="SearchBox" name="line_search">
        <property name="sizePolicy">
         <sizepolicy hsizetype="Fixed" vsizetype="Fixed">
          <horstretch>0</horstretch>
@@ -82,7 +85,10 @@
     </layout>
    </item>
    <item>
-    <widget class="QStackedWidget" name="stackedWidget">
+    <widget class="QStackedWidget" name="stacked_widget">
+     <property name="currentIndex">
+      <number>0</number>
+     </property>
      <widget class="QWidget" name="page">
       <layout class="QVBoxLayout" name="verticalLayout_4">
        <property name="spacing">
@@ -107,13 +113,38 @@
            <number>0</number>
           </property>
           <item>
-           <widget class="QTreeWidget" name="treeWidget">
+           <widget class="QTreeWidget" name="tree_shared_files">
+            <property name="alternatingRowColors">
+             <bool>true</bool>
+            </property>
+            <property name="indentation">
+             <number>15</number>
+            </property>
+            <property name="rootIsDecorated">
+             <bool>false</bool>
+            </property>
             <attribute name="headerVisible">
              <bool>false</bool>
             </attribute>
-            <column>
-             <property name="text">
-              <string notr="true">1</string>
+            <attribute name="headerDefaultSectionSize">
+             <number>250</number>
+            </attribute>
+            <attribute name="headerStretchLastSection">
+             <bool>true</bool>
+            </attribute>
+            <column>
+             <property name="text">
+              <string notr="true">Filename</string>
+             </property>
+            </column>
+            <column>
+             <property name="text">
+              <string>Path</string>
+             </property>
+            </column>
+            <column>
+             <property name="text">
+              <string notr="true">Actions</string>
              </property>
             </column>
            </widget>
@@ -123,11 +154,166 @@
        </item>
       </layout>
      </widget>
-     <widget class="QWidget" name="page_2"/>
+     <widget class="QWidget" name="page_2">
+      <layout class="QVBoxLayout" name="verticalLayout_5">
+       <property name="spacing">
+        <number>0</number>
+       </property>
+       <property name="margin">
+        <number>0</number>
+       </property>
+       <item>
+        <layout class="QHBoxLayout" name="horizontalLayout">
+         <property name="spacing">
+          <number>0</number>
+         </property>
+         <property name="leftMargin">
+          <number>15</number>
+         </property>
+         <item>
+          <widget class="QLabel" name="label_share_file">
+           <property name="sizePolicy">
+            <sizepolicy hsizetype="Fixed" vsizetype="Fixed">
+             <horstretch>0</horstretch>
+             <verstretch>0</verstretch>
+            </sizepolicy>
+           </property>
+           <property name="font">
+            <font>
+             <weight>75</weight>
+             <bold>true</bold>
+            </font>
+           </property>
+           <property name="text">
+            <string>Share this file</string>
+           </property>
+          </widget>
+         </item>
+         <item>
+          <spacer name="horizontalSpacer">
+           <property name="orientation">
+            <enum>Qt::Horizontal</enum>
+           </property>
+           <property name="sizeType">
+            <enum>QSizePolicy::Expanding</enum>
+           </property>
+           <property name="sizeHint" stdset="0">
+            <size>
+             <width>40</width>
+             <height>0</height>
+            </size>
+           </property>
+          </spacer>
+         </item>
+         <item>
+          <widget class="QPushButton" name="back_to_file_list">
+           <property name="text">
+            <string>Back to file list</string>
+           </property>
+          </widget>
+         </item>
+        </layout>
+       </item>
+       <item>
+        <layout class="QVBoxLayout" name="verticalLayout">
+         <property name="spacing">
+          <number>0</number>
+         </property>
+         <item>
+          <widget class="QFrame" name="frame_share_file">
+           <property name="frameShape">
+            <enum>QFrame::StyledPanel</enum>
+           </property>
+           <property name="frameShadow">
+            <enum>QFrame::Raised</enum>
+           </property>
+           <layout class="QVBoxLayout" name="verticalLayout_7">
+            <property name="spacing">
+             <number>0</number>
+            </property>
+            <property name="margin">
+             <number>0</number>
+            </property>
+            <item>
+             <layout class="QHBoxLayout" name="hbox_share_file">
+              <property name="spacing">
+               <number>0</number>
+              </property>
+             </layout>
+            </item>
+            <item>
+             <layout class="QVBoxLayout" name="verticalLayout_6">
+              <property name="leftMargin">
+               <number>15</number>
+              </property>
+              <property name="topMargin">
+               <number>15</number>
+              </property>
+              <item>
+               <widget class="QLineEdit" name="line_copy_link">
+                <property name="sizePolicy">
+                 <sizepolicy hsizetype="Fixed" vsizetype="Fixed">
+                  <horstretch>0</horstretch>
+                  <verstretch>0</verstretch>
+                 </sizepolicy>
+                </property>
+                <property name="minimumSize">
+                 <size>
+                  <width>470</width>
+                  <height>0</height>
+                 </size>
+                </property>
+                <property name="readOnly">
+                 <bool>true</bool>
+                </property>
+               </widget>
+              </item>
+              <item>
+               <widget class="QPushButton" name="open_in_browser">
+                <property name="sizePolicy">
+                 <sizepolicy hsizetype="Fixed" vsizetype="Fixed">
+                  <horstretch>0</horstretch>
+                  <verstretch>0</verstretch>
+                 </sizepolicy>
+                </property>
+                <property name="text">
+                 <string>Open in browser</string>
+                </property>
+               </widget>
+              </item>
+              <item>
+               <spacer name="verticalSpacer">
+                <property name="orientation">
+                 <enum>Qt::Vertical</enum>
+                </property>
+                <property name="sizeHint" stdset="0">
+                 <size>
+                  <width>0</width>
+                  <height>1</height>
+                 </size>
+                </property>
+               </spacer>
+              </item>
+             </layout>
+            </item>
+           </layout>
+          </widget>
+         </item>
+        </layout>
+       </item>
+      </layout>
+     </widget>
     </widget>
    </item>
   </layout>
  </widget>
+ <customwidgets>
+  <customwidget>
+   <class>SearchBox</class>
+   <extends>QLineEdit</extends>
+   <header>ubuntuone.controlpanel.gui.qt.share_links_search</header>
+  </customwidget>
+ </customwidgets>
  <resources/>
  <connections/>
 </ui>

=== modified file 'data/qt/ubuntuone.qss'
--- data/qt/ubuntuone.qss	2012-08-22 16:30:59 +0000
+++ data/qt/ubuntuone.qss	2012-08-28 00:37:19 +0000
@@ -19,6 +19,12 @@
     border-color: #333333;
 }
 
+QFrame#frame_share_file {
+    border-top-style: solid;
+    border-width: 1px;
+    border-color: #727272;
+}
+
 UbuntuOneWizard,
 QFrame#frame_header {
     background: white;
@@ -316,6 +322,21 @@
     color: #df2d1f;
 }
 
+FilesPopup > QListView {
+    border-style: solid;
+    border-width: 1px;
+    border-color: #727272;
+}
+
+FilesPopup > QListView::item {
+    padding: 5px;
+}
+
+FilesPopup > QListView::item:selected {
+     background: qlineargradient(x1: 0, y1: 0, x2: 0, y2: 1,
+        stop: 0 #dd4814,stop: 1.0 #b93f14);
+}
+
 QAbstractItemView {
     border-style: solid;
     border-top-width: 1px;
@@ -362,3 +383,43 @@
     padding-bottom: 5px;
     /* end of hack */
 }
+
+QPushButton#action_button {
+    margin: 0px;
+    padding: 5 5 5 5;
+}
+
+QPushButton#open_in_browser {
+    background: transparent;
+    border: none;
+    text-decoration: underline;
+    color: #dd4814;
+    padding-left: 0px;
+    padding-right: 25px;
+    background-image: url(:/external_icon_orange.png);
+    background-repeat: no-repeat;
+    background-position: right;
+    background-origin: margin;
+}
+
+QPushButton#back_to_file_list {
+    background: transparent;
+    border: none;
+    color: #dd4814;
+    padding-left: 10px;
+    padding-right: 15px;
+}
+
+QPushButton#enhanced_borderless {
+    background: transparent;
+    border: none;
+    padding: 0 5 0 0;
+}
+
+QLabel#lbl_path {
+    color: gray;
+}
+
+QLineEdit#line_copy_link {
+    color: #dd4814;
+}

=== modified file 'ubuntuone/controlpanel/backend.py'
--- ubuntuone/controlpanel/backend.py	2012-08-16 17:12:44 +0000
+++ ubuntuone/controlpanel/backend.py	2012-08-28 00:37:19 +0000
@@ -829,12 +829,47 @@
 
     @log_call(logger.info)
     @inlineCallbacks
+    def get_public_files(self):
+        """Trigger the action to get the public files."""
+        yield self.sd_client.get_public_files()
+
+    @log_call(logger.info)
+    @inlineCallbacks
+    def set_public_files_list_handler(self, handler):
+        """Return the handler to be called for the public files list."""
+        result = yield self.sd_client.set_public_files_list_handler(handler)
+        returnValue(result)
+
+    @log_call(logger.info)
+    @inlineCallbacks
     def get_shares(self):
-        """Obtain the data to create the sync menu."""
+        """Get the information of the shares."""
         result = yield self.sd_client.get_shares()
         returnValue(result)
 
     @log_call(logger.info)
+    @inlineCallbacks
+    def change_public_access(self, path, is_public):
+        """Change the type access of a file."""
+        yield self.sd_client.change_public_access(path, is_public)
+
+    @log_call(logger.info)
+    @inlineCallbacks
+    def set_public_access_changed_handler(self, handler):
+        """Return the handler to be called when a access type change."""
+        result = yield self.sd_client.set_public_access_changed_handler(
+            handler)
+        returnValue(result)
+
+    @log_call(logger.info)
+    @inlineCallbacks
+    def set_public_access_change_error_handler(self, handler):
+        """Return the handler to be called on access type change error."""
+        result = yield self.sd_client.set_public_access_change_error_handler(
+            handler)
+        returnValue(result)
+
+    @log_call(logger.info)
     def shutdown(self):
         """Stop this service."""
         # do any other needed cleanup

=== modified file 'ubuntuone/controlpanel/gui/__init__.py'
--- ubuntuone/controlpanel/gui/__init__.py	2012-08-20 21:02:06 +0000
+++ ubuntuone/controlpanel/gui/__init__.py	2012-08-28 00:37:19 +0000
@@ -105,6 +105,7 @@
 COMPUTER_TO_CLOUD_TITLE = _('Syncing your computer with the cloud')
 CONNECT_BUTTON_LABEL = _('Connect to Ubuntu One')
 CONTACTS = _('Thunderbird plug-in')
+COPY_LINK = _('Copy link')
 CREDENTIALS_ERROR = _('There was a problem while retrieving the credentials.')
 DASHBOARD_BUTTON_TOOLTIP = _('View your personal details and service '
                              'summary')
@@ -226,6 +227,7 @@
 NO_DEVICES = _('No devices to show.')
 NO_FOLDERS = _('No folders to show.')
 NO_PAIRING_RECORD = _('There is no Ubuntu One pairing record.')
+OPEN = _('Open')
 OPEN_UBUNTU_ONE = _('Open Ubuntu One')
 OPEN_UBUNTU_ONE_FOLDER = _('Open the Ubuntu One Folder')
 PERCENTAGE_LABEL = _('%(percentage)s used')

=== added file 'ubuntuone/controlpanel/gui/qt/share_file.py'
--- ubuntuone/controlpanel/gui/qt/share_file.py	1970-01-01 00:00:00 +0000
+++ ubuntuone/controlpanel/gui/qt/share_file.py	2012-08-28 00:37:19 +0000
@@ -0,0 +1,63 @@
+# -*- coding: utf-8 -*-
+#
+# Copyright 2012 Canonical Ltd.
+#
+# This program is free software: you can redistribute it and/or modify it
+# under the terms of the GNU General Public License version 3, as published
+# by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranties of
+# MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
+# PURPOSE.  See the GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+"""The UI for Share file widget."""
+
+import os
+
+from PyQt4 import QtGui, QtCore
+
+from ubuntuone.controlpanel import cache
+from ubuntuone.controlpanel.gui.qt.share_links_search import (
+    get_system_icon_for_filename,
+)
+from ubuntuone.controlpanel.gui.qt.ui import share_file_ui
+from ubuntuone.controlpanel.logger import setup_logging
+
+
+logger = setup_logging('qt.share_file')
+
+
+class ShareFileWidget(cache.Cache, QtGui.QWidget):
+    """Widget with the detail information about the shared file."""
+
+    linkDisabled = QtCore.pyqtSignal()
+
+    def __init__(self, file_path='', *args, **kwargs):
+        super(ShareFileWidget, self).__init__(*args, **kwargs)
+        self.ui = share_file_ui.Ui_Form()
+        self.ui.setupUi(self)
+        self.file_path = file_path
+
+        self.ui.lbl_filename.setText(os.path.basename(file_path))
+        self.ui.lbl_path.setText(file_path)
+        icon = get_system_icon_for_filename(os.path.expanduser(file_path))
+        pixmap = icon.pixmap(24)
+        self.ui.lbl_icon.setPixmap(pixmap)
+
+        self.ui.btn_open.clicked.connect(self.open_file)
+        self.ui.btn_disable.clicked.connect(self.disable_link)
+
+    def open_file(self):
+        """Open the specified file."""
+        path = u'file://%s' % self.file_path
+        QtGui.QDesktopServices.openUrl(QtCore.QUrl(path))
+
+    def disable_link(self, val):
+        """Change the access of the file to Not Public."""
+        self.backend.change_public_access(
+            os.path.expanduser(self.file_path), False)
+        self.linkDisabled.emit()

=== modified file 'ubuntuone/controlpanel/gui/qt/share_links.py'
--- ubuntuone/controlpanel/gui/qt/share_links.py	2012-08-20 18:22:07 +0000
+++ ubuntuone/controlpanel/gui/qt/share_links.py	2012-08-28 00:37:19 +0000
@@ -16,27 +16,215 @@
 
 """The user interface for the control panel for Ubuntu One."""
 
+import os
+
+from PyQt4 import QtGui, QtCore
+from twisted.internet.defer import inlineCallbacks
+
 from ubuntuone.controlpanel.logger import setup_logging
 from ubuntuone.controlpanel.gui import (
+    COPY_LINK,
+    OPEN,
     SEARCH_FILES,
     SHARED_FILES,
 )
 
-from ubuntuone.controlpanel.gui.qt.ui import share_links_ui
+# Unused import images_rc, pylint: disable=W0611
+from ubuntuone.controlpanel.gui.qt.ui import (
+    images_rc,
+    share_links_ui,
+)
+# pylint: enable=W0611
+from ubuntuone.controlpanel.gui.qt.share_file import ShareFileWidget
+from ubuntuone.controlpanel.gui.qt.share_links_search import (
+    get_system_icon_for_filename,
+)
 from ubuntuone.controlpanel.gui.qt.ubuntuonebin import UbuntuOneBin
 
 
 logger = setup_logging('qt.share_links')
 
 
+FILE_NAME_COL = 0
+PUBLIC_LINK_COL = 1
+ACTIONS_COL = 2
+
+
 class ShareLinksPanel(UbuntuOneBin):
     """The Share Links Tab Panel widget"""
 
     ui_class = share_links_ui
     logger = logger
+    _enhanced_line = None
+    home_dir = ''
 
     def _setup(self):
         """Do some extra setupping for the UI."""
         super(ShareLinksPanel, self)._setup()
+        self.home_dir = ''
         self.ui.search_files_lbl.setText(SEARCH_FILES)
         self.ui.shared_group.setTitle(SHARED_FILES)
+
+        # Set enhanced line edits
+        self._enhanced_line = EnhancedLineEdit(self.ui.line_search,
+            self._line_close_btn, icon=":/delete_search.png",
+            style='enhanced_borderless')
+        self._enhanced_line.btn_operation.hide()
+        self.ui.line_search.popup.popupHidden.connect(
+            self._hide_line_btn_close_hide)
+        self.ui.line_search.popup.popupShown.connect(
+            self._hide_line_btn_close_show)
+        EnhancedLineEdit(self.ui.line_copy_link, self._copy_link_from_line,
+            text=COPY_LINK)
+
+        self.ui.line_search.itemSelected.connect(self.share_file)
+        self.ui.back_to_file_list.clicked.connect(self._move_to_main_list)
+        self.ui.open_in_browser.clicked.connect(self._open_in_browser)
+
+        # Connect backend signals
+        self.backend.set_public_files_list_handler(self._load_public_files)
+        self.backend.set_public_access_changed_handler(self._file_shared)
+        self.backend.set_public_access_change_error_handler(
+            lambda: self._set_is_processing(False))
+        self.get_public_files()
+
+    @inlineCallbacks
+    def share_file(self, file_path):
+        """Clean the previous file share details and publish file_path."""
+        if self.ui.hbox_share_file.count() > 0:
+            widget = self.ui.hbox_share_file.takeAt(0).widget()
+            widget.close()
+        self.is_processing = True
+        file_path = unicode(file_path)
+        share_file_widget = ShareFileWidget(file_path)
+        self.ui.hbox_share_file.addWidget(share_file_widget)
+        share_file_widget.linkDisabled.connect(
+            lambda: self.ui.line_copy_link.setText(''))
+        yield self.backend.change_public_access(
+            os.path.expanduser(file_path), True)
+
+    def _file_shared(self, info):
+        """Receive the notification that the file has been published."""
+        url = info.get("public_url")
+        self.ui.line_copy_link.setText(url)
+        self.ui.stacked_widget.setCurrentIndex(1)
+        self.is_processing = False
+
+    def _open_in_browser(self):
+        """Open the link in line_copy_link in the browser."""
+        url = self.ui.line_copy_link.text()
+        QtGui.QDesktopServices.openUrl(QtCore.QUrl(url))
+
+    def _copy_link_from_line(self):
+        """Copy link into clipboard from line edit."""
+        app = QtGui.QApplication.instance()
+        app.clipboard().setText(self.ui.line_copy_link.text())
+
+    def _move_to_main_list(self):
+        """Set the share files list as current widget."""
+        self.ui.stacked_widget.setCurrentIndex(0)
+        self.get_public_files()
+
+    @inlineCallbacks
+    def get_public_files(self):
+        """Request the list of public files."""
+        self.is_processing = True
+        self.home_dir = yield self.backend.get_home_dir()
+        yield self.backend.get_public_files()
+
+    def _load_public_files(self, publicfiles):
+        """Load the list of public files."""
+        self.ui.tree_shared_files.clear()
+        for pfile in publicfiles:
+            item = QtGui.QTreeWidgetItem()
+            path = pfile['path']
+            public_url = pfile['public_url']
+            name = os.path.basename(path)
+            item.setText(FILE_NAME_COL, name)
+            tooltip = path
+            if tooltip.startswith(self.home_dir):
+                tooltip = tooltip.replace(self.home_dir, '~', 1)
+            item.setToolTip(FILE_NAME_COL, tooltip)
+            icon = get_system_icon_for_filename(path)
+            item.setIcon(FILE_NAME_COL, icon)
+
+            self.ui.tree_shared_files.setColumnWidth(PUBLIC_LINK_COL, 300)
+            item.setSizeHint(FILE_NAME_COL, QtCore.QSize(-1, 35))
+            self.ui.tree_shared_files.addTopLevelItem(item)
+
+            link = ('<a href="%s"><span style="font-size: 12px;'
+                    'color: #dd4814";>%s</span></a>'
+                    % (public_url, public_url))
+            label = QtGui.QLabel(link, self.ui.tree_shared_files)
+            label.setOpenExternalLinks(True)
+            self.ui.tree_shared_files.setItemWidget(item, PUBLIC_LINK_COL,
+                label)
+
+            actions = ActionsButtons(path, public_url,
+                self.ui.tree_shared_files)
+            self.ui.tree_shared_files.setItemWidget(item, ACTIONS_COL, actions)
+        self.is_processing = False
+
+    def _line_close_btn(self):
+        """Close button in the line edit was pressed, hide the popup."""
+        self.ui.line_search.popup.hide()
+        self.ui.line_search.setFocus()
+
+    def _hide_line_btn_close_hide(self):
+        """Hide the button inside the search line edit-"""
+        self._enhanced_line.btn_operation.hide()
+
+    def _hide_line_btn_close_show(self):
+        """Show the button inside the search line edit-"""
+        self._enhanced_line.btn_operation.show()
+
+
+class ActionsButtons(QtGui.QWidget):
+    """Widget that contains the open and copy link actions on the list."""
+
+    def __init__(self, path, link, parent=None):
+        super(ActionsButtons, self).__init__(parent)
+        self.path = path
+        self.link = link
+
+        hbox = QtGui.QHBoxLayout(self)
+        btn_open = QtGui.QPushButton(OPEN)
+        btn_copy = QtGui.QPushButton(COPY_LINK)
+        btn_open.setObjectName('action_button')
+        btn_copy.setObjectName('action_button')
+        hbox.addSpacerItem(QtGui.QSpacerItem(1, 0,
+            QtGui.QSizePolicy.Expanding))
+        hbox.addWidget(btn_open)
+        hbox.addWidget(btn_copy)
+
+        btn_open.clicked.connect(self.open)
+        btn_copy.clicked.connect(self.copy)
+
+    def open(self):
+        """Open the file."""
+        file_path = u'file://%s' % self.path
+        QtGui.QDesktopServices.openUrl(QtCore.QUrl(file_path))
+
+    def copy(self):
+        """Copy the public link of the file in the clipboard."""
+        app = QtGui.QApplication.instance()
+        app.clipboard().setText(self.link)
+
+
+class EnhancedLineEdit(object):
+    """Add a button inside the QLineEdit received."""
+
+    def __init__(self, line_edit, operation, text=None, icon=None, style=None):
+        hbox = QtGui.QHBoxLayout(line_edit)
+        hbox.setMargin(0)
+        line_edit.setLayout(hbox)
+        hbox.addStretch()
+        self.btn_operation = QtGui.QPushButton(line_edit)
+        if text:
+            self.btn_operation.setText(text)
+        if icon:
+            self.btn_operation.setIcon(QtGui.QIcon(icon))
+        if style:
+            self.btn_operation.setObjectName(style)
+        hbox.addWidget(self.btn_operation)
+        self.btn_operation.clicked.connect(operation)

=== added file 'ubuntuone/controlpanel/gui/qt/share_links_search.py'
--- ubuntuone/controlpanel/gui/qt/share_links_search.py	1970-01-01 00:00:00 +0000
+++ ubuntuone/controlpanel/gui/qt/share_links_search.py	2012-08-28 00:37:19 +0000
@@ -0,0 +1,318 @@
+# -*- coding: utf-8 *-*
+
+# Copyright 2012 Canonical Ltd.
+#
+# This program is free software: you can redistribute it and/or modify it
+# under the terms of the GNU General Public License version 3, as published
+# by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranties of
+# MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
+# PURPOSE.  See the GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+"""The search and popup widgets for the Share Links tab."""
+
+import os
+
+from PyQt4 import QtGui, QtCore
+from twisted.internet.defer import inlineCallbacks
+
+from ubuntuone.controlpanel import cache
+
+
+def get_system_icon_for_filename(file_path):
+    """Return the icon used for the system to represent this file."""
+    fileinfo = QtCore.QFileInfo(os.path.expanduser(file_path))
+    icon_provider = QtGui.QFileIconProvider()
+    icon = icon_provider.icon(fileinfo)
+    return icon
+
+
+# pylint: disable=C0103
+
+class SearchBox(QtGui.QLineEdit, cache.Cache):
+    """Search widget for the synced files."""
+
+    itemSelected = QtCore.pyqtSignal(unicode)
+
+    def __init__(self, parent=None):
+        super(SearchBox, self).__init__(parent)
+        self.popup = FilesPopup()
+        self.home_dir = ''
+        self.temp_u1_files = []
+        self.items_per_page = 0
+        self.items_step = 20
+        self.prefix = ''
+        self._thread_explore = None
+        self._pre_key_event = {
+            QtCore.Qt.Key_Space: self._key_space_pressed,
+        }
+        self._post_key_event = {
+            QtCore.Qt.Key_Escape: lambda *args: self.popup.hide(),
+            QtCore.Qt.Key_Down: self._key_down_pressed,
+            QtCore.Qt.Key_Up: self._key_up_pressed,
+            QtCore.Qt.Key_Return: self._key_return_pressed,
+            QtCore.Qt.Key_Enter: self._key_return_pressed,
+        }
+
+        self.textChanged.connect(self.filter)
+
+        self._get_volumes_info()
+
+    @inlineCallbacks
+    def _get_volumes_info(self):
+        """Get the volumes info."""
+        self.home_dir = yield self.backend.get_home_dir()
+        self._thread_explore = ThreadExploreFolder(self.home_dir)
+        info = yield self.backend.volumes_info()
+        self._process_volumes_info(info)
+
+    def _process_volumes_info(self, info):
+        """Get the volumes paths and process them."""
+        folders = []
+        for _, _, data in info:
+            for d in data:
+                folder = d.get('path', d.get('realpath'))
+                folders.append(folder)
+        self.get_folders_files(folders)
+
+    def get_folders_files(self, folders):
+        """Get the list of files in each folder and index them."""
+        self._thread_explore.set_folders(folders)
+        self._thread_explore.folderDataObtained.connect(
+            self._folder_content_obtained)
+        self._thread_explore.start()
+
+    def _folder_content_obtained(self):
+        """Receive the content of the folders from the thread."""
+        files = self._get_filtered_list(self._thread_explore.u1_files)
+        self.popup.load_items(files)
+        text = self.text()
+        self.filter(text)
+
+    def filter(self, text):
+        """Filter the content of the popup with the text entered."""
+        text = unicode(text)
+        self.items_per_page = 0
+        if text and (self.prefix == '' or self.prefix != text[:-1]):
+            self.prefix = text
+            self.temp_u1_files = self._thread_explore.u1_files
+            self._show_filter()
+        elif text != '':
+            self.prefix = text
+            self._show_filter()
+        else:
+            self.popup.hide()
+
+    def _show_filter(self):
+        """Load the items in the popup and display it."""
+        if not self.popup.isVisible():
+            self.popup.setFixedWidth(self.width())
+            point = self.parent().mapToGlobal(self.pos())
+            self.popup.show()
+            self.popup.move(point.x(), point.y() + self.height())
+
+        self.temp_u1_files = [filename for filename in self.temp_u1_files
+            if os.path.basename(filename).find(self.prefix) > -1]
+        files = self._get_filtered_list(self.temp_u1_files)
+        self.popup.load_items(files)
+
+    def _get_filtered_list(self, filenames):
+        """Get pages of results."""
+        begin = self.items_per_page
+        self.items_per_page += self.items_step
+        files = [filename for filename in filenames[begin:self.items_per_page]]
+        return files
+
+    def _key_space_pressed(self):
+        """The user pressed the space key."""
+        item = self.popup.list_widget.currentItem()
+        widget = self.popup.list_widget.itemWidget(item)
+        self.setText(widget.name)
+        self.popup.hide()
+        return True
+
+    def _key_down_pressed(self, current):
+        """The user pressed the down key."""
+        #While the current position is lower that the list size go to next
+        if current != self.popup.list_widget.count() - 1:
+            self.popup.list_widget.setCurrentRow(
+                self.popup.list_widget.currentRow() + 1)
+        #If the current position is greater than the amount of items in
+        #the list - 6, then try to fetch more items in the list.
+        if current >= (self.popup.list_widget.count() - 6):
+            filenames = self._get_filtered_list(self.temp_u1_files)
+            self.popup.fetch_more(filenames)
+
+    def _key_up_pressed(self, current):
+        """The user pressed the up key."""
+        #while the current position is greater than 0, go to previous
+        if current > 0:
+            self.popup.list_widget.setCurrentRow(
+                self.popup.list_widget.currentRow() - 1)
+
+    def _key_return_pressed(self, current):
+        """The user pressed the return key."""
+        #If the user pressed enter, go to the item selected
+        item = self.popup.list_widget.currentItem()
+        self._set_selected_item(item)
+
+    def keyPressEvent(self, event):
+        """Process the different behaviour for the keyPress event."""
+        if self._pre_key_event.get(event.key(), lambda: False)():
+            return
+
+        super(SearchBox, self).keyPressEvent(event)
+        current = self.popup.list_widget.currentRow()
+        self._post_key_event.get(event.key(), lambda *args: None)(current)
+
+    def focusOutEvent(self, event):
+        """Hide the popup when the window loses the focus."""
+        super(SearchBox, self).focusOutEvent(event)
+        self.popup.hide()
+
+    def _set_selected_item(self, item):
+        """Notify of the selected item."""
+        widget = self.popup.list_widget.itemWidget(item)
+        self.itemSelected.emit(widget.file_path)
+        self.setText('')
+        self.popup.hide()
+
+    def moveEvent(self, event):
+        """Move the popup when the windows is moved."""
+        super(SearchBox, self).moveEvent(event)
+        if self.popup.isVisible():
+            point = self.mapToGlobal(self.line_search.pos())
+            self.popup.move(point.x(), point.y() + self.line_search.height())
+
+
+class FileItem(QtGui.QLabel):
+    """Create a styled QLabel that will show the info."""
+
+    def __init__(self, file_path):
+        super(FileItem, self).__init__()
+        self.name = os.path.basename(file_path)
+        self.file_path = file_path
+        self.text_style = (u"<span style='color: {2};'>{0}</span><br>"
+            "<span style='font-size: 13px; color: {3};'>({1})</span>")
+        self.setText(self.text_style.format(
+                self.name, self.file_path, '#333333', 'grey'))
+
+    def set_selected(self):
+        """Set a style for the text when the item is selected."""
+        self.setText(self.text_style.format(
+                self.name, self.file_path, 'white', 'white'))
+
+    def set_not_selected(self):
+        """Set a style for the text when the item is not selected."""
+        self.setText(self.text_style.format(
+                self.name, self.file_path, '#333333', 'grey'))
+
+
+class FilesPopup(QtGui.QFrame):
+    """Filter popup where the file names are shown."""
+
+    popupShown = QtCore.pyqtSignal()
+    popupHidden = QtCore.pyqtSignal()
+
+    def __init__(self):
+        super(FilesPopup, self).__init__(None,
+            QtCore.Qt.FramelessWindowHint | QtCore.Qt.ToolTip)
+        vbox = QtGui.QVBoxLayout(self)
+        vbox.setContentsMargins(0, 0, 0, 0)
+        vbox.setSpacing(0)
+        self.list_widget = QtGui.QListWidget()
+        self.list_widget.setMinimumHeight(270)
+        vbox.addWidget(self.list_widget)
+
+        self.list_widget.currentItemChanged.connect(self._repaint_items)
+
+    def _repaint_items(self, current, previous):
+        """Set the proper style for the current and previous items."""
+        if current is not None:
+            widget = self.list_widget.itemWidget(current)
+            widget.set_selected()
+        if previous is not None:
+            widget = self.list_widget.itemWidget(previous)
+            widget.set_not_selected()
+
+    def load_items(self, file_items):
+        """Load the initial items."""
+        self.list_widget.clear()
+        for file_ in file_items:
+            item = QtGui.QListWidgetItem("\n")
+            file_widget = FileItem(file_)
+            self.list_widget.addItem(item)
+            self.list_widget.setItemWidget(item, file_widget)
+            icon = get_system_icon_for_filename(file_)
+            item.setIcon(icon)
+        if file_items:
+            self.list_widget.setCurrentRow(0)
+
+    def fetch_more(self, file_items):
+        """Add more items to the list on user scroll."""
+        for file_ in file_items:
+            item = QtGui.QListWidgetItem("\n")
+            file_widget = FileItem(file_)
+            self.list_widget.addItem(item)
+            self.list_widget.setItemWidget(item, file_widget)
+            icon = get_system_icon_for_filename(file_)
+            item.setIcon(icon)
+
+    def showEvent(self, event):
+        """Notify when the popup is shown."""
+        super(FilesPopup, self).showEvent(event)
+        self.popupShown.emit()
+
+    def hideEvent(self, event):
+        """Notify when the popup is hidden."""
+        super(FilesPopup, self).hideEvent(event)
+        self.popupHidden.emit()
+
+
+class ThreadExploreFolder(QtCore.QThread):
+    """Retrieve the data of the folders asynchronously."""
+
+    folderDataObtained = QtCore.pyqtSignal()
+
+    def __init__(self, home_dir=''):
+        super(ThreadExploreFolder, self).__init__()
+        self.home_dir = home_dir
+        self.u1_files = []
+        self.folders = []
+
+    def set_folders(self, folders):
+        """Set the folders to be explored."""
+        self.folders = folders
+
+    def run(self):
+        """Execute the thread to obtain the folders data."""
+        folders_data = []
+        for folder in self.folders:
+            folders_data += self.get_folder_info(folder)
+        temp_files = []
+        for file_ in folders_data:
+            if file_.startswith(self.home_dir):
+                new_path = file_[len(self.home_dir):]
+                if new_path.startswith(os.path.sep):
+                    new_path = new_path[1:]
+                path = os.path.join('~', new_path)
+                temp_files.append(path)
+            else:
+                temp_files.append(file_)
+        folders_data = temp_files
+        folders_data.sort()
+        self.u1_files = folders_data
+        self.folderDataObtained.emit()
+
+    def get_folder_info(self, folder):
+        """Return the list of files in the proper folder."""
+        files_list = []
+        if os.path.exists(folder):
+            for root, _, files in os.walk(folder):
+                files_list.extend([os.path.join(root, f) for f in files])
+        return files_list

=== modified file 'ubuntuone/controlpanel/gui/qt/tests/__init__.py'
--- ubuntuone/controlpanel/gui/qt/tests/__init__.py	2012-08-20 14:09:45 +0000
+++ ubuntuone/controlpanel/gui/qt/tests/__init__.py	2012-08-28 00:37:19 +0000
@@ -126,6 +126,7 @@
         'build_signed_iri',
         'change_device_settings',
         'change_file_sync_settings',
+        'change_public_access',
         'change_replication_settings',
         'change_volume_settings',
         'connect_files',
@@ -137,12 +138,16 @@
         'enable_files',
         'file_sync_settings_info',
         'file_sync_status',
+        'get_public_files',
         'login',
         'register',
         'remove_device',
         'replications_info',
         'restart_files',
         'restore_file_sync_settings',
+        'set_public_access_changed_handler',
+        'set_public_access_change_error_handler',
+        'set_public_files_list_handler',
         'shutdown',
         'start_files',
         'stop_files',
@@ -379,3 +384,16 @@
         """The backend instance is correct."""
         if getattr(self.ui, 'backend', None) is not None:
             self.assertIsInstance(self.ui.backend, FakedControlPanelBackend)
+
+
+class FakeDesktopService(object):
+    """Fake QDesktopService."""
+
+    def __init__(self):
+        self.opened_url = None
+
+    # pylint: disable=C0103
+
+    def openUrl(self, url):
+        """Fake openUrl."""
+        self.opened_url = url

=== added file 'ubuntuone/controlpanel/gui/qt/tests/test_share_file.py'
--- ubuntuone/controlpanel/gui/qt/tests/test_share_file.py	1970-01-01 00:00:00 +0000
+++ ubuntuone/controlpanel/gui/qt/tests/test_share_file.py	2012-08-28 00:37:19 +0000
@@ -0,0 +1,76 @@
+# -*- coding: utf-8 -*-
+#
+# Copyright 2012 Canonical Ltd.
+#
+# This program is free software: you can redistribute it and/or modify it
+# under the terms of the GNU General Public License version 3, as published
+# by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranties of
+# MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
+# PURPOSE.  See the GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+"""Tests for the share file widget."""
+
+import os
+
+from PyQt4 import QtGui, QtCore
+
+from ubuntuone.controlpanel.gui.qt import share_file as gui
+from ubuntuone.controlpanel.gui.qt.tests import (
+    BaseTestCase,
+    FakeDesktopService,
+)
+
+# Access to a protected member
+# Instance of 'ControlBackend' has no '_called' member
+# pylint: disable=W0212, E1103
+
+
+class ShareFileWidgetTestCase(BaseTestCase):
+    """Test the ShareFileWidget class."""
+
+    innerclass_ui = gui.share_file_ui
+    innerclass_name = "Ui_Form"
+    class_ui = gui.ShareFileWidget
+    file_path = u'/home/ñandú/Ubuntu One/my_file.txt'
+    kwargs = {'file_path': file_path}
+    logger = gui.logger
+
+    def test_init(self):
+        """The share file widget initialization."""
+        self.assertEqual(self.ui.file_path, self.file_path)
+        self.assertEqual(self.ui.ui.lbl_filename.text(),
+            os.path.basename(self.file_path))
+        self.assertEqual(self.ui.ui.lbl_path.text(), self.file_path)
+
+    def test_open_file(self):
+        """Test that open file is called properly."""
+        fake_desktop_service = FakeDesktopService()
+        self.patch(QtGui, "QDesktopServices", fake_desktop_service)
+        self.ui.ui.btn_open.click()
+
+        expected = QtCore.QUrl(u'file://%s' % self.file_path)
+        self.assertEqual(expected, fake_desktop_service.opened_url)
+
+    def test_disable_link(self):
+        """Test the disable link action."""
+        data = []
+
+        def fake_change_access(path, access):
+            """Fake change access type callback."""
+            data.append(path)
+            data.append(access)
+
+        self.ui.linkDisabled.connect(self._set_called)
+        self.patch(self.ui.backend, "change_public_access",
+            fake_change_access)
+        self.ui.ui.btn_disable.click()
+
+        expected = [os.path.expanduser(self.file_path), False]
+        self.assertEqual(data, expected)
+        self.assertEqual(self._called, ((), {}))

=== modified file 'ubuntuone/controlpanel/gui/qt/tests/test_share_links.py'
--- ubuntuone/controlpanel/gui/qt/tests/test_share_links.py	2012-08-20 18:24:20 +0000
+++ ubuntuone/controlpanel/gui/qt/tests/test_share_links.py	2012-08-28 00:37:19 +0000
@@ -14,15 +14,25 @@
 # You should have received a copy of the GNU General Public License along
 # with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-"""Tests for the account tab."""
+"""Tests for the Share Links tab."""
+
+import os
+
+from PyQt4 import QtGui, QtCore
 
 from ubuntuone.controlpanel.gui import (
     SEARCH_FILES,
     SHARED_FILES,
 )
+from ubuntuone.controlpanel.gui.tests import USER_HOME
 from ubuntuone.controlpanel.gui.qt import share_links as gui
-from ubuntuone.controlpanel.gui.qt.tests import BaseTestCase
-
+from ubuntuone.controlpanel.gui.qt.tests import (
+    BaseTestCase,
+    FakeDesktopService,
+)
+
+
+# pylint: disable=W0212
 
 class ShareLinksTestCase(BaseTestCase):
     """Test the qt control panel."""
@@ -35,3 +45,151 @@
         """Check that the strings are properly setted."""
         self.assertEqual(self.ui.ui.search_files_lbl.text(), SEARCH_FILES)
         self.assertEqual(self.ui.ui.shared_group.title(), SHARED_FILES)
+        self.assertIsInstance(self.ui._enhanced_line, gui.EnhancedLineEdit)
+        self.assertEqual(self.ui._enhanced_line.btn_operation.text(), '')
+        self.assertFalse(self.ui._enhanced_line.btn_operation.isVisible())
+
+    def test_share_file(self):
+        """Check that the state of the widgets on share_file."""
+        path = '/home/user/Ubuntu One/file1.txt'
+        self.ui.share_file(path)
+        self.assertTrue(self.ui.is_processing)
+        widget = self.ui.ui.hbox_share_file.takeAt(0).widget()
+        self.assertIsInstance(widget, gui.ShareFileWidget)
+        self.assertEqual(widget.ui.lbl_filename.text(),
+            os.path.basename(path))
+        self.assertEqual(widget.ui.lbl_path.text(), path)
+
+    def test_share_file_actions(self):
+        """Check the behaviour of share_file buttons."""
+        path = '/home/user/Ubuntu One/file1.txt'
+        self.ui.share_file(path)
+        widget = self.ui.ui.hbox_share_file.takeAt(0).widget()
+        self.ui.ui.line_copy_link.setText('link')
+        self.assertEqual(self.ui.ui.line_copy_link.text(), 'link')
+        widget.linkDisabled.emit()
+        self.assertNotEqual(self.ui.ui.line_copy_link.text(), 'link')
+
+    def test_file_shared(self):
+        """Check the behavior of the widgets after the file is shared."""
+        info = {'public_url': 'http://ubuntuone.com/asd123'}
+        self.ui._file_shared(info)
+        self.assertEqual(self.ui.ui.line_copy_link.text(), info['public_url'])
+        self.assertEqual(self.ui.ui.stacked_widget.currentIndex(), 1)
+        self.assertFalse(self.ui.is_processing)
+
+    def test_open_in_browser(self):
+        """Test the execution of open_in_browser."""
+        fake_desktop_service = FakeDesktopService()
+        self.patch(QtGui, "QDesktopServices", fake_desktop_service)
+        url = 'http://ubuntuone.com/asd123'
+        self.ui.ui.line_copy_link.setText(url)
+        self.ui._open_in_browser()
+        expected = QtCore.QUrl(url)
+        self.assertEqual(expected, fake_desktop_service.opened_url)
+
+    def test_copy_link_from_line(self):
+        """Test the execution of copy_link_from_line."""
+        url = 'http://ubuntuone.com/asd123'
+        self.ui.ui.line_copy_link.setText(url)
+        self.ui._copy_link_from_line()
+        clip = QtGui.QApplication.instance().clipboard()
+        self.assertEqual(url, clip.text())
+
+    def test_move_to_main_list(self):
+        """Test that the stacked widget shows the proper index."""
+        self.ui._move_to_main_list()
+        self.assertEqual(self.ui.ui.stacked_widget.currentIndex(), 0)
+
+    def test_get_public_files(self):
+        """Test that the proper actions are executed on files requested.."""
+        self.ui.get_public_files()
+        self.assertTrue(self.ui.is_processing)
+        self.assertEqual(self.ui.ui.stacked_widget.currentIndex(), 0)
+        self.assertEqual(self.ui.home_dir, USER_HOME)
+
+    def test_line_close_btn(self):
+        """Check that the popup is hidden."""
+        self.ui.ui.line_search.popup.show()
+        self.addCleanup(self.ui.ui.line_search.popup.hide)
+        self.ui._line_close_btn()
+        self.assertFalse(self.ui.ui.line_search.popup.isVisible())
+
+    def test_hide_line_btn_close_hide(self):
+        """Check the state of the inline button."""
+        self.ui._enhanced_line.btn_operation.show()
+        self.ui.ui.line_search.popup.popupHidden.emit()
+        self.assertFalse(self.ui._enhanced_line.btn_operation.isVisible())
+
+    def test_hide_line_btn_close_show(self):
+        """Check the state of the inline button."""
+        self.ui.ui.line_search.popup.popupShown.emit()
+        self.assertTrue(self.ui._enhanced_line.btn_operation.isVisible())
+
+    def test_load_public_files(self):
+        """Test if the list of public files is loaded properly."""
+        publicfiles = [
+            {'path': '/home/file1', 'public_url': 'http:ubuntuone.com/asd123'},
+            {'path': '/home/file2', 'public_url': 'http:ubuntuone.com/qwe456'},
+        ]
+        self.ui._load_public_files(publicfiles)
+        item = self.ui.ui.tree_shared_files.topLevelItem(0)
+        self.assertEqual(item.text(0), os.path.basename('/home/file1'))
+        self.assertEqual(item.toolTip(0), '/home/file1')
+        label = self.ui.ui.tree_shared_files.itemWidget(item, 1)
+        link = ('<a href="%s"><span style="font-size: 12px;'
+                'color: #dd4814";>%s</span></a>'
+                % ('http:ubuntuone.com/asd123', 'http:ubuntuone.com/asd123'))
+        self.assertEqual(link, label.text())
+        actions = self.ui.ui.tree_shared_files.itemWidget(item, 2)
+        self.assertIsInstance(actions, gui.ActionsButtons)
+
+        item = self.ui.ui.tree_shared_files.topLevelItem(1)
+        self.assertEqual(item.text(0), os.path.basename('/home/file2'))
+        self.assertEqual(item.toolTip(0), '/home/file2')
+        label = self.ui.ui.tree_shared_files.itemWidget(item, 1)
+        link = ('<a href="%s"><span style="font-size: 12px;'
+                'color: #dd4814";>%s</span></a>'
+                % ('http:ubuntuone.com/qwe456', 'http:ubuntuone.com/qwe456'))
+        self.assertEqual(link, label.text())
+        actions = self.ui.ui.tree_shared_files.itemWidget(item, 2)
+        self.assertIsInstance(actions, gui.ActionsButtons)
+
+
+class ActionsButtonsTestCase(BaseTestCase):
+    """Test the Actions Buttons."""
+
+    def test_open(self):
+        """Test the open method."""
+        path = '/home/file1'
+        link = 'http://ubuntuone.com/asd123'
+        actions = gui.ActionsButtons(path, link)
+        fake_desktop_service = FakeDesktopService()
+        self.patch(QtGui, "QDesktopServices", fake_desktop_service)
+        actions.open()
+        file_path = QtCore.QUrl(u'file://%s' % path)
+        self.assertEqual(file_path, fake_desktop_service.opened_url)
+
+    def test_copy(self):
+        """Test that the link is copied into the clipboard.."""
+        path = '/home/file1'
+        link = 'http://ubuntuone.com/asd123'
+        actions = gui.ActionsButtons(path, link)
+        fake_desktop_service = FakeDesktopService()
+        self.patch(QtGui, "QDesktopServices", fake_desktop_service)
+        actions.copy()
+        clip = QtGui.QApplication.instance().clipboard()
+        self.assertEqual(link, clip.text())
+
+
+class EnhancedLineEditTestCase(BaseTestCase):
+    """Test the EnhancedLineEdit."""
+
+    def test_initialize(self):
+        """Test initialization."""
+        line = QtGui.QLineEdit()
+        enhanced = gui.EnhancedLineEdit(line, self._set_called, 'text')
+        self.assertEqual(line.layout().count(), 2)
+        self.assertFalse(self._called)
+        enhanced.btn_operation.click()
+        self.assertEqual(self._called, ((False, ), {}))

=== added file 'ubuntuone/controlpanel/gui/qt/tests/test_share_links_search.py'
--- ubuntuone/controlpanel/gui/qt/tests/test_share_links_search.py	1970-01-01 00:00:00 +0000
+++ ubuntuone/controlpanel/gui/qt/tests/test_share_links_search.py	2012-08-28 00:37:19 +0000
@@ -0,0 +1,302 @@
+# -*- coding: utf-8 -*-
+
+# Copyright 2012 Canonical Ltd.
+#
+# This program is free software: you can redistribute it and/or modify it
+# under the terms of the GNU General Public License version 3, as published
+# by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranties of
+# MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
+# PURPOSE.  See the GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+"""Tests for the Share Links Search."""
+
+import os
+
+from twisted.internet import defer
+
+from ubuntuone.controlpanel.gui.tests import USER_HOME
+from ubuntuone.controlpanel.gui.qt import share_links_search as gui
+from ubuntuone.controlpanel.gui.qt.tests import BaseTestCase
+
+
+# pylint: disable=W0212
+
+class SearchBoxTestCase(BaseTestCase):
+    """Test the qt control panel."""
+
+    class_ui = gui.SearchBox
+
+    @defer.inlineCallbacks
+    def setUp(self):
+        yield super(SearchBoxTestCase, self).setUp()
+
+        self.patch(self.ui._thread_explore, "get_folder_info",
+            self.fake_get_folder_info)
+        self.patch(self.ui._thread_explore, "start",
+            lambda *args, **kwargs: self.ui._thread_explore.run())
+        self.folder_info = {
+            'folder1': [
+                os.path.join(USER_HOME, 'ubuntu', 'file1'),
+                os.path.join(USER_HOME, 'ubuntu', 'file2'),
+                os.path.join(USER_HOME, 'one', 'file3'),
+            ],
+            'folder2': [
+                os.path.join(USER_HOME, 'test', 'asd'),
+                os.path.join('other_path', 'test', 'qwe'),
+                os.path.join(USER_HOME, 'blabla', 'iop'),
+            ]
+        }
+
+    def fake_get_folder_info(self, folder):
+        """Fake get_folder_info."""
+        return self.folder_info.get(folder, [])
+
+    def test_initialization(self):
+        """Check that the widget is build properly"""
+        self.assertEqual(self.ui.home_dir, USER_HOME)
+        self.assertEqual(self.ui._thread_explore.u1_files, [])
+        self.assertEqual(self.ui.temp_u1_files, [])
+        self.assertEqual(self.ui.items_per_page, 0)
+        self.assertEqual(self.ui.items_step, 20)
+        self.assertEqual(self.ui.prefix, '')
+
+    def test_key_down_pressed(self):
+        """Check the proper action are executed on key down pressed."""
+        data1 = [{'path': 'folder1'}]
+        data2 = [{'realpath': 'folder2'}]
+        self.ui._process_volumes_info([(0, 0, data1), (0, 0, data2)])
+        self.ui.popup.list_widget.setCurrentRow(1)
+        current = self.ui.popup.list_widget.currentRow()
+        self.ui._key_down_pressed(current)
+        self.assertEqual(self.ui.popup.list_widget.currentRow(), 2)
+
+    def test_key_down_pressed_load_more_items(self):
+        """Check the proper action are executed on key down pressed."""
+        data = []
+
+        def fake_fetch_more(filenames):
+            """Fake fetch_more."""
+            data.append(True)
+
+        self.patch(self.ui.popup, "fetch_more", fake_fetch_more)
+        data1 = [{'path': 'folder1'}]
+        data2 = [{'realpath': 'folder2'}]
+        self.ui._process_volumes_info([(0, 0, data1), (0, 0, data2),
+            (0, 0, data1), (0, 0, data2), (0, 0, data1), (0, 0, data2),
+            (0, 0, data1), (0, 0, data2), (0, 0, data1), (0, 0, data2),
+            (0, 0, data1), (0, 0, data2), (0, 0, data1), (0, 0, data2)])
+        self.assertEqual(self.ui.popup.list_widget.count(), 20)
+        self.ui.popup.list_widget.setCurrentRow(
+            self.ui.popup.list_widget.count() - 5)
+        current = self.ui.popup.list_widget.currentRow()
+        self.ui._key_down_pressed(current)
+        self.assertEqual(data, [True])
+
+    def test_key_up_pressed(self):
+        """Check the proper action are executed on key up pressed."""
+        data1 = [{'path': 'folder1'}]
+        data2 = [{'realpath': 'folder2'}]
+        self.ui._process_volumes_info([(0, 0, data1), (0, 0, data2)])
+        self.ui.popup.list_widget.setCurrentRow(1)
+        current = self.ui.popup.list_widget.currentRow()
+        self.ui._key_up_pressed(current)
+        self.assertEqual(self.ui.popup.list_widget.currentRow(), 0)
+
+    def test_key_up_pressed_stay_in_0(self):
+        """Check the proper action are executed on key up pressed."""
+        data1 = [{'path': 'folder1'}]
+        data2 = [{'realpath': 'folder2'}]
+        self.ui._process_volumes_info([(0, 0, data1), (0, 0, data2)])
+        self.ui.popup.list_widget.setCurrentRow(0)
+        current = self.ui.popup.list_widget.currentRow()
+        self.assertEqual(self.ui.popup.list_widget.currentRow(), 0)
+        self.ui._key_up_pressed(current)
+        self.assertEqual(self.ui.popup.list_widget.currentRow(), 0)
+
+    def test_key_return_pressed(self):
+        """Check the proper action are executed on key return pressed."""
+        data1 = [{'path': 'folder1'}]
+        data2 = [{'realpath': 'folder2'}]
+        self.ui._process_volumes_info([(0, 0, data1), (0, 0, data2)])
+        self.ui.popup.list_widget.setCurrentRow(1)
+        current = self.ui.popup.list_widget.currentRow()
+        self.ui._key_return_pressed(current)
+
+    def test_key_space_pressed(self):
+        """Check the proper action are executed on key space pressed."""
+        data = []
+
+        def fake_set_text(text):
+            """fake setText."""
+            data.append(text)
+
+        self.patch(self.ui, "setText", fake_set_text)
+        data1 = [{'path': 'folder1'}]
+        data2 = [{'realpath': 'folder2'}]
+        self.ui._process_volumes_info([(0, 0, data1), (0, 0, data2)])
+        self.ui.popup.list_widget.setCurrentRow(1)
+
+        self.ui._key_space_pressed()
+        expected = ['iop']
+        self.assertEqual(expected, data)
+
+    def test_process_volumes_info(self):
+        """Check that _process_volumes_info obtain the proper info."""
+        data1 = [{'path': 'folder1'}]
+        data2 = [{'realpath': 'folder2'}]
+        self.ui._process_volumes_info([(0, 0, data1), (0, 0, data2)])
+        expected = [
+            'other_path/test/qwe',
+            '~/blabla/iop',
+            '~/one/file3',
+            '~/test/asd',
+            '~/ubuntu/file1',
+            '~/ubuntu/file2']
+        self.assertEqual(self.ui._thread_explore.u1_files, expected)
+        self.assertEqual(self.ui.popup.list_widget.count(), 6)
+
+    def test_filter(self):
+        """Check the results of the filter."""
+        # This tests the behavior of:
+        # filter
+        # _show_filter
+        # _get_filtered_list
+        self.patch(self.ui.popup, "isVisible", lambda: True)
+        data1 = [{'path': 'folder1'}]
+        data2 = [{'realpath': 'folder2'}]
+        self.ui._process_volumes_info([(0, 0, data1), (0, 0, data2)])
+        self.ui.filter('p')
+        expected = ['~/blabla/iop']
+        self.assertEqual(expected, self.ui.temp_u1_files)
+
+        self.ui.filter('i')
+        expected = [
+            '~/blabla/iop',
+            '~/one/file3',
+            '~/ubuntu/file1',
+            '~/ubuntu/file2']
+        self.assertEqual(expected, self.ui.temp_u1_files)
+
+    def test_set_selected_item(self):
+        """Check the notification of the selected item."""
+        self.ui.itemSelected.connect(self._set_called)
+        self.patch(self.ui.popup, "isVisible", lambda: True)
+        data1 = [{'path': 'folder1'}]
+        data2 = [{'realpath': 'folder2'}]
+        self.ui._process_volumes_info([(0, 0, data1), (0, 0, data2)])
+        self.ui.popup.list_widget.setCurrentRow(0)
+        item = self.ui.popup.list_widget.currentItem()
+        self.ui._set_selected_item(item)
+        self.assertEqual(self._called, ((u'other_path/test/qwe',), {}))
+        self.assertEqual(self.ui.text(), '')
+
+
+class FileItemTestCase(BaseTestCase):
+    """Test the File Item."""
+
+    class_ui = gui.FileItem
+    file_path = '/home/tester/ubuntu/file1.txt'
+    kwargs = {'file_path': file_path}
+
+    def test_default(self):
+        """Check the default style of the item"""
+        name = os.path.basename(self.file_path)
+        style = self.ui.text_style.format(name, self.file_path,
+            '#333333', 'grey')
+        self.assertEqual(self.ui.text(), style)
+
+    def test_selected(self):
+        """Check the default style of the item"""
+        self.ui.set_selected()
+        name = os.path.basename(self.file_path)
+        style = self.ui.text_style.format(name, self.file_path,
+            'white', 'white')
+        self.assertEqual(self.ui.text(), style)
+
+    def test_not_selected(self):
+        """Check the default style of the item"""
+        self.ui.set_not_selected()
+        name = os.path.basename(self.file_path)
+        style = self.ui.text_style.format(name, self.file_path,
+            '#333333', 'grey')
+        self.assertEqual(self.ui.text(), style)
+
+
+class FilesPopupTestCase(BaseTestCase):
+
+    """FilesPopup tests."""
+
+    class_ui = gui.FilesPopup
+    text_style = (u"<span style='color: {2};'>{0}</span><br>"
+            "<span style='font-size: 13px; color: {3};'>({1})</span>")
+
+    def test_load_items(self):
+        """Tests that the items are loaded properly."""
+        items = [
+            '/home/tester/file1',
+            '/home/tester/file2',
+            '/home/tester/file3',
+        ]
+
+        self.assertEqual(self.ui.list_widget.count(), 0)
+        self.ui.load_items(items)
+        self.assertEqual(self.ui.list_widget.count(), 3)
+        # Check that we erase the list on reload
+        self.ui.load_items(items)
+        self.assertEqual(self.ui.list_widget.count(), 3)
+
+    def test_fetch_more(self):
+        """Tests that the items are loaded properly."""
+        items = [
+            '/home/tester/file1',
+            '/home/tester/file2',
+            '/home/tester/file3',
+        ]
+
+        self.assertEqual(self.ui.list_widget.count(), 0)
+        self.ui.load_items(items)
+        self.assertEqual(self.ui.list_widget.count(), 3)
+        self.ui.fetch_more(items)
+        self.assertEqual(self.ui.list_widget.count(), 6)
+
+    def test_repaint_items(self):
+        """Check the style of the items change acording to the selection."""
+        items = [
+            '/home/tester/file1',
+            '/home/tester/file2',
+            '/home/tester/file3',
+        ]
+
+        self.ui.load_items(items)
+        current = self.ui.list_widget.item(0)
+        widget = self.ui.list_widget.itemWidget(current)
+        next_ = self.ui.list_widget.item(1)
+        widget2 = self.ui.list_widget.itemWidget(next_)
+        name = os.path.basename('/home/tester/file1')
+        style = self.text_style.format(name, '/home/tester/file1',
+            'white', 'white')
+        name2 = os.path.basename('/home/tester/file2')
+        style2 = self.text_style.format(name2, '/home/tester/file2',
+            '#333333', 'grey')
+        self.assertEqual(widget.text(), style)
+        self.assertEqual(widget2.text(), style2)
+
+        self.ui.list_widget.setCurrentRow(1)
+        current = self.ui.list_widget.item(1)
+        widget = self.ui.list_widget.itemWidget(current)
+        previous = self.ui.list_widget.item(0)
+        widget2 = self.ui.list_widget.itemWidget(previous)
+        name = os.path.basename('/home/tester/file2')
+        style = self.text_style.format(name, '/home/tester/file2',
+            'white', 'white')
+        name2 = os.path.basename('/home/tester/file1')
+        style2 = self.text_style.format(name2, '/home/tester/file1',
+            '#333333', 'grey')
+        self.assertEqual(widget.text(), style)
+        self.assertEqual(widget2.text(), style2)

=== modified file 'ubuntuone/controlpanel/gui/qt/tests/test_systray.py'
--- ubuntuone/controlpanel/gui/qt/tests/test_systray.py	2012-08-20 14:09:45 +0000
+++ ubuntuone/controlpanel/gui/qt/tests/test_systray.py	2012-08-28 00:37:19 +0000
@@ -31,7 +31,10 @@
     UPLOADING,
 )
 from ubuntuone.controlpanel.gui.qt import systray
-from ubuntuone.controlpanel.gui.qt.tests import BaseTestCase
+from ubuntuone.controlpanel.gui.qt.tests import (
+    BaseTestCase,
+    FakeDesktopService,
+)
 from ubuntuone.controlpanel.tests import ROOT_PATH
 
 
@@ -59,19 +62,6 @@
         super(FakeMainWindow, self).__init__()
 
 
-class FakeDesktopService(object):
-
-    """Fake QDesktopService."""
-
-    data = {}
-
-    @classmethod
-    def openUrl(cls, url):
-        """Fake openUrl."""
-        FakeDesktopService.data['cls'] = cls
-        FakeDesktopService.data['url'] = url
-
-
 class SystrayTestCase(BaseTestCase):
 
     """Test the notification area icon."""
@@ -85,7 +75,8 @@
         self.patch(systray.TrayIcon, "startTimer", lambda s, x: None)
         self.patch(systray.TransfersMenu, "startTimer", lambda s, x: None)
         yield super(SystrayTestCase, self).setUp()
-        self.patch(QtGui, "QDesktopServices", FakeDesktopService)
+        self.fake_desktop_service = FakeDesktopService()
+        self.patch(QtGui, "QDesktopServices", self.fake_desktop_service)
 
     def assert_status_correct(self, status_bd, status_ui, action,
                               callback=None):
@@ -278,30 +269,26 @@
     def test_open_u1_folder_action(self):
         """Test open_u1_folder_action."""
         self.ui.open_u1_folder.trigger()
-        self.assertEqual(FakeDesktopService.data['cls'], FakeDesktopService)
         expected_url = QtCore.QUrl(u'file://%s' % ROOT_PATH)
-        self.assertEqual(FakeDesktopService.data['url'], expected_url)
+        self.assertEqual(self.fake_desktop_service.opened_url, expected_url)
 
     def test_get_more_storage_action(self):
         """Test get_more_storage."""
         self.ui.get_more_storage.trigger()
-        self.assertEqual(FakeDesktopService.data['cls'], FakeDesktopService)
         expected_url = QtCore.QUrl(systray.GET_STORAGE_LINK)
-        self.assertEqual(FakeDesktopService.data['url'], expected_url)
+        self.assertEqual(self.fake_desktop_service.opened_url, expected_url)
 
     def test_go_to_web_action(self):
         """Test go_to_web."""
         self.ui.go_to_web.trigger()
-        self.assertEqual(FakeDesktopService.data['cls'], FakeDesktopService)
         expected_url = QtCore.QUrl(systray.DASHBOARD)
-        self.assertEqual(FakeDesktopService.data['url'], expected_url)
+        self.assertEqual(self.fake_desktop_service.opened_url, expected_url)
 
     def test_get_help_action(self):
         """Test get_help_online."""
         self.ui.get_help_online.trigger()
-        self.assertEqual(FakeDesktopService.data['cls'], FakeDesktopService)
         expected_url = QtCore.QUrl(systray.GET_SUPPORT_LINK)
-        self.assertEqual(FakeDesktopService.data['url'], expected_url)
+        self.assertEqual(self.fake_desktop_service.opened_url, expected_url)
 
     def test_initialization(self):
         """Test that everything initializes correctly."""
@@ -353,7 +340,8 @@
         self.patch(systray.TrayIcon, "startTimer", lambda s, x: None)
         self.patch(systray.TransfersMenu, "startTimer", lambda s, x: None)
         yield super(TransfersMenuTestCase, self).setUp()
-        self.patch(QtGui, "QDesktopServices", FakeDesktopService)
+        self.fake_desktop_service = FakeDesktopService()
+        self.patch(QtGui, "QDesktopServices", self.fake_desktop_service)
         self.patch(self.ui.transfers._parent.backend, "sync_menu",
             self.fake_sync_menu)
         self.recent_transfers = []
@@ -558,7 +546,8 @@
         self.patch(systray.TrayIcon, "startTimer", lambda s, x: None)
         self.patch(systray.TransfersMenu, "startTimer", lambda s, x: None)
         yield super(SharesTestCase, self).setUp()
-        self.patch(QtGui, "QDesktopServices", FakeDesktopService)
+        self.fake_desktop_service = FakeDesktopService()
+        self.patch(QtGui, "QDesktopServices", self.fake_desktop_service)
         self.patch(self.ui.backend, "get_shares", self.fake_get_backend)
         self._shares_info = []
 
@@ -596,4 +585,4 @@
         share_action = actions[7]
         share_action.trigger()
         expected = QtCore.QUrl(systray.ACCEPT_SHARES % volume_id)
-        self.assertEqual(FakeDesktopService.data['url'], expected)
+        self.assertEqual(self.fake_desktop_service.opened_url, expected)

=== modified file 'ubuntuone/controlpanel/sd_client/__init__.py'
--- ubuntuone/controlpanel/sd_client/__init__.py	2012-08-08 18:44:57 +0000
+++ ubuntuone/controlpanel/sd_client/__init__.py	2012-08-28 00:37:19 +0000
@@ -209,3 +209,23 @@
     def sync_menu(self):
         """Get the sync menu data from syncdaemon."""
         return self.proxy.sync_menu()
+
+    def get_public_files(self):
+        """Trigger an action to get the list of public files."""
+        return self.proxy.get_public_files()
+
+    def set_public_files_list_handler(self, handler):
+        """Set the public files list handler."""
+        return self.proxy.connect_signal('PublicFilesList', handler)
+
+    def change_public_access(self, path, is_public):
+        """Change the access type of the file."""
+        return self.proxy.change_public_access(path, is_public)
+
+    def set_public_access_changed_handler(self, handler):
+        """Set the status handler function."""
+        return self.proxy.connect_signal('PublicAccessChanged', handler)
+
+    def set_public_access_change_error_handler(self, handler):
+        """Set the status handler function."""
+        return self.proxy.connect_signal('PublicAccessChangeError', handler)

=== modified file 'ubuntuone/controlpanel/tests/test_backend.py'
--- ubuntuone/controlpanel/tests/test_backend.py	2012-08-08 18:36:45 +0000
+++ ubuntuone/controlpanel/tests/test_backend.py	2012-08-28 00:37:19 +0000
@@ -161,6 +161,8 @@
             'is_error': '', 'is_connected': 'True', 'is_online': '',
         }
         self.status_changed_handler = None
+        self.public_files_list_handler = None
+        self.public_access_changed_handler = None
         self.subscribed_folders = []
         self.subscribed_shares = []
         self.actions = []
@@ -168,6 +170,13 @@
         self.folders = []
         self.volumes_refreshed = False
         self.menu_data = {'recent-transfers': (), 'uploading': ()}
+        self.publicfiles = [
+            {'path': '/home/file1', 'public_url': 'http:ubuntuone.com/asd123'},
+            {'path': '/home/file2', 'public_url': 'http:ubuntuone.com/qwe456'},
+        ]
+        self.public_access_info = {
+            'public_url': 'http:ubuntuone.com/zxc789'
+        }
 
     def get_throttling_limits(self):
         """Return the sample speed limits."""
@@ -331,6 +340,24 @@
         """Return the sync menu data."""
         return self.menu_data
 
+    def get_public_files(self):
+        """Trigger the action to get the public files."""
+        if self.public_files_list_handler is not None:
+            self.public_files_list_handler(self.publicfiles)
+
+    def set_public_files_list_handler(self, handler):
+        """Return the handler to be called for the public files list."""
+        self.public_files_list_handler = handler
+
+    def change_public_access(self, path, is_public):
+        """Change the type access of a file."""
+        if self.public_access_changed_handler is not None and is_public:
+            self.public_access_changed_handler(self.public_access_info)
+
+    def set_public_access_changed_handler(self, handler):
+        """Return the handler to be called when a access type change."""
+        self.public_access_changed_handler = handler
+
 
 class MockReplicationClient(CallRecorder):
     """A mock replication_client module."""
@@ -1709,3 +1736,40 @@
         result = yield self.be.sync_menu()
         expected = {'recent-transfers': (), 'uploading': ()}
         self.assertEqual(result, expected)
+
+    @inlineCallbacks
+    def test_get_public_files(self):
+        """Check that we get list of public files."""
+        data = []
+
+        def get_public_files_handler(publicfiles):
+            """Callback for get_public_files."""
+            data.append(publicfiles)
+
+        self.be.set_public_files_list_handler(get_public_files_handler)
+        yield self.be.get_public_files()
+        expected = [[{'path': '/home/file1',
+                      'public_url': 'http:ubuntuone.com/asd123'},
+                     {'path': '/home/file2',
+                      'public_url': 'http:ubuntuone.com/qwe456'}]]
+        self.assertEqual(expected, data)
+
+    @inlineCallbacks
+    def test_get_shares(self):
+        """Check that we get the list of shares."""
+        result = yield self.be.get_shares()
+        self.assertEqual(result, [])
+
+    @inlineCallbacks
+    def test_change_public_access_set_public(self):
+        """Check that we get a notification when the access type change."""
+        data = []
+
+        def public_access_change_handler(info):
+            """Callback for get_public_files."""
+            data.append(info)
+
+        self.be.set_public_access_changed_handler(public_access_change_handler)
+        yield self.be.change_public_access('file1', True)
+        expected = {'public_url': 'http:ubuntuone.com/zxc789'}
+        self.assertEqual([expected], data)

=== modified file 'ubuntuone/controlpanel/tests/test_sd_client.py'
--- ubuntuone/controlpanel/tests/test_sd_client.py	2012-03-29 21:37:22 +0000
+++ ubuntuone/controlpanel/tests/test_sd_client.py	2012-08-28 00:37:19 +0000
@@ -746,3 +746,31 @@
         """Handle error when retrieving current syncdaemon status."""
         self.patch(self.sd.proxy, 'get_status', self.fake_fail)
         yield self.assertFailure(self.sd.get_current_status(), CustomError)
+
+
+class PublicFilesTestCase(BaseTestCase):
+    """Test for the public files syncdaemon client methods."""
+
+    @inlineCallbacks
+    def test_set_public_files_list_handler(self):
+        """Connect a handler to the public files signal."""
+        sample_handler = object()
+        yield self.sd.set_public_files_list_handler(sample_handler)
+        self.assertEqual(sample_handler,
+            self.sd.proxy.called['PublicFilesList'])
+
+    @inlineCallbacks
+    def test_set_public_access_changed_handler(self):
+        """Connect a handler to the public access changed signal."""
+        sample_handler = object()
+        yield self.sd.set_public_access_changed_handler(sample_handler)
+        self.assertEqual(sample_handler,
+            self.sd.proxy.called['PublicAccessChanged'])
+
+    @inlineCallbacks
+    def test_set_public_access_change_error_handler(self):
+        """Connect a handler to the public access change error signal."""
+        sample_handler = object()
+        yield self.sd.set_public_access_change_error_handler(sample_handler)
+        self.assertEqual(sample_handler,
+            self.sd.proxy.called['PublicAccessChangeError'])