Code review comment for lp:~diegosarmentero/ubuntuone-control-panel/sync-status
Revision history for this message
| Diego Sarmentero (diegosarmentero) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
> Isn't the problem that we are switching to DISABLED in line 15 of the diff
> because we are getting a 0?
>
> If status is meant to be a mapping, shouldn't we check for that BEFORE
> changing state? I have not looked carefully at the code and I am sleepy, so I
> may be saying nonsense ;-)
Actually, we are receiving a dbus.UInt32(3), but yes, it makes more sense to check for Mapping before.