Merge lp:~diegosarmentero/ubuntuone-control-panel/socket-communication into lp:ubuntuone-control-panel
Proposed by
Diego Sarmentero
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | dobey | ||||
Approved revision: | 393 | ||||
Merged at revision: | 378 | ||||
Proposed branch: | lp:~diegosarmentero/ubuntuone-control-panel/socket-communication | ||||
Merge into: | lp:ubuntuone-control-panel | ||||
Diff against target: |
351 lines (+188/-10) 6 files modified
ubuntuone/controlpanel/gui/qt/gui.py (+16/-0) ubuntuone/controlpanel/gui/qt/main/tests/test_main.py (+1/-1) ubuntuone/controlpanel/gui/qt/tests/test_start.py (+11/-0) ubuntuone/controlpanel/gui/qt/uniqueapp/__init__.py (+56/-0) ubuntuone/controlpanel/gui/qt/uniqueapp/tests/test_unique_app.py (+99/-4) ubuntuone/controlpanel/gui/tests/__init__.py (+5/-5) |
||||
To merge this branch: | bzr merge lp:~diegosarmentero/ubuntuone-control-panel/socket-communication | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mike McCracken (community) | Approve | ||
dobey (community) | Approve | ||
Review via email: mp+132409@code.launchpad.net |
Commit message
- Adding socket communication, so the new instances can send messages to the already running instance (LP: #1063927).
Description of the change
Currently this only supports the "switch to tab" option, because it's the only one that is being used, and it didn't make any sense to me to send the other args to the already running application, although it can be easily extended.
You can test this IRL, running an instance of UbuntuOne Client (the one which adds the "Share a File" option will be the best option to test it) adding this branch to the PYTHONPATH of that instance, and choose the "Share a file" option from the menu and see how control panel behaves.
To post a comment you must log in.
This is still not working for me (the tab does switch, but the window doesn't get focus, or raised from minimized state). Also, the latest change seems to result in the unique app support being broken, and I get multiple control panel instances with it.