Merge lp:~diegosarmentero/ubuntuone-control-panel/refactor-sync-status into lp:ubuntuone-control-panel
| Status: | Merged |
|---|---|
| Approved by: | Diego Sarmentero on 2012-08-14 |
| Approved revision: | 341 |
| Merged at revision: | 341 |
| Proposed branch: | lp:~diegosarmentero/ubuntuone-control-panel/refactor-sync-status |
| Merge into: | lp:ubuntuone-control-panel |
| Diff against target: |
457 lines (+143/-106) 7 files modified
ubuntuone/controlpanel/backend.py (+7/-0) ubuntuone/controlpanel/gui/__init__.py (+8/-0) ubuntuone/controlpanel/gui/qt/__init__.py (+78/-0) ubuntuone/controlpanel/gui/qt/filesyncstatus.py (+4/-77) ubuntuone/controlpanel/gui/qt/tests/test_filesyncstatus.py (+30/-29) ubuntuone/controlpanel/sd_client/__init__.py (+4/-0) ubuntuone/controlpanel/tests/test_backend.py (+12/-0) |
| To merge this branch: | bzr merge lp:~diegosarmentero/ubuntuone-control-panel/refactor-sync-status |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Roberto Alsina (community) | Approve on 2012-08-10 | ||
| Brian Curtin (community) | 2012-08-08 | Approve on 2012-08-09 | |
|
Review via email:
|
|||
Commit Message
- Refactoring some sync status info to be able to use those functions and constants from the sync menu too (LP: #1034542).
Description of the Change
For u1lint you should set the PYTHONPATH including this branch: lp:~diegosarmentero/ubuntuone-client/ipcmenu
| Roberto Alsina (ralsina) wrote : | # |
+1 with the promise that those string constants are used in a following branch.
| Ubuntu One Auto Pilot (otto-pilot) wrote : | # |
The attempt to merge lp:~diegosarmentero/ubuntuone-control-panel/refactor-sync-status into lp:ubuntuone-control-panel failed. Below is the output from the failed tests.
*** Running DBus test suite ***
ubuntuone.
BaseTestCase
runTest ... [OK]
DBusServiceMa
test_
test_
DBusServiceTe
test_
test_
test_
test_
test_
test_
test_
test_
FileSyncTestCase
test_
test_
test_
test_
test_
test_
test_
test_
test_
test_
test_
test_
OperationsAut
test_
test_
test_
test_
test_
test_
test_
test_
test_
test_
test_
test_
| Ubuntu One Auto Pilot (otto-pilot) wrote : | # |
The attempt to merge lp:~diegosarmentero/ubuntuone-control-panel/refactor-sync-status into lp:ubuntuone-control-panel failed. Below is the output from the failed tests.
*** Running DBus test suite ***
ubuntuone.
BaseTestCase
runTest ... [OK]
DBusServiceMa
test_
test_
DBusServiceTe
test_
test_
test_
test_
test_
test_
test_
test_
FileSyncTestCase
test_
test_
test_
test_
test_
test_
test_
test_
test_
test_
test_
test_
OperationsAut
test_
test_
test_
test_
test_
test_
test_
test_
test_
test_
test_
test_
| Ubuntu One Auto Pilot (otto-pilot) wrote : | # |
The attempt to merge lp:~diegosarmentero/ubuntuone-control-panel/refactor-sync-status into lp:ubuntuone-control-panel failed. Below is the output from the failed tests.
*** Running DBus test suite ***
ubuntuone.
BaseTestCase
runTest ... [OK]
DBusServiceMa
test_
test_
DBusServiceTe
test_
test_
test_
test_
test_
test_
test_
test_
FileSyncTestCase
test_
test_
test_
test_
test_
test_
test_
test_
test_
test_
test_
test_
OperationsAut
test_
test_
test_
test_
test_
test_
test_
test_
test_
test_
test_
test_


Looks reasonable to me.