> I really like the code!
>
> One tiny note: the test added should have something like this:
>
> @inlineCallbacks
> def test_file_sync_settings_info_with_limit(self):
> """The settings_info method exercises its callback."""
> self.patch(self.be.sd_client, "throttling", False)
> self.be.sd_client.limits = {"download": 987456, "upload": 125698}
>
> # ...
>
> backend.DOWNLOAD_KEY: -1,
> backend.UPLOAD_KEY: -1,
> }
>
> so we fully test that even if SD limits are not -1, the limits returned to the
> UI are -1 when throttling is disabled.
> I really like the code! sync_settings_ info_with_ limit(self) : self.be. sd_client, "throttling", False) sd_client. limits = {"download": 987456, "upload": 125698} DOWNLOAD_ KEY: -1,
>
> One tiny note: the test added should have something like this:
>
> @inlineCallbacks
> def test_file_
> """The settings_info method exercises its callback."""
> self.patch(
> self.be.
>
> # ...
>
> backend.
> backend.UPLOAD_KEY: -1,
> }
>
> so we fully test that even if SD limits are not -1, the limits returned to the
> UI are -1 when throttling is disabled.
Fixed