Code review comment for lp:~diegosarmentero/ubuntuone-client/ubuntuone-client-timer

Revision history for this message
Alejandro J. Cura (alecu) wrote :

A few quick fixes needed:

The name of test_dummy_has_start_timer is wrong.

The docstring in test_register_listener_fail is copied from the one above.

"listeners_callbacks" and "register_listener" are misnamed. They should be "progress_listeners" and "register_progress_listener".

This docstring is wrong: """Create the sync menu and run the loop.""". It should be """Create the sync menu and register the progress listener."""

review: Approve

« Back to merge proposal