Code review comment for lp:~diegosarmentero/ubuntuone-client/refactor-remove-windows-linux

Diego Sarmentero (diegosarmentero) wrote :

I think the __init__ from filesystem_notifications is pretty ugly, but the code right now has to be in that way because of lint restriction, maybe we could add this file to the ignore ones in pylintrc and leave the code like this:

if sys.platform == "win32":
    from ubuntuone.platform.filesystem_notifications import pyinotify_agnostic as pyinotify
    ...
else:
    import pyinotify
    ...

Opinions?

« Back to merge proposal