Merge lp:~diegosarmentero/ubuntuone-client/fix-tests-jenkins into lp:ubuntuone-client

Proposed by Diego Sarmentero
Status: Merged
Approved by: dobey
Approved revision: 1354
Merged at revision: 1352
Proposed branch: lp:~diegosarmentero/ubuntuone-client/fix-tests-jenkins
Merge into: lp:ubuntuone-client
Diff against target: 37 lines (+4/-5)
2 files modified
ubuntuone/platform/ipc/ipc_client.py (+4/-4)
ubuntuone/syncdaemon/filesystem_manager.py (+0/-1)
To merge this branch: bzr merge lp:~diegosarmentero/ubuntuone-client/fix-tests-jenkins
Reviewer Review Type Date Requested Status
dobey (community) Approve
Mike McCracken (community) Approve
Review via email: mp+131429@code.launchpad.net

Commit message

- Move the search_files method to the correct class (LP: #1070991).

To post a comment you must log in.
1353. By Diego Sarmentero

docstring updated

1354. By Diego Sarmentero

removing commented code

Revision history for this message
Mike McCracken (mikemc) wrote :

Works for me. Note that this branch also fixes the control-panel IPC for windows/darwin, not just the jenkins tests.

review: Approve
Revision history for this message
dobey (dobey) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntuone/platform/ipc/ipc_client.py'
2--- ubuntuone/platform/ipc/ipc_client.py 2012-10-23 14:15:54 +0000
3+++ ubuntuone/platform/ipc/ipc_client.py 2012-10-25 17:30:28 +0000
4@@ -213,10 +213,6 @@
5 * int: bytes written
6 """
7
8- @remote
9- def search_files(self, name):
10- """Returns a list of the files that contain name in the path."""
11-
12 @signal
13 def on_content_queue_changed(self):
14 """Emit ContentQueueChanged."""
15@@ -373,6 +369,10 @@
16 def get_dirty_nodes(self):
17 """Rerturn a list of dirty nodes."""
18
19+ @remote
20+ def search_files(self, pattern):
21+ """Returns a list of the files that matches this pattern."""
22+
23
24 class SharesClient(RemoteClient, Referenceable):
25 """A ipc interface to interact with shares."""
26
27=== modified file 'ubuntuone/syncdaemon/filesystem_manager.py'
28--- ubuntuone/syncdaemon/filesystem_manager.py 2012-10-23 17:04:33 +0000
29+++ ubuntuone/syncdaemon/filesystem_manager.py 2012-10-25 17:30:28 +0000
30@@ -1371,7 +1371,6 @@
31 def _get_matching():
32 """Find the paths that match"""
33 for p, m in self._idx_path.iteritems():
34- #basename = os.path.basename(p)
35 if pattern.match(p):
36 mdobj = self.fs[m]
37 if mdobj["server_hash"]:

Subscribers

People subscribed via source and target branches