Code review comment for lp:~diegosarmentero/ubuntu-system-settings/click-updates

Cheers, looks mostly good*, just some small-ish comments.

119 + function open_online_accounts() {
120 + Qt.openUrlExternally("settings:///system/online-accounts");
121 + }

Don't you want to push the page component there? Although this panel does
something weird so doesn't that work?

342 + * Copyright (C) 2013 - Canonical Ltd.

2014 (& other files)

1001 + // PROCESS
1002 + QObject::connect(&(m_process), SIGNAL(finished(int)),
1003 + this, SLOT(processOutput()));

remove &(parens) please

I think you ought to be able to use the new libclick instead of executing the
process directly. cjwatson was working on converting the similar use in the
about panel - perhaps he could share his code.

* I couldn't test it though - the mock doesn't work on the phone for me and on my desktop I just get 'software up to date' and this on console

2014-03-20 12:38:20,293 - CRITICAL - ../../../../lib/SignOn/connection-manager.cpp 106 setupSocketConnection p2p error: QDBusError("org.freedesktop.DBus.Error.FileNotFound", "Failed to connect to socket /run/user/1000/signond/socket: No such file or directory") 1