Merge lp:~diegosarmentero/clickmanager-plugin/version-compare-fix into lp:clickmanager-plugin
Proposed by
Diego Sarmentero
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Alejandro J. Cura | ||||
Approved revision: | 13 | ||||
Merged at revision: | 11 | ||||
Proposed branch: | lp:~diegosarmentero/clickmanager-plugin/version-compare-fix | ||||
Merge into: | lp:clickmanager-plugin | ||||
Diff against target: |
16 lines (+2/-4) 1 file modified
src/application.cpp (+2/-4) |
||||
To merge this branch: | bzr merge lp:~diegosarmentero/clickmanager-plugin/version-compare-fix | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Approve | |
Roberto Alsina (community) | Approve | ||
Review via email: mp+187842@code.launchpad.net |
Commit message
- Use a single instance of debVersion for comparison.
Description of the change
Creating a new instance of debVersioningSystem each time a version needed to be compared it was causing apt-pkg to crash. Instead a single instance is used for each comparison right now, and that instance if being provided by: <apt-pkg/
To post a comment you must log in.
PASSED: Continuous integration, rev:13 jenkins. qa.ubuntu. com/job/ clickmanager- plugin- ci/10/ jenkins. qa.ubuntu. com/job/ clickmanager- plugin- saucy-amd64- ci/10 jenkins. qa.ubuntu. com/job/ clickmanager- plugin- saucy-armhf- ci/10
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins: 8080/job/ clickmanager- plugin- ci/10/rebuild
http://