Merge lp:~diegosarmentero/clickmanager-plugin/version-compare-fix into lp:clickmanager-plugin

[Diego Sarmentero]

- Use a single instance of debVersion for comparison.

Creating a new instance of debVersioningSystem each time a version needed to be compared it was causing apt-pkg to crash. Instead a single instance is used for each comparison right now, and that instance if being provided by: <apt-pkg/debversion.h>

[lp:~diegosarmentero/clickmanager-plugin/version-compare-fix]

12. By Diego Sarmentero on 2013-09-26

reverting changes for code clarity, will be added later in a cleanup branch

13. By Diego Sarmentero on 2013-09-26

fixing indentation

[Roberto Alsina (ralsina)]

review: Approve

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:13
http://jenkins.qa.ubuntu.com/job/clickmanager-plugin-ci/10/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/clickmanager-plugin-saucy-amd64-ci/10
    SUCCESS: http://jenkins.qa.ubuntu.com/job/clickmanager-plugin-saucy-armhf-ci/10

Click here to trigger a rebuild:
http://s-jenkins:8080/job/clickmanager-plugin-ci/10/rebuild

review: Approve (continuous-integration)

=== modified file 'src/application.cpp'
--- src/application.cpp	2013-09-13 10:12:01 +0000
+++ src/application.cpp	2013-09-26 16:43:16 +0000
@@ -47,10 +47,8 @@
 {
     this->m_remote_version = version;
 
-    debVersioningSystem debVersion;
-
-    int result = debVersion.CmpVersion(this->m_local_version.toUtf8().data(),
-                                       this->m_remote_version.toUtf8().data());
+    int result = debVS.CmpVersion(this->m_local_version.toUtf8().data(),
+                                  this->m_remote_version.toUtf8().data());
     if(result == -1) {
         this->m_update = true;
     }else{