Merge lp:~diegosarmentero/click-update-manager/on-update-signal into lp:click-update-manager

[Diego Sarmentero]

- change modelChanged for updateAvailableFound

To run the tests you need to have the last branch of lp:clickmanager-plugin installed

Use a special signal for updates found, so modelChanged can be used in cases were the model is cleared.

[lp:~diegosarmentero/click-update-manager/on-update-signal]

35. By Diego Sarmentero on 2013-10-01

fixing tests

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:35
http://jenkins.qa.ubuntu.com/job/click-update-manager-ci/20/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/click-update-manager-saucy-amd64-ci/20/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/click-update-manager-saucy-armhf-ci/20/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/click-update-manager-ci/20/rebuild

review: Needs Fixing (continuous-integration)

[Manuel de la Peña (mandel)]

review: Approve

[lp:~diegosarmentero/click-update-manager/on-update-signal]

36. By Diego Sarmentero on 2013-10-07

trigger build

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:36
http://10.97.0.26:8080/job/click-update-manager-ci/30/
Executed test runs:
    FAILURE: http://10.97.0.26:8080/job/click-update-manager-saucy-amd64-ci/30/console
    FAILURE: http://10.97.0.26:8080/job/click-update-manager-saucy-armhf-ci/30/console

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/click-update-manager-ci/30/rebuild

review: Needs Fixing (continuous-integration)

[lp:~diegosarmentero/click-update-manager/on-update-signal]

37. By Diego Sarmentero on 2013-10-07

[ Łukasz 'sil2100' Zemczak ]
* Add an -autopilot binary package for running integration tests,
  modify the tests themselves so that they work from a separate
  package.
[ Matthew Fischer ]
* Installing application icon - Switch package from "any" to "all".
[ Ubuntu daily release ]
* Automatic snapshot from revision 28
[ Diego Sarmentero ]
* Improve error handling using the new signals from the plugin.
* Adding retry button (BUG: #1232165). (LP: #1232165)
[ Rodney Dawes ]
* Add a rule to the makefile to run the unit tests. Run the unit tests
  during package build. Add autopkgtest configuration to test that
  dependency's changes don't break us.
[ Ubuntu daily release ]
* Automatic snapshot from revision 25
* Automatic snapshot from revision 21
[ Łukasz 'sil2100' Zemczak ]
* Build-dep on qtdeclarative5-ubuntu-click0.1 to force a dep-wait on
  powerpc.
[ Ubuntu daily release ]
* Automatic snapshot from revision 19
[ Łukasz 'sil2100' Zemczak ]
* Automatic snapshot from revision 16 (bootstrap)
[ Ubuntu daily release ]
* Automatic snapshot from revision 17

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:37
http://10.97.0.26:8080/job/click-update-manager-ci/31/
Executed test runs:
    FAILURE: http://10.97.0.26:8080/job/click-update-manager-saucy-amd64-ci/31/console
    FAILURE: http://10.97.0.26:8080/job/click-update-manager-saucy-armhf-ci/31/console

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/click-update-manager-ci/31/rebuild

review: Needs Fixing (continuous-integration)

[lp:~diegosarmentero/click-update-manager/on-update-signal]

38. By Diego Sarmentero on 2013-10-08

[ Corey Goldberg ]
* autopilot test code cleanup.
[ Ubuntu daily release ]
* Automatic snapshot from revision 30

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:38
http://jenkins.qa.ubuntu.com/job/click-update-manager-ci/33/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/click-update-manager-saucy-amd64-ci/33
    SUCCESS: http://jenkins.qa.ubuntu.com/job/click-update-manager-saucy-armhf-ci/33

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/click-update-manager-ci/33/rebuild

review: Approve (continuous-integration)

[Alejandro J. Cura (alecu)]

+1

review: Approve

[dobey (dobey)]

review: Approve

=== modified file 'Components/PageUpdate.qml'
--- Components/PageUpdate.qml	2013-10-04 12:18:26 +0000
+++ Components/PageUpdate.qml	2013-10-08 12:43:00 +0000
@@ -39,7 +39,7 @@
 
         Component.onCompleted: clickManager.checkUpdates()
 
-        onModelChanged: {
+        onUpdateAvailableFound: {
             labelMessage.visible = false;
             root.updates = clickManager.model.length;
             loadingIndicator.visible = false;
@@ -77,7 +77,7 @@
         color: UbuntuColors.orange
         onClicked: {
             loadingIndicator.visible = true;
-            clickManager.checkUpdates()
+            clickManager.checkUpdates();
         }
     }
 

=== modified file 'tests/unit/tst_pageupdate.qml'
--- tests/unit/tst_pageupdate.qml	2013-10-04 12:26:16 +0000
+++ tests/unit/tst_pageupdate.qml	2013-10-08 12:43:00 +0000
@@ -93,7 +93,7 @@
         function test_model_1_item() {
             var updatelist = UT.findChild(pageUpdate, "updateList");
             var clickManager = UT.findChild(pageUpdate, "clickManager");
-            clickManager.modelChanged();
+            clickManager.updateAvailableFound();
             updatelist.model = [modelItem1];
             pageUpdate.updates = 1;
             var retryButton = UT.findChild(pageUpdate, "retryButton");
@@ -107,7 +107,7 @@
         function test_model_n_items() {
             var updatelist = UT.findChild(pageUpdate, "updateList");
             var clickManager = UT.findChild(pageUpdate, "clickManager");
-            clickManager.modelChanged();
+            clickManager.updateAvailableFound();
             updatelist.model = fakeModel;
             pageUpdate.updates = 3;
             var retryButton = UT.findChild(pageUpdate, "retryButton");