Merge lp:~diegosarmentero/click-update-manager/no-updates-no-title into lp:click-update-manager

Proposed by Diego Sarmentero on 2013-10-08
Status: Merged
Approved by: Diego Sarmentero on 2013-10-08
Approved revision: 35
Merged at revision: 35
Proposed branch: lp:~diegosarmentero/click-update-manager/no-updates-no-title
Merge into: lp:click-update-manager
Diff against target: 25 lines (+2/-2)
2 files modified
Components/PageUpdate.qml (+1/-1)
tests/unit/tst_pageupdate.qml (+1/-1)
To merge this branch: bzr merge lp:~diegosarmentero/click-update-manager/no-updates-no-title
Reviewer Review Type Date Requested Status
Leo Arias (community) code review 2013-10-08 Approve on 2013-10-08
PS Jenkins bot (community) continuous-integration Approve on 2013-10-08
Review via email: mp+189842@code.launchpad.net

Commit message

- Show "Updates Not Found" not as title.

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Leo Arias (elopio) wrote :

+1

review: Approve (code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Components/PageUpdate.qml'
2--- Components/PageUpdate.qml 2013-10-07 13:23:42 +0000
3+++ Components/PageUpdate.qml 2013-10-08 13:17:48 +0000
4@@ -48,7 +48,7 @@
5 onUpdatesNotFound: {
6 loadingIndicator.visible = false;
7 installAllButton.visible = false;
8- labelMessage.text = i18n.tr("No Updates Found")
9+ labelMessage.text = i18n.tr("No updates found")
10 labelMessage.visible = true;
11 }
12
13
14=== modified file 'tests/unit/tst_pageupdate.qml'
15--- tests/unit/tst_pageupdate.qml 2013-10-07 13:23:42 +0000
16+++ tests/unit/tst_pageupdate.qml 2013-10-08 13:17:48 +0000
17@@ -127,7 +127,7 @@
18 compare(labelMessage.visible, true, "labelMessage should be visible if there isn't a model");
19 compare(installAllButton.visible, false, "installAllButton should not be visible if there isn't a model");
20 compare(loadingIndicator.visible, false, "loadingIndicator should not be visible if there isn't a model");
21- compare(labelMessage.text, i18n.tr("No Updates Found"), "labelMessage text doesn't match");
22+ compare(labelMessage.text, i18n.tr("No updates found"), "labelMessage text doesn't match");
23 }
24
25 function test_label_message_credentials_not_found() {

Subscribers

People subscribed via source and target branches