Merge lp:~diego-rocha-comp/wingpanel/fix-1473563 into lp:~wingpanel-devs/wingpanel/trunk

[Diego Rocha]

Improve the logic used to define the panel's style by accounting for luminance, contrast and sharpness, and adding the TRANSLUCENT state.

This new state is used when the desktop wallpaper is complex or has high contrast.

Improves the logic used to define the panel's style by accounting for luminance, contrast and sharpness, and adding the TRANSLUCENT state.

This new state is used when the desktop wallpaper is complex or has high contrast.

Depends on https://code.launchpad.net/~diego-rocha-comp/egtk/fix-1473563/+merge/286451

[lp:~diego-rocha-comp/wingpanel/fix-1473563]

108. By Diego Rocha on 2016-02-18

backgroundmanager: added TRANSLUCENT state and improved state selection logic

109. By Diego Rocha on 2016-02-19

backgroundmanager: load background color information before checking for initial state

=== modified file 'src/Services/BackgroundManager.vala'
--- src/Services/BackgroundManager.vala	2015-12-02 20:52:48 +0000
+++ src/Services/BackgroundManager.vala	2016-02-19 22:10:36 +0000
@@ -21,7 +21,8 @@
     public enum BackgroundState {
         LIGHT,
         DARK,
-        MAXIMIZED
+        MAXIMIZED,
+        TRANSLUCENT
     }
 
     [DBus (name = "org.pantheon.gala.WingpanelInterface")]
@@ -113,4 +114,4 @@
             return instance;
         }
     }
-}
\ No newline at end of file
+}

=== modified file 'src/Widgets/Panel.vala'
--- src/Widgets/Panel.vala	2015-10-21 21:48:36 +0000
+++ src/Widgets/Panel.vala	2016-02-19 22:10:36 +0000
@@ -18,8 +18,6 @@
  */
 
 public class Wingpanel.Widgets.Panel : Gtk.Box {
-    private static const double ALPHA_ANIMATION_STEP = 0.05;
-
     public Services.PopoverManager popover_manager { get; construct; }
 
     private IndicatorMenuBar right_menubar;
@@ -126,16 +124,25 @@
                 style_context.add_class ("color-light");
                 style_context.remove_class ("color-dark");
                 style_context.remove_class ("maximized");
+                style_context.remove_class ("translucent");
                 break;
             case Services.BackgroundState.LIGHT:
                 style_context.add_class ("color-dark");
                 style_context.remove_class ("color-light");
                 style_context.remove_class ("maximized");
+                style_context.remove_class ("translucent");
                 break;
             case Services.BackgroundState.MAXIMIZED:
                 style_context.add_class ("maximized");
                 style_context.remove_class ("color-light");
                 style_context.remove_class ("color-dark");
+                style_context.remove_class ("translucent");
+                break;
+            case Services.BackgroundState.TRANSLUCENT:
+                style_context.add_class ("translucent");
+                style_context.remove_class ("color-light");
+                style_context.remove_class ("color-dark");
+                style_context.remove_class ("maximized");
                 break;
         }
     }

=== renamed file 'wingpanel-interface/AlphaManager.vala' => 'wingpanel-interface/BackgroundManager.vala'
--- wingpanel-interface/AlphaManager.vala	2015-12-02 20:28:08 +0000
+++ wingpanel-interface/BackgroundManager.vala	2016-02-19 22:10:36 +0000
@@ -20,11 +20,15 @@
 public enum BackgroundState {
     LIGHT,
     DARK,
-    MAXIMIZED
+    MAXIMIZED,
+    TRANSLUCENT
 }
 
-public class WingpanelInterface.AlphaManager : Object {
+public class WingpanelInterface.BackgroundManager : Object {
     private const int WALLPAPER_TRANSITION_DURATION = 150;
+    private const double ACUTANCE_THRESHOLD = 8;
+    private const double STD_THRESHOLD = 45;
+    private const double LUMINANCE_THRESHOLD = 180;
 
     public signal void state_changed (BackgroundState state, uint animation_duration);
 
@@ -36,16 +40,20 @@
     private Meta.Workspace? current_workspace = null;
 
     private BackgroundState current_state = BackgroundState.LIGHT;
-    private bool needs_dark_background = false;
+    
+    private Utils.ColorInformation? bk_color_info = null;
 
-    public AlphaManager (int monitor, int panel_height) {
+    public BackgroundManager (int monitor, int panel_height) {
         Object (monitor : monitor, panel_height: panel_height);
 
         connect_signals ();
-        update_current_workspace ();
+        update_bk_color_info.begin ((obj, res) => {
+            update_bk_color_info.end (res);
+            update_current_workspace ();
+        });
     }
 
-    ~AlphaManager () {
+    ~BackgroundManager () {
         var signal_id = GLib.Signal.lookup ("changed", Main.wm.background_group.get_type ());
         GLib.Signal.remove_emission_hook (signal_id, wallpaper_hook_id);
     }
@@ -58,7 +66,10 @@
         var signal_id = GLib.Signal.lookup ("changed", Main.wm.background_group.get_type ());
 
         wallpaper_hook_id = GLib.Signal.add_emission_hook (signal_id, 0, (ihint, param_values) => {
-            update_alpha_state.begin ();
+            update_bk_color_info.begin ((obj, res) => {
+                update_bk_color_info.end (res);
+                check_for_state_change (WALLPAPER_TRANSITION_DURATION);
+            });
 
             return true;
         }, null);
@@ -112,14 +123,35 @@
         check_for_state_change (AnimationSettings.get_default ().snap_duration);
     }
 
-    public async void update_alpha_state () {
-        Utils.background_needed.begin (Main.wm, monitor, panel_height, (obj, res) => {
-            needs_dark_background = Utils.background_needed.end (res);
-
-            check_for_state_change (WALLPAPER_TRANSITION_DURATION);
+    public async void update_bk_color_info () {
+        SourceFunc callback = update_bk_color_info.callback;
+        Gdk.Rectangle monitor_geometry;
+
+        Gdk.Screen.get_default ().get_monitor_geometry (monitor, out monitor_geometry);
+
+        Utils.get_background_color_information.begin (Main.wm, monitor, 0, 0, monitor_geometry.width, panel_height, (obj, res) => {
+            try {
+                bk_color_info = Utils.get_background_color_information.end (res);
+            } catch (Error e) {
+                warning (e.message);
+            } finally {
+                callback ();
+            }
         });
+        
+        yield;
     }
 
+    /**
+     * Check if Wingpanel's background state should change.
+     *
+     * The state is defined as follows:
+     *  - If there's a maximized window, the state should be MAXIMIZED;
+     *  - If no information about the background could be gathered, it should be TRANSLUCENT;
+     *  - If there's too much contrast or sharpness, it should be TRANSLUCENT;
+     *  - If the background is too bright, it should be DARK;
+     *  - Else it should be LIGHT.
+     */
     private void check_for_state_change (uint animation_duration) {
         bool has_maximized_window = false;
 
@@ -136,12 +168,20 @@
 
         if (has_maximized_window) {
             new_state = BackgroundState.MAXIMIZED;
+        } else if (bk_color_info == null) {
+            new_state = BackgroundState.TRANSLUCENT;
         } else {
-            new_state = needs_dark_background ? BackgroundState.DARK : BackgroundState.LIGHT;
+            var luminance_std = Math.sqrt (bk_color_info.luminance_variance);
+            
+            new_state = luminance_std > STD_THRESHOLD ||
+                (bk_color_info.mean_luminance < LUMINANCE_THRESHOLD &&
+                    bk_color_info.mean_luminance + 1.645 * luminance_std > LUMINANCE_THRESHOLD ) || 
+                bk_color_info.mean_acutance > ACUTANCE_THRESHOLD ? BackgroundState.TRANSLUCENT :
+                    bk_color_info.mean_luminance > LUMINANCE_THRESHOLD ? BackgroundState.DARK : BackgroundState.LIGHT;
         }
 
         if (new_state != current_state) {
             state_changed (current_state = new_state, animation_duration);
         }
     }
-}
\ No newline at end of file
+}

=== modified file 'wingpanel-interface/CMakeLists.txt'
--- wingpanel-interface/CMakeLists.txt	2015-05-25 16:19:07 +0000
+++ wingpanel-interface/CMakeLists.txt	2016-02-19 22:10:36 +0000
@@ -14,7 +14,7 @@
 vala_precompile (VALA_C ${WINGPANELINTERFACE}
   Main.vala
   DBusServer.vala
-  AlphaManager.vala
+  BackgroundManager.vala
   FocusManager.vala
   Settings.vala
   Utils.vala

=== modified file 'wingpanel-interface/DBusServer.vala'
--- wingpanel-interface/DBusServer.vala	2015-10-20 23:43:37 +0000
+++ wingpanel-interface/DBusServer.vala	2016-02-19 22:10:36 +0000
@@ -19,13 +19,13 @@
 
 [DBus (name = "org.pantheon.gala.WingpanelInterface")]
 public class WingpanelInterface.DBusServer : Object {
-    private AlphaManager alpha_manager;
+    private BackgroundManager background_manager;
 
     public signal void state_changed (BackgroundState state, uint animation_duration);
 
     public void initialize (int monitor, int panel_height) {
-        alpha_manager = new AlphaManager (monitor, panel_height);
-        alpha_manager.state_changed.connect ((state, animation_duration) => {
+        background_manager = new BackgroundManager (monitor, panel_height);
+        background_manager.state_changed.connect ((state, animation_duration) => {
             state_changed (state, animation_duration);
         });
     }
@@ -37,4 +37,4 @@
     public void restore_focused_window () {
         FocusManager.get_default ().restore_focused_window ();
     }
-}
\ No newline at end of file
+}

=== modified file 'wingpanel-interface/Utils.vala'
--- wingpanel-interface/Utils.vala	2015-10-20 14:07:04 +0000
+++ wingpanel-interface/Utils.vala	2016-02-19 22:10:36 +0000
@@ -25,8 +25,6 @@
 namespace WingpanelInterface.Utils {
     private const double SATURATION_WEIGHT = 1.5;
     private const double WEIGHT_THRESHOLD = 1.0;
-    private const double MIN_VARIANCE = 50;
-    private const double MIN_LUM = 25;
 
     private class DummyOffscreenEffect : Clutter.OffscreenEffect {
         public signal void done_painting ();
@@ -41,8 +39,9 @@
         double average_red;
         double average_green;
         double average_blue;
-        double mean;
-        double variance;
+        double mean_luminance;
+        double luminance_variance;
+        double mean_acutance;
     }
 
     public async ColorInformation get_background_color_information (Gala.WindowManager wm, int monitor,
@@ -68,7 +67,7 @@
             throw new DBusError.INVALID_ARGS ("Invalid rectangle specified: %i, %i, %i, %i".printf (x_start, y_start, width, height));
         }
 
-        double variance = 0, mean = 0, rTotal = 0, gTotal = 0, bTotal = 0;
+        double mean_acutance = 0, variance = 0, mean = 0, rTotal = 0, gTotal = 0, bTotal = 0;
         ulong paint_signal_handler = 0;
 
         paint_signal_handler = effect.done_painting.connect (() => {
@@ -77,6 +76,7 @@
 
             var texture = (Cogl.Texture)effect.get_texture ();
             var pixels = new uint8[texture.get_width () * texture.get_height () * 4];
+            var pixel_lums = new double[texture.get_width () * texture.get_height ()];
 
             CoglFixes.texture_get_data (texture, Cogl.PixelFormat.BGRA_8888_PRE, 0, pixels);
 
@@ -100,7 +100,9 @@
                     uint8 g = pixels[i + 1];
                     uint8 b = pixels[i + 2];
 
-                    pixel = (0.3 * r + 0.6 * g + 0.11 * b) - 128f;
+                    pixel = (0.3 * r + 0.59 * g + 0.11 * b) ;
+                    
+                    pixel_lums[y * width + x] = pixel;
 
                     min = uint8.min (r, uint8.min (g, b));
                     max = uint8.max (r, uint8.max (g, b));
@@ -123,6 +125,21 @@
                     mean_squares += pixel * pixel;
                 }
             }
+            
+            for (int y = y_start + 1; y < height - 1; y++) {
+                for (int x = x_start + 1; x < width - 1; x++) {
+                    var acutance =
+                        (pixel_lums[y * width + x] * 4) -
+                        (
+                            pixel_lums[y * width + x - 1] +
+                            pixel_lums[y * width + x + 1] +
+                            pixel_lums[(y - 1) * width + x] +
+                            pixel_lums[(y + 1) * width + x]
+                        );
+                    
+                    mean_acutance += acutance > 0 ? acutance : -acutance;
+                }
+            }
 
             scoreTotal /= size;
             bTotal /= size;
@@ -163,9 +180,11 @@
             }
 
             mean /= size;
-            mean_squares *= mean_squares / size;
+            mean_squares = mean_squares / size;
 
-            variance = Math.sqrt (mean_squares - mean * mean) / (double)size;
+            variance = (mean_squares - (mean * mean));
+            
+            mean_acutance /= (width - 2) * (height - 2);
 
             get_background_color_information.callback ();
         });
@@ -174,23 +193,7 @@
 
         yield;
 
-        return { rTotal, gTotal, bTotal, mean, variance };
-    }
-
-    public async bool background_needed (Gala.WindowManager wm, int screen, int panel_height) {
-        Gdk.Rectangle monitor_geometry;
-        ColorInformation? color_info = null;
-
-        Gdk.Screen.get_default ().get_monitor_geometry (screen, out monitor_geometry);
-
-        try {
-            color_info = yield get_background_color_information (wm, screen, 0, 0, monitor_geometry.width, panel_height);
-        } catch (Error e) {
-            warning (e.message);
-
-            return false;
-        }
-
-        return color_info != null && (color_info.mean > MIN_LUM || color_info.variance > MIN_VARIANCE);
-    }
-}
\ No newline at end of file
+        return { rTotal, gTotal, bTotal, mean, variance, mean_acutance };
+    }
+
+}