Merge lp:~didrocks/unity/workspace-switch-translation into lp:unity/6.0

Proposed by Didier Roche on 2012-10-08
Status: Merged
Approved by: Łukasz Zemczak on 2012-10-08
Approved revision: 2766
Merged at revision: 2766
Proposed branch: lp:~didrocks/unity/workspace-switch-translation
Merge into: lp:unity/6.0
Diff against target: 24 lines (+2/-1)
2 files modified
launcher/ExpoLauncherIcon.cpp (+1/-1)
po/POTFILES.in (+1/-0)
To merge this branch: bzr merge lp:~didrocks/unity/workspace-switch-translation
Reviewer Review Type Date Requested Status
Łukasz Zemczak 2012-10-08 Approve on 2012-10-08
Review via email: mp+128440@code.launchpad.net

This proposal supersedes a proposal from 2012-10-08.

Commit Message

Fix untranslated Workspace Switcher in the panel.
Got back to 12.04 string to not add any string break to Quantal.

Similar to rev 1062921 (LP: #1062921)

Description of the Change

Fix untranslated Workspace Switcher in the panel.
Got back to 12.04 string to not add any string break to Quantal.

Similar to rev 1062921 (LP: #1062921)

To post a comment you must log in.
Nicolas Delvaux (malizor) wrote :

I'm not sure I understand.
The "Workspace Switcher" string was used on Precise.
For example, in French: https://translations.launchpad.net/ubuntu/precise/+source/unity/+pots/unity/fr/+translate?batch=10&show=all&search=Workspace+Switcher

Didier Roche (didrocks) wrote :

Right, but the "Worspace Switcher" string is not exported anymore and not part of any Quantal langpack: https://translations.launchpad.net/ubuntu/quantal/+source/unity/+pots/unity/fr/+translate?batch=10&show=all&search=Workspace+Switcher

Taking it back seems to mean that we need to have it retranslated in every languages again, which is too short as the final freeze is tomorrow. So, I'm taking the "Workspaces" string after having checked with design for the quantal branch, which matches the needs and avoid asking for translators for an emergency fix.

For R (and 7.0), the branch you proposed will work :)

Łukasz Zemczak (sil2100) wrote :

LGTM. It's not exactly getting back to 12.04, but more to the previous translated string ;)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'launcher/ExpoLauncherIcon.cpp'
2--- launcher/ExpoLauncherIcon.cpp 2012-10-01 19:12:00 +0000
3+++ launcher/ExpoLauncherIcon.cpp 2012-10-08 08:57:30 +0000
4@@ -31,7 +31,7 @@
5 ExpoLauncherIcon::ExpoLauncherIcon()
6 : SimpleLauncherIcon(IconType::EXPO)
7 {
8- tooltip_text = _("Workspace Switcher");
9+ tooltip_text = _("Workspaces");
10 icon_name = "workspace-switcher";
11 SetQuirk(Quirk::VISIBLE, false);
12 SetQuirk(Quirk::RUNNING, false);
13
14=== modified file 'po/POTFILES.in'
15--- po/POTFILES.in 2012-08-31 09:47:12 +0000
16+++ po/POTFILES.in 2012-10-08 08:57:30 +0000
17@@ -12,6 +12,7 @@
18 launcher/BamfLauncherIcon.cpp
19 launcher/DesktopLauncherIcon.cpp
20 launcher/DeviceNotificationDisplayImp.cpp
21+launcher/ExpoLauncherIcon.cpp
22 launcher/LauncherController.cpp
23 launcher/SoftwareCenterLauncherIcon.cpp
24 launcher/SpacerLauncherIcon.cpp

Subscribers

People subscribed via source and target branches