Merge lp:~didrocks/unity/migrate-favorites into lp:unity

[Didier Roche-Tolomelli]

To fix bug #622146, python script to migrate people from UNR launcher favorite, gnome panel and gnome desktop to unity launcher (non duplicate will be added to the panel).
The script is launched the first time the user is starting unity (it's a one time thing) from unity itself.

If the script fail, we don't care and continue loading unity

[Mikkel Kamstrup Erlandsen (kamstrup)]

Installation path: It looks like you install the migrate_favorites.py script in $prefix/libexec? But in the vala code you call it in /usr/lib...

*.vala:

 i) Can you use Config.PREFIXDIR or Config.PKGDATADIR or some other variable substitution for the script install path, otherwise you break jhbuild.

migrate_favorites.py:

 a) In get_desktop_dir(): The natural thing would be to use g_get_user_special_dir(), but it does not seem to be bound in Python... And I couldn't find it in the xdg.BaseDirectory or xdg.Config modules... So looks like you have to do what you are currently doing

 b) Can you add a comment in the bottom of the script about "magical" flushing to gconfd? :-)

Approved provided you address i) and b) some way or other.

review: Approve

[Didier Roche-Tolomelli (didrocks)]

i) fixed with Config.PREFIXDIR and tested and horrible flushing workaround comment added :)
Merging now. Thanks!

=== modified file 'tools/Makefile.am'
--- tools/Makefile.am	2010-01-08 17:12:23 +0000
+++ tools/Makefile.am	2010-09-08 13:35:55 +0000
@@ -1,1 +1,3 @@
 EXTRA_DIST = makebootchart.py unity-xephyr.py
+
+libexec_SCRIPTS = migrate_favorites.py

=== added file 'tools/migrate_favorites.py'
--- tools/migrate_favorites.py	1970-01-01 00:00:00 +0000
+++ tools/migrate_favorites.py	2010-09-08 13:35:55 +0000
@@ -0,0 +1,95 @@
+#!/usr/bin/python
+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
+# Copyright 2010 Canonical
+# Author: Didier Roche
+#
+# This program is free software: you can redistribute it and/or modify it 
+# under the terms of the GNU General Public License version 3, as published 
+# by the Free Software Foundation.
+
+import gconf
+import glob
+import gobject
+import os
+import sys
+
+def get_desktop_dir():
+    ''' no python binding from xdg to get the desktop directory? '''
+    
+    possible_desktop_folder = None
+    try:
+        for line in file(os.path.expanduser('~/.config/user-dirs.dirs')):
+            values = line.split('=')
+            if values[0] == 'XDG_DESKTOP_DIR':
+                try:
+                    possible_desktop_folder = values[1][1:-2].replace('$HOME', os.path.expanduser('~'))
+                    if os.path.isdir(possible_desktop_folder):
+                        return possible_desktop_folder
+                    else:
+                        possible_desktop_folder = None
+                        break
+                except IndexError:
+                    continue
+    except IOError:
+        pass
+    return os.path.expanduser('~/Desktop')
+
+def register_new_app(client, launcher_location, apps_list, priority_position):
+    key_name = 'app-%s' % launcher_location.split('/')[-1]
+    # default distribution launcher don't begin with / and don't have a desktop file in ~/.gnome2
+    if os.path.exists(launcher_location) and key_name not in apps_list:
+        apps_list.append(key_name)
+        app_gconf_key_path = '/desktop/unity/launcher/favorites/%s' % key_name
+        client.set_string('%s/desktop_file' % app_gconf_key_path, launcher_location)
+        client.set_float('%s/priority' % app_gconf_key_path, priority_position)
+        client.set_string('%s/type' % app_gconf_key_path, 'application')
+        priority_position += 1
+        #print key_name
+        #print launcher_location
+        #print priority_position
+    return (apps_list, priority_position)
+
+if os.path.exists(os.path.expanduser('~/.gconf/desktop/unity/')):
+    print "migration already done or unity used before migration support"
+    sys.exit(0)
+
+client = gconf.client_get_default()
+
+# import current defaults
+apps_list = client.get_list('/desktop/unity/launcher/favorites/favorites_list', gconf.VALUE_STRING)
+priority_position = len(apps_list) + 1
+
+# get GNOME panel favorites and convert them
+panel_list = client.get_list('/apps/panel/general/toplevel_id_list', gconf.VALUE_STRING)
+candidate_objects = client.get_list('/apps/panel/general/object_id_list', gconf.VALUE_STRING)
+for candidate in candidate_objects:
+    candidate_path = '/apps/panel/objects/%s' % candidate
+    if (client.get_string('%s/object_type' % candidate_path) == 'launcher-object'
+       and client.get_string('%s/toplevel_id' % candidate_path) in panel_list):
+        launcher_location = client.get_string('%s/launcher_location' % candidate_path)
+        if launcher_location:
+            if not launcher_location.startswith('/'):
+                launcher_location = os.path.expanduser('~/.gnome2/panel2.d/default/launchers/%s' % launcher_location)
+            (apps_list, priority_position) = register_new_app(client, launcher_location, apps_list, priority_position)
+
+
+# get UNE lucid panel favorites and convert them
+lucid_favorites_list = client.get_list('/apps/netbook-launcher/favorites/favorites_list', gconf.VALUE_STRING)
+for candidate in lucid_favorites_list:
+    candidate_path = '/apps/netbook-launcher/favorites/%s' % candidate
+    if (client.get_string('%s/type' % candidate_path) == 'application'):
+        launcher_location = client.get_string('%s/desktop_file' % candidate_path)
+        if launcher_location:     
+            (apps_list, priority_position) = register_new_app(client, launcher_location, apps_list, priority_position)
+            
+# get GNOME desktop launchers
+desktop_dir = get_desktop_dir()
+for launcher_location in glob.glob('%s/*.desktop' % desktop_dir):
+    (apps_list, priority_position) = register_new_app(client, launcher_location, apps_list, priority_position)
+
+# set list of default and new favorites and write everything!
+client.set_list('/desktop/unity/launcher/favorites/favorites_list', gconf.VALUE_STRING, apps_list)
+#print apps_list
+client.clear_cache()
+loop = gobject.MainLoop(); gobject.idle_add(loop.quit); loop.run();
+

=== modified file 'unity/unity-favorites.vala'
--- unity/unity-favorites.vala	2010-07-22 10:59:27 +0000
+++ unity/unity-favorites.vala	2010-09-08 13:35:55 +0000
@@ -64,6 +64,20 @@
 
     construct
     {
+
+      // try to migrate favorites from desktop, old UNE and gnome-panel
+      var gconf_custom_dir = Environment.get_home_dir () + "/.gconf/desktop/unity";
+      var migration_script = "/usr/lib/unity/migrate_favorites.py";
+      if (!FileUtils.test(gconf_custom_dir, FileTest.IS_DIR) &&
+          FileUtils.test(migration_script, FileTest.IS_EXECUTABLE))
+        {
+          try
+            {
+              GLib.Process.spawn_command_line_sync(migration_script);
+            }
+          catch (SpawnError e) { } // no migration, don't bother
+        }
+
       client = GConf.Client.get_default ();
       notify_map = new HashMap<string, uint> ();
       favorite_added.connect (on_favorite_added);