Merge lp:~didrocks/unity/fix-ftbfs-2013 into lp:unity

Proposed by Didier Roche-Tolomelli
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: no longer in the source branch.
Merged at revision: 3010
Proposed branch: lp:~didrocks/unity/fix-ftbfs-2013
Merge into: lp:unity
Diff against target: 53 lines (+9/-5)
3 files modified
debian/changelog (+5/-1)
debian/control (+2/-2)
debian/rules (+2/-2)
To merge this branch: bzr merge lp:~didrocks/unity/fix-ftbfs-2013
Reviewer Review Type Date Requested Status
Łukasz Zemczak Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+141876@code.launchpad.net

Commit message

Fix 3 causes of FTBFS in the packaged version right now:
- pch seems to have issues with the way cmake is passing "-g -02", distro default
- compiz breaks its API and ABI but the build-dep version wasn't bumped
- nux breaks its API and ABI but the build-dep version wasn't bumped

Description of the change

Fix 3 causes of FTBFS in the packaged version right now:
- pch seems to have issues with the way cmake is passing "-g -02, distro default
- compiz breaks its API and ABI but the build-dep version wasn't bumped
- nux breaks its API and ABI but the build-dep version wasn't bumped

To post a comment you must log in.
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Works and fixes the failures. Jussi's fix of -DCMAKE_BUILD_TYPE=relwithdebinfo is also fine, but let's give it some more time for testing until we include it.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-12-11 17:38:03 +0000
3+++ debian/changelog 2013-01-04 09:53:22 +0000
4@@ -3,13 +3,17 @@
5 [ Didier Roche ]
6 * debian/control:
7 - bump some missed build-deps
8+ - bump compiz and nux build-deps for the API and ABI breakages
9+ (LP: #1095981)
10+ * debian/rules:
11+ - disable pch for now as it's not working with -g -02 (LP: #1095978)
12
13 [ Brandon Schaefer ]
14 * Ported Compiz to 0.9.9
15 * debian/control:
16 - bump the build-deps
17
18- -- Didier Roche <didrocks@ubuntu.com> Wed, 05 Dec 2012 16:46:53 +0100
19+ -- Didier Roche <didrocks@ubuntu.com> Fri, 04 Jan 2013 10:41:18 +0100
20
21 unity (6.12.0daily12.12.05-0ubuntu1) raring; urgency=low
22
23
24=== modified file 'debian/control'
25--- debian/control 2012-12-11 17:38:03 +0000
26+++ debian/control 2013-01-04 09:53:22 +0000
27@@ -27,8 +27,8 @@
28 libunity-misc-dev (>= 4.0.4),
29 libgrail-dev (>= 1.0.20),
30 libxcb-icccm4-dev,
31- libnux-4.0-dev (>= 4.0.0),
32- compiz-dev (>= 1:0.9.9~daily12.12.05-0ubuntu2),
33+ libnux-4.0-dev (>= 4.0.0daily12.12.05bzr742),
34+ compiz-dev (>= 1:0.9.9~daily12.12.05bzr3519),
35 libcompizconfig0-dev (>= 1:0.9.9~daily12.12.05-0ubuntu2),
36 xsltproc,
37 libboost-dev,
38
39=== modified file 'debian/rules'
40--- debian/rules 2012-11-15 16:12:59 +0000
41+++ debian/rules 2013-01-04 09:53:22 +0000
42@@ -18,9 +18,9 @@
43
44 override_dh_auto_configure:
45 ifeq ($(DEB_HOST_ARCH),$(findstring $(DEB_HOST_ARCH), $(gles2_architectures)))
46- dh_auto_configure -- -DUSE_GSETTINGS=TRUE -DCOMPIZ_BUILD_WITH_RPATH=FALSE -DCOMPIZ_PACKAGING_ENABLED=TRUE -DCOMPIZ_PLUGIN_INSTALL_TYPE=package -DBUILD_GLES=TRUE -DDISABLE_MAINTAINER_CFLAGS=ON
47+ dh_auto_configure -- -DUSE_GSETTINGS=TRUE -DCOMPIZ_BUILD_WITH_RPATH=FALSE -DCOMPIZ_PACKAGING_ENABLED=TRUE -DCOMPIZ_PLUGIN_INSTALL_TYPE=package -DBUILD_GLES=TRUE -DDISABLE_MAINTAINER_CFLAGS=ON -Duse_pch=OFF
48 else
49- dh_auto_configure -- -DUSE_GSETTINGS=TRUE -DCOMPIZ_BUILD_WITH_RPATH=FALSE -DCOMPIZ_PACKAGING_ENABLED=TRUE -DCOMPIZ_PLUGIN_INSTALL_TYPE=package
50+ dh_auto_configure -- -DUSE_GSETTINGS=TRUE -DCOMPIZ_BUILD_WITH_RPATH=FALSE -DCOMPIZ_PACKAGING_ENABLED=TRUE -DCOMPIZ_PLUGIN_INSTALL_TYPE=package -Duse_pch=OFF
51 endif
52
53 override_dh_install: