Merge lp:~didrocks/unity/fix-705805 into lp:unity

Proposed by Didier Roche-Tolomelli
Status: Merged
Approved by: Mirco Müller
Approved revision: no longer in the source branch.
Merged at revision: 795
Proposed branch: lp:~didrocks/unity/fix-705805
Merge into: lp:unity
Prerequisite: lp:~didrocks/unity/fix-705948
Diff against target: 56 lines (+10/-3)
1 file modified
src/Launcher.cpp (+10/-3)
To merge this branch: bzr merge lp:~didrocks/unity/fix-705805
Reviewer Review Type Date Requested Status
Mirco Müller (community) Approve
Review via email: mp+47256@code.launchpad.net

Description of the change

This branch prerequisites ~didrocks/unity/fix-705948

don't wait for the autohide delay on launcher trigger (key press or dash) if we have already waited the launcher trigger time (LP: #705805)

To post a comment you must log in.
Revision history for this message
Mirco Müller (macslow) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Launcher.cpp'
2--- src/Launcher.cpp 2011-01-24 13:18:37 +0000
3+++ src/Launcher.cpp 2011-01-24 13:18:37 +0000
4@@ -971,26 +971,32 @@
5 {
6 _key_show_launcher = true;
7 EnsureHiddenState ();
8+ // trigger the timer now as we want to hide the launcher immediately
9+ // if we release the key after 1s happened.
10+ SetupAutohideTimer ();
11 }
12
13 void Launcher::EndKeyShowLauncher ()
14 {
15 _key_show_launcher = false;
16- SetupAutohideTimer ();
17+ EnsureHiddenState ();
18 }
19
20 void Launcher::OnPlaceViewShown (GVariant *data, void *val)
21 {
22 Launcher *self = (Launcher*)val;
23 self->_placeview_show_launcher = true;
24+ // trigger the timer now as we want to hide the launcher immediately
25+ // if we close the dash after 1s happened.
26 self->EnsureHiddenState ();
27+ self->SetupAutohideTimer ();
28 }
29
30 void Launcher::OnPlaceViewHidden (GVariant *data, void *val)
31 {
32 Launcher *self = (Launcher*)val;
33 self->_placeview_show_launcher = false;
34- self->SetupAutohideTimer ();
35+ self->EnsureHiddenState ();
36 }
37
38 void Launcher::SetHidden (bool hidden)
39@@ -1010,8 +1016,8 @@
40 {
41 Launcher *self = (Launcher*) data;
42
43- self->EnsureHiddenState ();
44 self->_autohide_handle = 0;
45+ self->EnsureHiddenState ();
46 return false;
47 }
48
49@@ -1024,6 +1030,7 @@
50 !_placeview_show_launcher &&
51 _launcher_action_state == ACTION_NONE &&
52 !QuicklistManager::Default ()->Current() &&
53+ !_autohide_handle &&
54 _window_over_launcher)
55 SetHidden (true);
56 else