Merge lp:~didrocks/unity/fix-696780 into lp:unity

Proposed by Didier Roche-Tolomelli
Status: Merged
Merged at revision: 739
Proposed branch: lp:~didrocks/unity/fix-696780
Merge into: lp:unity
Diff against target: 29 lines (+5/-3)
1 file modified
src/PluginAdapter.cpp (+5/-3)
To merge this branch: bzr merge lp:~didrocks/unity/fix-696780
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
Jason Smith (community) Approve
Review via email: mp+45412@code.launchpad.net

Description of the change

fix bug #696780: MAXIMIZE_STATE is a mask composed of horizontal and vertical
maximization. Do a real comparison

To post a comment you must log in.
Revision history for this message
Jason Smith (jassmith) wrote :

+1

review: Approve
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

for the record:
17:52:22 Jason | didrocks, fix your spacing then merge

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/PluginAdapter.cpp'
2--- src/PluginAdapter.cpp 2010-12-17 11:02:26 +0000
3+++ src/PluginAdapter.cpp 2011-01-06 16:54:11 +0000
4@@ -64,12 +64,14 @@
5 void
6 PluginAdapter::NotifyStateChange (CompWindow *window, unsigned int state, unsigned int last_state)
7 {
8- if (!(last_state & MAXIMIZE_STATE) && (state & MAXIMIZE_STATE))
9+ if (!((last_state & MAXIMIZE_STATE) == MAXIMIZE_STATE)
10+ && ((state & MAXIMIZE_STATE) == MAXIMIZE_STATE))
11 {
12 PluginAdapter::window_maximized.emit (window);
13 WindowManager::window_maximized.emit (window->id ());
14 }
15- else if ((last_state & MAXIMIZE_STATE) && !(state & MAXIMIZE_STATE))
16+ else if (((last_state & MAXIMIZE_STATE) == MAXIMIZE_STATE)
17+ && !((state & MAXIMIZE_STATE) == MAXIMIZE_STATE))
18 {
19 PluginAdapter::window_restored.emit (window);
20 WindowManager::window_restored.emit (window->id ());
21@@ -235,7 +237,7 @@
22 window = m_Screen->findWindow (win);
23 if (window)
24 {
25- return window->state () & MAXIMIZE_STATE;
26+ return ((window->state () & MAXIMIZE_STATE) == MAXIMIZE_STATE);
27 }
28
29 return false;