Merge lp:~didrocks/unity/add-gtest-build-dep into lp:unity

Proposed by Didier Roche on 2012-11-09
Status: Merged
Approved by: Didier Roche on 2012-11-09
Approved revision: 2890
Merged at revision: 2888
Proposed branch: lp:~didrocks/unity/add-gtest-build-dep
Merge into: lp:unity
Diff against target: 60 lines (+15/-11)
3 files modified
CMakeLists.txt (+7/-11)
debian/changelog (+6/-0)
debian/control (+2/-0)
To merge this branch: bzr merge lp:~didrocks/unity/add-gtest-build-dep
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing on 2012-11-09
Francis Ginther 2012-11-09 Approve on 2012-11-09
Review via email: mp+133637@code.launchpad.net

Commit Message

Readd gtests to the testsuite back now that google-mock is in main. Add libgtests and google-mock to the package build-deps then.

Description of the Change

Readd gtests to the testsuite back now that google-mock is in main. Add libgtests and google-mock to the package build-deps then.

To post a comment you must log in.
Francis Ginther (fginther) wrote :

This resolves https://bugs.launchpad.net/unity/+bug/1076763, please link and add to changelog.

review: Needs Fixing
Didier Roche (didrocks) wrote :

pushed

Francis Ginther (fginther) wrote :

The bug ref should be 1076763.

review: Needs Fixing
Francis Ginther (fginther) wrote :

Approved.

review: Approve
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
No commit message was specified.

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2012-11-08 21:24:33 +0000
3+++ CMakeLists.txt 2012-11-09 10:29:20 +0000
4@@ -182,17 +182,13 @@
5 "Path to Google test srcs"
6 )
7
8-# Commenting out the following block added in rev 2884 which is causing
9-# builds to break in launchpad.
10-# This requires dependencies on libgtest-dev and google-mock which are not
11-# specified in the packaging.
12-#set(
13-# GTEST_INCLUDE_DIR
14-# "/usr/include/gtest"
15-# CACHE
16-# PATH
17-# "Path to Google tests include"
18-#)
19+set(
20+ GTEST_INCLUDE_DIR
21+ "/usr/include/gtest"
22+ CACHE
23+ PATH
24+ "Path to Google tests include"
25+)
26
27 find_path(GTEST_INCLUDE_DIR gtest/gtest.h)
28 if (GTEST_INCLUDE_DIR)
29
30=== modified file 'debian/changelog'
31--- debian/changelog 2012-11-06 18:19:09 +0000
32+++ debian/changelog 2012-11-09 10:29:20 +0000
33@@ -1,8 +1,14 @@
34 unity (6.10.0-0ubuntu3) UNRELEASED; urgency=low
35
36+ [ Michael Terry ]
37 * debian/control:
38 - Update Vcs-Bzr
39
40+ [ Didier Roche ]
41+ * debian/control:
42+ - adding libgtest-dev and google-mock build-dep now that there are in main
43+ (LP: #1076763)
44+
45 -- Michael Terry <mterry@ubuntu.com> Tue, 06 Nov 2012 10:52:43 -0500
46
47 unity (6.10.0-0ubuntu2) quantal-proposed; urgency=low
48
49=== modified file 'debian/control'
50--- debian/control 2012-11-06 18:19:09 +0000
51+++ debian/control 2012-11-09 10:29:20 +0000
52@@ -43,6 +43,8 @@
53 libxfixes-dev (>= 1:5.0-4ubuntu4),
54 gcc-4.6,
55 g++-4.6,
56+ libgtest-dev,
57+ google-mock,
58 Standards-Version: 3.9.3
59 Homepage: https://launchpad.net/unity
60 # If you aren't a member of ~unity-team but need to upload packaging changes,