Merge lp:~didrocks/unity-lens-photos/add-disabling-online-support into lp:unity-lens-photos
Proposed by
Didier Roche-Tolomelli
Status: | Merged |
---|---|
Approved by: | David Callé |
Approved revision: | 90 |
Merged at revision: | 86 |
Proposed branch: | lp:~didrocks/unity-lens-photos/add-disabling-online-support |
Merge into: | lp:unity-lens-photos |
Diff against target: |
257 lines (+96/-15) 6 files modified
src/facebook_scope.py (+16/-5) src/flickr_scope.py (+16/-5) src/picasa_scope.py (+16/-5) tests/manual/facebook-photos.txt (+16/-0) tests/manual/flickr-photos.txt (+16/-0) tests/manual/picasa-photos.txt (+16/-0) |
To merge this branch: | bzr merge lp:~didrocks/unity-lens-photos/add-disabling-online-support |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
David Callé | Approve | ||
Review via email: mp+126631@code.launchpad.net |
Description of the change
Add disabling online search support on the facebook, flickr and picasa scopes
To post a comment you must log in.
Looks good overall, but this needs to be fixed :
facebook_ scope.py: 61 connect( "filters- changed" , self.on_ lens_active) connect( "filters- changed" , self.on_ lens_active_ or_preference_ changed)
- self._scope.
+ self._scope.