Merge lp:~didrocks/unity-2d/common-and-package-cleaning into lp:unity-2d

Proposed by Didier Roche-Tolomelli
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 972
Merged at revision: 974
Proposed branch: lp:~didrocks/unity-2d/common-and-package-cleaning
Merge into: lp:unity-2d
Diff against target: 199 lines (+40/-32)
7 files modified
CMakeLists.txt (+0/-5)
data/unity-2d.convert (+0/-4)
debian/changelog (+17/-0)
debian/control (+21/-4)
debian/unity-2d-common.install.in (+0/-1)
debian/unity-2d-common.triggers.in (+2/-2)
debian/unity-2d.preinst (+0/-16)
To merge this branch: bzr merge lp:~didrocks/unity-2d/common-and-package-cleaning
Reviewer Review Type Date Requested Status
Gerry Boland (community) Approve
Review via email: mp+96610@code.launchpad.net

Description of the change

Add an unity-2d-common package containing schemas and other files to fix
(LP: #925457).

Also, do a lot of packaging cleaning, some trigger fixes…

To post a comment you must log in.
Revision history for this message
Gerry Boland (gerboland) wrote :

Beautiful, tested on clean install and customised install, works perfectly.
Many thanks Didier!

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity-2d/188/console reported an error when processing this lp:~didrocks/unity-2d/common-and-package-cleaning branch.
Not merging it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2012-03-05 14:04:05 +0000
3+++ CMakeLists.txt 2012-03-08 16:48:44 +0000
4@@ -53,10 +53,8 @@
5 # GSettings schemas
6 pkg_check_modules(GLIB REQUIRED glib-2.0)
7 set (UNITY_2D_SCHEMAS "com.canonical.Unity2d.gschema.xml")
8-set (UNITY_2D_GCONF_CONVERT "unity-2d.convert")
9 set (GSETTINGS_DIR "${CMAKE_INSTALL_PREFIX}/share/glib-2.0/schemas/")
10 set (UNITY_2D_SCHEMA_FILE "${GSETTINGS_DIR}${UNITY_2D_SCHEMAS}")
11-set (GCONF_CONVERT_DIR "${CMAKE_INSTALL_PREFIX}/share/GConf/gsettings")
12 execute_process (COMMAND ${PKG_CONFIG_EXECUTABLE} gio-2.0 --variable glib_compile_schemas OUTPUT_VARIABLE GLIB_COMPILE_SCHEMAS OUTPUT_STRIP_TRAILING_WHITESPACE)
13
14 # Run the schemas validator and error if it fails
15@@ -74,9 +72,6 @@
16
17 configure_file(config.h.in ${CMAKE_CURRENT_BINARY_DIR}/config.h @ONLY)
18
19-# Install GConf to GSettings conversion file
20-install (FILES ${UNITY_2D_DATA_DIR}/${UNITY_2D_GCONF_CONVERT} DESTINATION ${GCONF_CONVERT_DIR})
21-
22 include_directories(
23 ${CMAKE_BINARY_DIR}
24 ${QT_INCLUDE_DIR}
25
26=== removed file 'data/unity-2d.convert'
27--- data/unity-2d.convert 2012-01-24 12:49:13 +0000
28+++ data/unity-2d.convert 1970-01-01 00:00:00 +0000
29@@ -1,4 +0,0 @@
30-[com.canonical.Unity2d.Launcher]
31-super-key-enable = /desktop/unity-2d/launcher/super_key_enable
32-hide-mode = /desktop/unity-2d/launcher/hide_mode
33-
34
35=== modified file 'debian/changelog'
36--- debian/changelog 2012-03-07 17:49:48 +0000
37+++ debian/changelog 2012-03-08 16:48:44 +0000
38@@ -3,6 +3,23 @@
39 * debian/unity-2d.gconf-defaults:
40 - removed: not used anymore and causing regression with hide-mode=2
41 by default, converted to the gsettings key (LP: #942772)
42+ * debian/unity-2d.preinst:
43+ - removed, was a natty -> oneiric transition
44+ * debian/control, debian/unity-2d-common.install:
45+ - create unity-2d-common and make some packages depending on it
46+ - move some files from unity-2d package to unity-2d-common
47+ (gsettings and apport hook) to have packaging shipping their schema
48+ (LP: #925457)
49+ * debian/unity-2d-common.install.in:
50+ - no more gconf -> gsettings migration shipped
51+ * debian/unity-2d.postinst, prerm, trigger:
52+ - moved to unity-2d-common new package, to ensure even people uninstalling
53+ unity-2d got the right metacity configuration in the session
54+ - update the trigger to the correct directory
55+ * debian/control:
56+ - bump to latest Standards-Version
57+ - fix some too long description
58+ - put the transitional packages in the oldlibs/extra section
59
60 -- Didier Roche <didrocks@ubuntu.com> Wed, 07 Mar 2012 18:43:46 +0100
61
62
63=== modified file 'debian/control'
64--- debian/control 2012-03-02 12:33:31 +0000
65+++ debian/control 2012-03-08 16:48:44 +0000
66@@ -26,7 +26,7 @@
67 libnux-2.0-dev (>= 2.4),
68 libxi-dev,
69 libxtst-dev,
70-Standards-Version: 3.9.2
71+Standards-Version: 3.9.3
72 Vcs-Bzr: https://code.launchpad.net/~unity-2d-team/unity-2d/trunk
73
74 Package: unity-2d
75@@ -42,13 +42,14 @@
76 offer a session called Unity 2D in your login manager.
77 .
78 Unity 2D is designed to run smoothly without any graphics acceleration.
79+ .
80+ This metapackage will install all required unity-2d components.
81
82 Package: libunity-2d-private0
83 Section: libs
84 Architecture: any
85 Depends: ${shlibs:Depends},
86 ${misc:Depends},
87- unity-common,
88 Description: Unity 2D shared library
89 This library is used to host common code used by several Unity 2D components
90 It is only used internally, there is no use case for it outside of the unity-2d
91@@ -73,6 +74,8 @@
92
93 Package: unity-2d-launcher
94 Architecture: all
95+Section: oldlibs
96+Priority: extra
97 Depends: ${misc:Depends},
98 unity-2d-shell,
99 Description: Transitional package for unity-2d-launcher
100@@ -83,6 +86,7 @@
101 Architecture: any
102 Depends: ${shlibs:Depends},
103 ${misc:Depends},
104+ unity-2d-common (= ${source:Version}),
105 libunity-2d-private0 (= ${binary:Version}),
106 Provides: indicator-renderer
107 Recommends: indicator-application,
108@@ -98,6 +102,8 @@
109
110 Package: unity-2d-places
111 Architecture: all
112+Section: oldlibs
113+Priority: extra
114 Depends: ${misc:Depends},
115 unity-2d-shell,
116 Description: Transitional package for unity-2d-places
117@@ -108,6 +114,7 @@
118 Architecture: any
119 Depends: ${shlibs:Depends},
120 ${misc:Depends},
121+ unity-2d-common (= ${source:Version}),
122 libunity-2d-private0 (= ${binary:Version}),
123 libqt4-svg
124 Description: Unity 2D Spread
125@@ -120,6 +127,7 @@
126 Architecture: any
127 Depends: ${shlibs:Depends},
128 ${misc:Depends},
129+ unity-2d-common (= ${source:Version}),
130 unity-asset-pool,
131 libunity-2d-private0 (= ${binary:Version}),
132 libqt4-svg,
133@@ -137,14 +145,23 @@
134 * Dash: an overlay over the desktop to provide quick access to
135 various categories of applications.
136 * Launcher: displays in a panel at the left of the screen a list of running
137- and favorite applications as well as highlighting their notifications.
138+ and favorite applications as well as highlighting their
139+ notifications.
140+
141+Package: unity-2d-common
142+Architecture: all
143+Depends: ${misc:Depends},
144+Replaces: unity-2d (<< 5.6.0-0ubuntu2)
145+Description: Common files for Unity 2D Shell
146+ This is part of Unity 2D and contains the common files needed by multiple
147+ components of it.
148
149 Package: unity-2d-dbg
150 Architecture: any
151 Section: debug
152 Priority: extra
153 Depends:
154- unity-2d (= ${binary:Version}),
155+ unity-2d (= ${source:Version}),
156 ${misc:Depends}
157 Description: Debugging symbols for unity-2d
158 The Unity 2D interface installs a fully usable 2D session and provides the
159
160=== renamed file 'debian/unity-2d.install.in' => 'debian/unity-2d-common.install.in'
161--- debian/unity-2d.install.in 2011-11-09 22:26:57 +0000
162+++ debian/unity-2d-common.install.in 2012-03-08 16:48:44 +0000
163@@ -4,4 +4,3 @@
164 debian/20_ubuntu-2d-gconf-default @CMAKE_INSTALL_PREFIX@/@CMAKE_INSTALL_DATADIR@/gconf/ubuntu-2d/default
165 @DEBIAN_INSTALL_PREFIX@/@CMAKE_INSTALL_DATADIR@/locale/*/LC_MESSAGES/unity-2d.mo
166 @DEBIAN_INSTALL_PREFIX@/@CMAKE_INSTALL_DATADIR@/glib-2.0/schemas/com.canonical.Unity2d.gschema.xml
167-@DEBIAN_INSTALL_PREFIX@/@CMAKE_INSTALL_DATADIR@/GConf/gsettings
168
169=== renamed file 'debian/unity-2d.postinst.in' => 'debian/unity-2d-common.postinst.in'
170=== renamed file 'debian/unity-2d.postrm.in' => 'debian/unity-2d-common.postrm.in'
171=== renamed file 'debian/unity-2d.triggers.in' => 'debian/unity-2d-common.triggers.in'
172--- debian/unity-2d.triggers.in 2011-11-09 22:54:40 +0000
173+++ debian/unity-2d-common.triggers.in 2012-03-08 16:48:44 +0000
174@@ -1,2 +1,2 @@
175-interest @CMAKE_INSTALL_PREFIX@/@CMAKE_INSTALL_DATADIR@/gconf/unity-2d/default
176-interest @CMAKE_INSTALL_PREFIX@/@CMAKE_INSTALL_DATADIR@/gconf/unity-2d/mandatory
177+interest @CMAKE_INSTALL_PREFIX@/@CMAKE_INSTALL_DATADIR@/gconf/ubuntu-2d/default
178+interest @CMAKE_INSTALL_PREFIX@/@CMAKE_INSTALL_DATADIR@/gconf/ubuntu-2d/mandatory
179
180=== removed file 'debian/unity-2d.preinst'
181--- debian/unity-2d.preinst 2011-05-26 11:13:11 +0000
182+++ debian/unity-2d.preinst 1970-01-01 00:00:00 +0000
183@@ -1,16 +0,0 @@
184-#!/bin/sh
185-set -e
186-
187-case "$1" in
188- install|upgrade)
189- if dpkg --compare-versions "$2" le "3.8.6-0ubuntu1"; then
190- if [ -d /var/lib/gconf/unity-2d.mandatory ]; then
191- mv /var/lib/gconf/unity-2d.mandatory /var/lib/gconf/ubuntu-2d.mandatory || true
192- mv /var/lib/gconf/unity-2d.default /var/lib/gconf/ubuntu-2d.default || true
193- fi
194- fi
195- ;;
196-esac
197-
198-#DEBHELPER#
199-

Subscribers

People subscribed via source and target branches