Merge lp:~didrocks/ubuntu-html5-theme/clean-package into lp:~ubuntu-html5-theme-devs/ubuntu-html5-theme/ambiance

Proposed by Didier Roche-Tolomelli
Status: Merged
Approved by: Timo Jyrinki
Approved revision: 61
Merged at revision: 56
Proposed branch: lp:~didrocks/ubuntu-html5-theme/clean-package
Merge into: lp:~ubuntu-html5-theme-devs/ubuntu-html5-theme/ambiance
Diff against target: 130 lines (+50/-16)
6 files modified
debian/changelog (+8/-1)
debian/control (+5/-1)
debian/copyright (+4/-12)
debian/rules (+11/-1)
debian/ubuntu-html5-theme-autopilot.install (+1/-1)
tests/autopilot/setup.py (+21/-0)
To merge this branch: bzr merge lp:~didrocks/ubuntu-html5-theme/clean-package
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Timo Jyrinki Approve
Ubuntu HTML5 Theme Developers Pending
Review via email: mp+173147@code.launchpad.net

Commit message

* Fix some package dependencies mismatch
* Use python to install autopilot tests
* Simplify and ensure debian/copyright follows our policy
* Rename some install file to match binaries
* Add bootstrap commit so that we don't list every commit from rev 1

Description of the change

* Fix some package dependencies mismatch
  * Use python to install autopilot tests
  * Simplify and ensure debian/copyright follows our policy
  * Rename some install file to match binaries
  * Add bootstrap commit so that we don't list every commit from rev 1

To post a comment you must log in.
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Looks good and elegant, builds and runs fine.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-07-03 19:24:36 +0000
3+++ debian/changelog 2013-07-05 07:39:31 +0000
4@@ -1,4 +1,4 @@
5-ubuntu-html5-theme (0.1-0ubuntu2) UNRELEASED; urgency=low
6+ubuntu-html5-theme (0.1-0ubuntu1) UNRELEASED; urgency=low
7
8 [ Alexandre Abreu ]
9 * Initial release
10@@ -22,4 +22,11 @@
11 [ Alexandre Abreu ]
12 * Add package for autopilot tests
13
14+ [ Didier Roche ]
15+ * Fix some package dependencies mismatch
16+ * Use python to install autopilot tests
17+ * Simplify and ensure debian/copyright follows our policy
18+ * Rename some install file to match binaries
19+ * Automatic snapshot from revision 56 (bootstrap)
20+
21 -- Alexandre Abreu <alexandre.abreu@canonical.com> Wed, 03 Jul 2013 15:23:15 -0400
22
23=== modified file 'debian/control'
24--- debian/control 2013-07-03 19:24:36 +0000
25+++ debian/control 2013-07-05 07:39:31 +0000
26@@ -3,6 +3,8 @@
27 Priority: optional
28 Maintainer: Michael Hall <mhall119@ubuntu.com>
29 Build-Depends: debhelper (>= 9),
30+ python (>= 2.7),
31+ python-setuptools,
32 Standards-Version: 3.9.4
33 Homepage: https://launchpad.net/ubuntu-html5-theme
34 # If you aren't a member of ~ubuntu-html5-theme-devs but need to upload packaging changes,
35@@ -28,9 +30,11 @@
36 Package: ubuntu-html5-theme-autopilot
37 Architecture: all
38 Depends: ${misc:Depends},
39+ ${python:Depends},
40 libautopilot-qt,
41 libqt5test5,
42- ubuntu-html5-theme
43+ ubuntu-html5-theme (= ${binary:Version}),
44+ ubuntu-html5-theme-examples (= ${binary:Version}),
45 Description: Autopilot tests for the Toolkit for Ubuntu HTML5 Apps
46 Common CSS and Javascript for developing native-looking HTML5 applications
47 for Ubuntu. This package contains autopilot tests for it.
48
49=== modified file 'debian/copyright'
50--- debian/copyright 2013-07-03 16:09:42 +0000
51+++ debian/copyright 2013-07-05 07:39:31 +0000
52@@ -13,19 +13,11 @@
53 Files: *
54 Copyright: 2013 Adnane Belmadiaf <daker@ubuntu.com>
55 2013 Tiago Hillebrandt <tiagohillebrandt@ubuntu.com>
56- 2013 Canonical Ltd
57-License: LGPL-3+
58-
59-Files: debian/*
60-Copyright: 2013 Michael Hall <mhall119@ubuntu.com>
61-License: LGPL-3+
62-
63-License: LGPL-3+
64+ 2013 Canonical Ltd
65+License: LGPL-3
66 This package is free software; you can redistribute it and/or modify
67- it under the terms of the Lesser GNU General Public License as
68- published by the Free Software Foundation; either version 3 of the
69- License, or
70- (at your option) any later version.
71+ it under the terms of the Lesser GNU General Public License version 3,
72+ as published by the Free Software Foundation.
73 .
74 This package is distributed in the hope that it will be useful,
75 but WITHOUT ANY WARRANTY; without even the implied warranty of
76
77=== modified file 'debian/rules'
78--- debian/rules 2013-07-03 11:43:04 +0000
79+++ debian/rules 2013-07-05 07:39:31 +0000
80@@ -5,4 +5,14 @@
81 #export DH_VERBOSE=1
82
83 %:
84- dh $@ --fail-missing
85+ dh $@ --fail-missing --with python2
86+
87+override_dh_install:
88+ # install autopilot tests
89+ cd tests/autopilot; \
90+ set -ex; for python in $(shell pyversions -r); do \
91+ $$python setup.py install --root=$(CURDIR)/debian/tmp --install-layout=deb; \
92+ done; \
93+ cd $(CURDIR)
94+ dh_install -X'*.pyc' --fail-missing
95+
96
97=== modified file 'debian/ubuntu-html5-theme-autopilot.install'
98--- debian/ubuntu-html5-theme-autopilot.install 2013-07-03 19:24:36 +0000
99+++ debian/ubuntu-html5-theme-autopilot.install 2013-07-05 07:39:31 +0000
100@@ -1,2 +1,2 @@
101-tests/autopilot/ubuntu_html5_theme/* usr/lib/python2.7/dist-packages/ubuntu_html5_theme/
102+usr/lib/python*
103 tests/autopilot/tools/* usr/share/ubuntu-html5-theme/autopilot-tests/
104
105=== renamed file 'debian/install' => 'debian/ubuntu-html5-theme.install'
106=== added file 'tests/autopilot/setup.py'
107--- tests/autopilot/setup.py 1970-01-01 00:00:00 +0000
108+++ tests/autopilot/setup.py 2013-07-05 07:39:31 +0000
109@@ -0,0 +1,21 @@
110+#!/usr/bin/python
111+
112+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
113+# Copyright 2013 Canonical
114+#
115+# This program is free software: you can redistribute it and/or modify it
116+# under the terms of the GNU General Public License version 3, as published
117+# by the Free Software Foundation.
118+
119+
120+from distutils.core import setup
121+from setuptools import find_packages
122+
123+setup(
124+ name='ubuntu-html5-theme',
125+ version='0.1',
126+ description='ubuntu html5 theme autopilot tests.',
127+ url='https://launchpad.net/ubuntu-html5-theme',
128+ license='GPLv3',
129+ packages=find_packages(),
130+)

Subscribers

People subscribed via source and target branches