Merge lp:~didrocks/mir/add-valgrind-build-dep into lp:~mir-team/mir/trunk

[Didier Roche-Tolomelli]

build-dep on valgrind as it's used in integration tests

build-dep on valgrind as it's used in integration tests

[Thomas Voß (thomas-voss)]

LGTM, thanks Didier!

review: Approve

[Chris Halse Rogers (raof)]

Perfectly reasonable

review: Approve

[Daniel van Vugt (vanvugt)]

Running tests under valgrind is optional AFAIK. Not a requirement. I can still build Mir and run the tests without valgrind. So we should not depend on it.

review: Disapprove

[Daniel van Vugt (vanvugt)]

If we are using valgrind then that requirement is embedded in Jenkins, perhaps?

[Daniel van Vugt (vanvugt)]

If we're executing valgrind when it's not installed then that's a detection bug in:
cmake/MirCommon.cmake

[Daniel van Vugt (vanvugt)]

Can we put valgrind under Recommends instead of Build-Depends?

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:784
http://jenkins.qa.ubuntu.com/job/mir-ci/852/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-saucy-i386-build/1079
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-saucy-amd64-build/964
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-saucy-amd64-ci/90
        deb: http://jenkins.qa.ubuntu.com/job/mir-saucy-amd64-ci/90/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-vm-ci-build/./distribution=quantal,flavor=amd64/506

Click here to trigger a rebuild:
http://s-jenkins:8080/job/mir-ci/852/rebuild

review: Approve (continuous-integration)

=== modified file 'debian/control'
--- debian/control	2013-06-24 16:59:17 +0000
+++ debian/control	2013-06-28 05:41:26 +0000
@@ -22,6 +22,7 @@
                libgoogle-glog-dev,
                liblttng-ust-dev,
                libxkbcommon-dev,
+               valgrind,
 Standards-Version: 3.9.4
 Homepage: https://launchpad.net/mir
 # If you aren't a member of ~mir-team but need to upload packaging changes,