ok, those are fixed now. (readonly, uneeded import and too long lines). testsuite is still ok and here is the new make lint output: $ make lint utilities/shhh.py PYTHONPATH= python2.5 bootstrap.py\ --ez_setup-source=ez_setup.py \ --download-base=download-cache/dist --eggs=eggs Enter passphrase for key '/home/ubuntu/.ssh/id_rsa': Enter passphrase for key '/home/ubuntu/.ssh/id_rsa': = Launchpad lint = Checking for conflicts. and issues in doctests and templates. Running jslint, xmllint, pyflakes, and pylint. Using normal rules. Linting changed files: lib/lp/registry/browser/configure.zcml lib/lp/registry/browser/tests/test_sshkey.py lib/lp/registry/interfaces/person.py lib/lp/registry/interfaces/ssh.py lib/lp/registry/stories/webservice/xx-person.txt == Pylint notices == lib/lp/registry/interfaces/person.py 53: [F0401] Unable to import 'lazr.enum' (No module named enum) 54: [F0401] Unable to import 'lazr.lifecycle.snapshot' (No module named lifecycle) 55: [F0401] Unable to import 'lazr.restful.interface' (No module named restful) 56: [F0401] Unable to import 'lazr.restful.declarations' (No module named restful) 63: [F0401] Unable to import 'lazr.restful.fields' (No module named restful) 410: [E1002, PersonNameField._validate] Use super on an old style class 1404: [C0322, IPersonEditRestricted.addMember] Operator not preceded by a space status=copy_field(ITeamMembership['status']), ^ comment=Text(required=False)) @export_write_operation() def addMember(person, reviewer, status=TeamMembershipStatus.APPROVED, comment=None, force_team_add=False, may_subscribe_to_list=True): 1445: [C0322, IPersonEditRestricted.acceptInvitationToBeMemberOf] Operator not preceded by a space comment=Text()) ^ @export_write_operation() def acceptInvitationToBeMemberOf(team, comment): 1457: [C0322, IPersonEditRestricted.declineInvitationToBeMemberOf] Operator not preceded by a space comment=Text()) ^ @export_write_operation() def declineInvitationToBeMemberOf(team, comment): 1755: [C0322, IPersonSet.newTeam] Operator not preceded by a space defaultmembershipperiod='default_membership_period', ^ defaultrenewalperiod='default_renewal_period') @operation_parameters( subscriptionpolicy=Choice( title=_('Subscription policy'), vocabulary=TeamSubscriptionPolicy, required=False, default=TeamSubscriptionPolicy.MODERATED)) @export_factory_operation( ITeam, ['name', 'displayname', 'teamdescription', 'defaultmembershipperiod', 'defaultrenewalperiod']) def newTeam(teamowner, name, displayname, teamdescription=None, subscriptionpolicy=TeamSubscriptionPolicy.MODERATED, defaultmembershipperiod=None, defaultrenewalperiod=None): 1824: [C0322, IPersonSet.findPerson] Operator not preceded by a space created_after=Datetime( ^ title=_("Created after"), required=False), created_before=Datetime( title=_("Created before"), required=False), ) @operation_returns_collection_of(IPerson) @export_read_operation() def findPerson(text="", exclude_inactive_accounts=True, must_have_email=False, created_after=None, created_before=None): lib/lp/registry/interfaces/ssh.py 18: [F0401] Unable to import 'lazr.enum' (No module named enum) 19: [F0401] Unable to import 'lazr.restful.declarations' (No module named restful) The changes are independent from jml's change. So if you can merge it, it would rocks! Thanks a lot!