Code review comment for lp:~didrocks/gnome-settings-daemon/sound-above-100

Revision history for this message
Sebastien Bacher (seb128) wrote :

> On the 2nd, yeah, we can't have the session without the schema. I didn't want to add an additional check on the schema, but I could, that will just be at the price of the cost logic,

You are right, let's not get the code more complex for just hypothetical cases, if things ever change the gsettings abort is going to tell us anyway

Thanks for changing the header, setting the status as approved now

review: Approve

« Back to merge proposal