Merge lp:~dholbach/snappy/more-markdown-fixes into lp:~snappy-dev/snappy/snappy-moved-to-github

Proposed by Daniel Holbach on 2015-04-22
Status: Merged
Approved by: Sergio Schvezov on 2015-04-22
Approved revision: no longer in the source branch.
Merged at revision: 417
Proposed branch: lp:~dholbach/snappy/more-markdown-fixes
Merge into: lp:~snappy-dev/snappy/snappy-moved-to-github
Diff against target: 193 lines (+63/-63)
2 files modified
docs/meta.md (+59/-59)
docs/oem.md (+4/-4)
To merge this branch: bzr merge lp:~dholbach/snappy/more-markdown-fixes
Reviewer Review Type Date Requested Status
John Lenton 2015-04-22 Approve on 2015-04-22
Review via email: mp+257094@code.launchpad.net

Commit Message

- fix small typos
- use <code> for configuration keywords
- it’s → its
- break large sentence into two
- italicise Note:/Caution:

To post a comment you must log in.
John Lenton (chipaca) :
review: Approve
Snappy Tarmac (snappydevtarmac) wrote :

The attempt to merge lp:~dholbach/snappy/more-markdown-fixes into lp:snappy failed. Below is the output from the failed tests.

Checking formatting
Installing godeps

# we always run in a fresh dir in tarmac
export GOPATH=$(mktemp -d)
trap 'rm -rf "$GOPATH"' EXIT

# this is a hack, but not sure tarmac is golang friendly
mkdir -p $GOPATH/src/launchpad.net/snappy
cp -a . $GOPATH/src/launchpad.net/snappy/
cd $GOPATH/src/launchpad.net/snappy

./run-checks

if which goctest >/dev/null; then
    goctest="goctest"
else
    goctest="go test"
fi

echo Checking formatting
fmt=$(gofmt -l .)

if [ -n "$fmt" ]; then
    echo "Formatting wrong in following files"
    echo $fmt
    exit 1
fi

echo Installing godeps
go get launchpad.net/godeps
# cd .; bzr branch https://launchpad.net/godeps /tmp/tmp.1X9HujsbNN/src/launchpad.net/godeps
bzr: ERROR: http://bazaar.launchpad.net/%2Bbranch-id/769359/.bzr/repository/packs/82a0588ac18ed8994f614f8142ee921f.pack is redirected to https://launchpad.net
package launchpad.net/godeps: exit status 3

417. By Daniel Holbach on 2015-04-22

- fix small typos
- use <code> for configuration keywords
- it’s → its
- break large sentence into two
- italicise Note:/Caution: by dholbach approved by chipaca

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'docs/meta.md'
2--- docs/meta.md 2015-04-18 18:17:21 +0000
3+++ docs/meta.md 2015-04-22 13:42:58 +0000
4@@ -1,13 +1,13 @@
5 # Package metadata
6
7 This document describes the meta data of a snappy package. All files
8-are located under the meta/ directory.
9+are located under the `meta/` directory.
10
11 The following files are supported:
12
13 ## readme.md
14
15-The readme.md file contains a description of the snap. The snappy
16+The `readme.md` file contains a description of the snap. The snappy
17 tools will automatically extract the heading as the short summary for
18 the snap and the first paragraph as the description in the store.
19
20@@ -16,69 +16,69 @@
21 This file describes the snap package and is the most important file
22 for a snap package. The following keys are mandatory:
23
24- * name: the name of the snap (only [a-z0-9][a-z0-9+.-])
25- * version: the version of the snap (only [a-zA-Z0-9.+~-] are allowed)
26- * vendor: the vendor of the snap
27+ * `name`: the name of the snap (only `[a-z0-9][a-z0-9+.-]`)
28+ * `version`: the version of the snap (only `[a-zA-Z0-9.+~-]` are allowed)
29+ * `vendor`: the vendor of the snap
30
31 The following keys are optional:
32
33- * icon: a svg icon for the snap that is displayed in the store
34- * explicit-license-agreement: set to `Y` if the user needs to accept a
35- special meta/license.txt before the snap can be installed
36- * license-version: a string that, when it changes and
37+ * `icon`: a SVG icon for the snap that is displayed in the store
38+ * `explicit-license-agreement`: set to `Y` if the user needs to accept a
39+ special `meta/license.txt` before the snap can be installed
40+ * `license-version`: a string that, when it changes and
41 `explicit-license-agreement` is `Y`, prompts the user to accept the
42 license again.
43- * type: (optional) the type of the snap, can be:
44- * app - the default if empty
45- * oem - a special snap that OEMs can use to customize snappy for
46- their hardware
47- * framework - a specialized snap that extends the system that other
48- snaps may use
49-
50- * architectures: (optional) a yaml list of supported architectures
51- ["all"] if empty
52- * frameworks: a list of the frameworks the snap needs as dependencies
53-
54- * services: the servies (daemons) that the snap provides
55- * name: (required) name of the service (only [a-zA-Z0-9+.-])
56- * description: (required) description of the service
57- * start: (required) the command to start the service
58- * stop: (optional) the command to stop the service
59- * stop-timeout: (optional) the time in seconds to wait for the
60- service to stop
61- * poststop: a command that runs after the service has stopped
62- * caps: (optional) list of additional security policies to add.
63- See security.md for details
64- * security-template: (optional) alternate security template to use
65- instead of `default`. See security.md for details
66- * security-override: (optional) high level overrides to use when
67- `security-template` and `caps` are not
68- sufficient. See security.md for details
69- * security-policy: (optional) hand-crafted low-level raw security
70- policy to use instead of using default
71- template-based security policy. See
72- security.md for details
73- * ports: (optional) define what ports the service will work
74- * internal: the ports the service is going to connect to
75- * tagname: a free form name
76- * port: (optional) number/protocol, e.g. 80/tcp
77- * negotiable: (optional) Y if the app can use a different port
78- * external: the ports the service offer to the world
79- * tagname: a free form name, some names have meaning like "ui"
80- * port: (optional) see above
81- * negotionalble: (optional) see above
82- * bus-name: (optional) message bus connection name for the service.
83+ * `type`: (optional) the type of the snap, can be:
84+ * `app` - the default if empty
85+ * `oem` - a special snap that OEMs can use to customize snappy for
86+ their hardware
87+ * `framework` - a specialized snap that extends the system that other
88+ snaps may use
89+
90+ * `architectures`: (optional) a yaml list of supported architectures
91+ `["all"]` if empty
92+ * `frameworks`: a list of the frameworks the snap needs as dependencies
93+
94+ * `services`: the servies (daemons) that the snap provides
95+ * `name`: (required) name of the service (only `[a-zA-Z0-9+.-]`)
96+ * `description`: (required) description of the service
97+ * `start`: (required) the command to start the service
98+ * `stop`: (optional) the command to stop the service
99+ * `stop-timeout`: (optional) the time in seconds to wait for the
100+ service to stop
101+ * `poststop`: a command that runs after the service has stopped
102+ * `caps`: (optional) list of additional security policies to add.
103+ See `security.md` for details
104+ * `security-template`: (optional) alternate security template to use
105+ instead of `default`. See `security.md` for details
106+ * `security-override`: (optional) high level overrides to use when
107+ `security-template` and `caps` are not
108+ sufficient. See security.md for details
109+ * `security-policy`: (optional) hand-crafted low-level raw security
110+ policy to use instead of using default
111+ template-based security policy. See
112+ security.md for details
113+ * `ports`: (optional) define what ports the service will work
114+ * `internal`: the ports the service is going to connect to
115+ * `tagname`: a free form name
116+ * `port`: (optional) number/protocol, e.g. `80/tcp`
117+ * `negotiable`: (optional) Y if the app can use a different port
118+ * `external`: the ports the service offer to the world
119+ * `tagname`: a free form name, some names have meaning like "ui"
120+ * `port`: (optional) see above
121+ * `negotiable`: (optional) see above
122+ * `bus-name`: (optional) message bus connection name for the service.
123 May only be specified for snaps of 'type: framework' (see above).
124
125- * binaries: the binaries (executables) that the snap provies
126- * name: (required) the name of the binary, the user will be able to
127- call it as $name.$pkgname (only [a-zA-Z0-9+.-])
128- * exec: the program that gets execute (can be omited if name points
129- to a binary already)
130- * caps: (optional) see entry in services (above)
131- * security-template: (optional) see entry in services (above)
132- * security-override: (optional) see entry in services (above)
133- * security-policy: (optional) see entry in services (above)
134+ * `binaries`: the binaries (executables) that the snap provides
135+ * `name`: (required) the name of the binary, the user will be able to
136+ call it as $name.$pkgname (only `[a-zA-Z0-9+.-]`)
137+ * `exec`: the program that gets executed (can be omited if name points
138+ to a binary already)
139+ * `caps`: (optional) see entry in `services` (above)
140+ * `security-template`: (optional) see entry in `services` (above)
141+ * `security-override`: (optional) see entry in `services` (above)
142+ * `security-policy`: (optional) see entry in `services` (above)
143
144 ## license.txt
145
146@@ -87,7 +87,7 @@
147
148 ## hooks/ directory
149
150-See config.md for details.
151+See `config.md` for details.
152
153 # Examples
154
155
156=== modified file 'docs/oem.md'
157--- docs/oem.md 2015-04-14 16:46:57 +0000
158+++ docs/oem.md 2015-04-22 13:42:58 +0000
159@@ -3,7 +3,7 @@
160 The `oem` snappy package is a snappy package `type` that is used to setup and
161 personalize the system according to an OEM.
162
163-It covers a broad range, such as the software stack with it’s configuration and
164+It covers a broad range, such as the software stack with its configuration and
165 hardware enablement.
166
167 There can only be *one* snappy package of `type` `oem` and it can only be
168@@ -12,7 +12,7 @@
169 ## Nomenclature
170
171 Some parts of this text refer to pure snappy packages, and `device` or
172-`ubuntu-core` packages, the intent is that in the future, `device` and
173+`ubuntu-core` packages. The intent is that in the future, `device` and
174 `ubuntu-core` would migrate to being pure snappy packages in the future. This
175 has been generalized in some text with the concept of `parts`, in this writing
176 everything is a *package*.
177@@ -41,7 +41,7 @@
178 each package that is to be configured.
179
180 On first boot of the system, this `config.yaml` file will be processed and the
181-described configuration will be applied. Note: factory resetting the system
182+described configuration will be applied. *Note:* factory resetting the system
183 will create a first boot scenario and therefore `config.yaml` will be
184 processed.
185
186@@ -87,7 +87,7 @@
187 system to boot.
188
189 While these assets are typically used during provisioning, they may also be
190-used against a running system. Caution: updating these assets on a running
191+used against a running system. *Caution:* updating these assets on a running
192 system may lead to a broken system unless redundancy or fallback machanisms
193 aren't provided by the OEM.
194

Subscribers

People subscribed via source and target branches