Snapcraft

Merge lp:~dholbach/snapcraft/start-0.2 into lp:~snappy-dev/snapcraft/core

  1. start-0.2
  2. Merge into core
Proposed by Daniel Holbach on 2015-08-18
Status: Merged
Approved by: Michael Vogt on 2015-09-01
Approved revision: 134
Merged at revision: 145
Proposed branch: lp:~dholbach/snapcraft/start-0.2
Merge into: lp:~snappy-dev/snapcraft/core
Diff against target: 13 lines (+6/-0)
1 file modified
debian/changelog (+6/-0)
To merge this branch: bzr merge lp:~dholbach/snapcraft/start-0.2
Reviewer Review Type Date Requested Status
Michael Vogt 2015-08-18 Approve on 2015-09-01
Review via email: mp+268321@code.launchpad.net

Commit Message

Open 0.2 for development, so the daily build (https://code.launchpad.net/~snappy-dev/+recipe/snapcraft-daily) can trump what's in the archive.

To post a comment you must log in.
Sergio Schvezov (sergiusens) wrote :

Care to add that comment into the changelog entry?

On Tue, Aug 18, 2015 at 5:39 AM, Daniel Holbach <email address hidden>
wrote:

> Daniel Holbach has proposed merging lp:~dholbach/snapcraft/start-0.2 into
> lp:snapcraft.
>
> Commit message:
> Open 0.2 for development, so the daily build (
> https://code.launchpad.net/~snappy-dev/+recipe/snapcraft-daily) can trump
> what's in the archive.
>
> Requested reviews:
> Snappy Developers (snappy-dev)
>
> For more details, see:
> https://code.launchpad.net/~dholbach/snapcraft/start-0.2/+merge/268321
> --
> Your team Snappy Developers is requested to review the proposed merge of
> lp:~dholbach/snapcraft/start-0.2 into lp:snapcraft.
>
> Launchpad-Message-Rationale: Reviewer @snappy-dev
> Launchpad-Notification-Type: code-review
> Launchpad-Branch: ~dholbach/snapcraft/start-0.2
> Launchpad-Project: snapcraft
>
> === modified file 'debian/changelog'
> --- debian/changelog 2015-08-05 20:50:45 +0000
> +++ debian/changelog 2015-08-18 12:38:46 +0000
> @@ -1,3 +1,9 @@
> +snapcraft (0.2) UNRELEASED; urgency=medium
> +
> + *
> +
> + -- Daniel Holbach <email address hidden> Tue, 18 Aug 2015
> 14:23:24 +0200
> +
> snapcraft (0.1) wily; urgency=low
>
> * Initial release
>
>
>

Daniel Holbach (dholbach) wrote :

Why? It's obvious from the version number in the changelog entry already and it's not listing any code changes.

Daniel Holbach (dholbach) wrote :

It's like... an implementation detail of the daily build, so I'm not sure why to specify it in d/changelog which is mostly relevant for Ubuntu uploads.

Michael Vogt (mvo) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2015-08-05 20:50:45 +0000
3+++ debian/changelog 2015-08-18 12:38:46 +0000
4@@ -1,3 +1,9 @@
5+snapcraft (0.2) UNRELEASED; urgency=medium
6+
7+ *
8+
9+ -- Daniel Holbach <daniel.holbach@ubuntu.com> Tue, 18 Aug 2015 14:23:24 +0200
10+
11 snapcraft (0.1) wily; urgency=low
12
13 * Initial release

Subscribers

People subscribed via source and target branches