Merge lp:~dholbach/snapcraft/examples-tests into lp:~fgimenez/snapcraft/build-examples-test

Proposed by Daniel Holbach on 2015-09-18
Status: Merged
Merged at revision: 166
Proposed branch: lp:~dholbach/snapcraft/examples-tests
Merge into: lp:~fgimenez/snapcraft/build-examples-test
Diff against target: 48 lines (+9/-3)
5 files modified
debian/tests/control (+3/-2)
debian/tests/runexamples (+2/-0)
debian/tests/runtests (+2/-0)
examples/godd/snapcraft.yaml (+1/-0)
integration-tests/units/examples.pxu (+1/-1)
To merge this branch: bzr merge lp:~dholbach/snapcraft/examples-tests
Reviewer Review Type Date Requested Status
Federico Gimenez 2015-09-18 Approve on 2015-09-18
Review via email: mp+271649@code.launchpad.net
To post a comment you must log in.
Daniel Holbach (dholbach) wrote :

It doesn't quite work yet, it's still blocked by bug 1495525.

This is how I run it in autopkgtest.

Just once: adt-buildvm-ubuntu-cloud -v

Then:
 bzr bd -- -S
 adt-run --source ../snapcraft_0.2.dsc --- qemu adt-wily-amd64-cloud.img

Federico Gimenez (fgimenez) wrote :

Thanks a lot Daniel, i think that the problem has something to do with the symlink to examples not being properly created inside the testbed, i'll try to fix it with this branch merged.

Cheers!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/tests/control'
2--- debian/tests/control 2015-09-17 14:56:20 +0000
3+++ debian/tests/control 2015-09-18 13:40:35 +0000
4@@ -1,5 +1,6 @@
5-Test-Command: ./runtests.sh
6-Restrictions: allow-stderr, isolation-container
7+Tests: runtests
8+ runexamples
9+Restrictions: allow-stderr, isolation-container, rw-build-tree
10 Depends: @,
11 build-essential,
12 pep8,
13
14=== added file 'debian/tests/runexamples'
15--- debian/tests/runexamples 1970-01-01 00:00:00 +0000
16+++ debian/tests/runexamples 2015-09-18 13:40:35 +0000
17@@ -0,0 +1,2 @@
18+#!/bin/sh
19+./runtests.sh plainbox examples
20
21=== added file 'debian/tests/runtests'
22--- debian/tests/runtests 1970-01-01 00:00:00 +0000
23+++ debian/tests/runtests 2015-09-18 13:40:35 +0000
24@@ -0,0 +1,2 @@
25+#!/bin/sh
26+./runtests.sh
27
28=== modified file 'examples/godd/snapcraft.yaml'
29--- examples/godd/snapcraft.yaml 2015-09-08 11:48:30 +0000
30+++ examples/godd/snapcraft.yaml 2015-09-18 13:40:35 +0000
31@@ -11,3 +11,4 @@
32 godd:
33 type: go-project
34 source: git://github.com/mvo5/godd
35+build-tools: [libgudev-1.0-dev]
36
37=== modified file 'integration-tests/units/examples.pxu'
38--- integration-tests/units/examples.pxu 2015-09-11 16:24:20 +0000
39+++ integration-tests/units/examples.pxu 2015-09-18 13:40:35 +0000
40@@ -2,7 +2,7 @@
41 plugin: shell
42 command:
43 set -ex
44- for example in ${PLAINBOX_PROVIDER_DATA}/examples/*
45+ for example in ${PLAINBOX_PROVIDER_DATA}/../../examples/*
46 do
47 cp -rT $example ${PLAINBOX_SESSION_SHARE}
48 cd ${PLAINBOX_SESSION_SHARE} && ${SNAPCRAFT}

Subscribers

People subscribed via source and target branches