Merge lp:~dholbach/loco-team-portal/570616 into lp:loco-team-portal

Proposed by Daniel Holbach
Status: Merged
Merged at revision: 139
Proposed branch: lp:~dholbach/loco-team-portal/570616
Merge into: lp:loco-team-portal
Diff against target: 256 lines (+69/-60)
2 files modified
loco_directory/events/views.py (+15/-14)
loco_directory/locale/loco-directory.pot (+54/-46)
To merge this branch: bzr merge lp:~dholbach/loco-team-portal/570616
Reviewer Review Type Date Requested Status
Michael Hall (community) Approve
Review via email: mp+26406@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Michael Hall (mhall119) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'loco_directory/events/views.py'
2--- loco_directory/events/views.py 2010-05-04 06:46:59 +0000
3+++ loco_directory/events/views.py 2010-05-31 10:19:24 +0000
4@@ -118,21 +118,21 @@
5 if is_on_lc or is_contact:
6 if request.method == 'POST':
7 team_event_object.delete()
8- request.user.message_set.create(message=_('Team Event removed'))
9+ request.user.message_set.create(message=_('Team Event removed.'))
10 return redirect( 'event-list' )
11 else:
12 context = {'team_event_object': team_event_object}
13 return render_to_response('events/team_event_delete_confirm.html', context, RequestContext(request))
14
15 else:
16- request.user.message_set.create(message=_('You can not remove this team event.'))
17+ request.user.message_set.create(message=_('You can not remove this team event. You are not admin/owner of the Launchpad team or on the LoCo Council.'))
18 return redirect( team_event_object )
19
20 @login_required
21 def team_event_select(request):
22 teams = Team.objects.filter(lp_name__in=[g.name for g in request.user.groups.all()])
23 if len(teams) == 0:
24- request.user.message_set.create(message=_('You can not add a new team event'))
25+ request.user.message_set.create(message=_('You can not add a new team event. You are not member of any of the LoCo Teams.'))
26 return redirect( 'event-list' )
27 elif len(teams) == 1:
28 return redirect('team-event-new', teams[0].lp_name)
29@@ -178,7 +178,7 @@
30 if form.is_valid():
31 team_event = form.save()
32 team_event.teams.add(team_object)
33- request.user.message_set.create(message=_('New event created'))
34+ request.user.message_set.create(message=_('New event created.'))
35 return redirect( team_object )
36 else:
37 form = TeamEventForm()
38@@ -190,7 +190,8 @@
39 return render_to_response('events/team_event_new.html',
40 context, RequestContext(request))
41 else:
42- request.user.message_set.create(message=_('You can not add a new event for this team.'))
43+ # XXX: Once we move to a new ACL system, this needs fixing.
44+ request.user.message_set.create(message=_('You can not add a new event for this team. You are not member of the team or on the LoCo Council.'))
45 return redirect( team_object )
46
47 @login_required
48@@ -213,7 +214,7 @@
49 form = TeamEventForm(data=request.POST, instance=team_event_object)
50 if form.is_valid():
51 form.save()
52- request.user.message_set.create(message=_('Team Event updated'))
53+ request.user.message_set.create(message=_('Team Event updated.'))
54 return redirect( team_event_object )
55 else:
56 form = TeamEventForm(instance=team_event_object)
57@@ -224,7 +225,7 @@
58 return render_to_response('events/team_event_update.html',
59 context, RequestContext(request))
60 else:
61- request.user.message_set.create(message=_('You can not update this team event.'))
62+ request.user.message_set.create(message=_('You can not update this team event. You are not member of the team or on the LoCo Council.'))
63 return redirect( team_event_object )
64
65 @login_required
66@@ -242,7 +243,7 @@
67 form = AttendeeRegistrationForm(instance=attendee_object, data=request.POST)
68 if form.is_valid():
69 form.save()
70- request.user.message_set.create(message=_('Your registration has been saved'))
71+ request.user.message_set.create(message=_('Your registration has been saved.'))
72 return redirect( team_event_object )
73 else:
74 form = AttendeeRegistrationForm(instance=attendee_object, initial={'guests':0})
75@@ -310,13 +311,13 @@
76 if is_on_lc:
77 if request.method == 'POST':
78 global_event_object.delete()
79- request.user.message_set.create(message=_('Global Event removed'))
80+ request.user.message_set.create(message=_('Global Event removed.'))
81 return redirect( 'event-list' )
82 else:
83 context = {'global_event_object': global_event_object}
84 return render_to_response('events/global_event_delete_confirm.html', context, RequestContext(request))
85 else:
86- request.user.message_set.create(message=_('You can not remove this global event.'))
87+ request.user.message_set.create(message=_('You can not remove this global event. You are not on the LoCo Council.'))
88 return redirect( global_event_object )
89
90 @login_required
91@@ -330,7 +331,7 @@
92 form = GlobalEventForm(data=request.POST)
93 if form.is_valid():
94 form.save()
95- request.user.message_set.create(message=_('New Global Event created'))
96+ request.user.message_set.create(message=_('New Global Event created.'))
97 return redirect( 'event-list' )
98 else:
99 form = GlobalEventForm()
100@@ -341,7 +342,7 @@
101 return render_to_response('events/global_event_new.html',
102 context, RequestContext(request))
103 else:
104- request.user.message_set.create(message=_('You can not add a new global event.'))
105+ request.user.message_set.create(message=_('You can not add a new global event. You are not on the LoCo Council.'))
106 return redirect( 'event-list' )
107
108 @login_required
109@@ -357,7 +358,7 @@
110 form = GlobalEventForm(data=request.POST, instance=global_event_object)
111 if form.is_valid():
112 form.save()
113- request.user.message_set.create(message=_('Global Event updated'))
114+ request.user.message_set.create(message=_('Global Event updated.'))
115 return redirect( global_event_object )
116 else:
117 form = GlobalEventForm(instance=global_event_object)
118@@ -368,7 +369,7 @@
119 return render_to_response('events/global_event_update.html',
120 context, RequestContext(request))
121 else:
122- request.user.message_set.create(message=_('You can not update this global event.'))
123+ request.user.message_set.create(message=_('You can not update this global event. You are not on the LoCo Council.'))
124 return redirect( global_event_object )
125
126
127
128=== modified file 'loco_directory/locale/loco-directory.pot'
129--- loco_directory/locale/loco-directory.pot 2010-05-28 13:41:32 +0000
130+++ loco_directory/locale/loco-directory.pot 2010-05-31 10:19:24 +0000
131@@ -8,7 +8,7 @@
132 msgstr ""
133 "Project-Id-Version: PACKAGE VERSION\n"
134 "Report-Msgid-Bugs-To: \n"
135-"POT-Creation-Date: 2010-05-28 13:41+0000\n"
136+"POT-Creation-Date: 2010-05-31 10:16+0000\n"
137 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
138 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
139 "Language-Team: LANGUAGE <LL@li.org>\n"
140@@ -126,63 +126,71 @@
141 msgstr ""
142
143 #: events/views.py:121
144-msgid "Team Event removed"
145+msgid "Team Event removed."
146 msgstr ""
147
148 #: events/views.py:128
149-msgid "You can not remove this team event."
150+msgid ""
151+"You can not remove this team event. You are not admin/owner of the Launchpad "
152+"team or on the LoCo Council."
153 msgstr ""
154
155 #: events/views.py:135
156-msgid "You can not add a new team event"
157+msgid ""
158+"You can not add a new team event. You are not member of any of the LoCo "
159+"Teams."
160 msgstr ""
161
162 #: events/views.py:181
163-msgid "New event created"
164-msgstr ""
165-
166-#: events/views.py:193
167-msgid "You can not add a new event for this team."
168-msgstr ""
169-
170-#: events/views.py:216
171-msgid "Team Event updated"
172-msgstr ""
173-
174-#: events/views.py:227
175-msgid "You can not update this team event."
176-msgstr ""
177-
178-#: events/views.py:245
179-msgid "Your registration has been saved"
180-msgstr ""
181-
182-#: events/views.py:271
183+msgid "New event created."
184+msgstr ""
185+
186+#: events/views.py:194
187+msgid ""
188+"You can not add a new event for this team. You are not member of the team or "
189+"on the LoCo Council."
190+msgstr ""
191+
192+#: events/views.py:217
193+msgid "Team Event updated."
194+msgstr ""
195+
196+#: events/views.py:228
197+msgid ""
198+"You can not update this team event. You are not member of the team or on the "
199+"LoCo Council."
200+msgstr ""
201+
202+#: events/views.py:246
203+msgid "Your registration has been saved."
204+msgstr ""
205+
206+#: events/views.py:272
207 msgid "Comment saved."
208 msgstr ""
209
210-#: events/views.py:313
211-msgid "Global Event removed"
212-msgstr ""
213-
214-#: events/views.py:319
215-msgid "You can not remove this global event."
216-msgstr ""
217-
218-#: events/views.py:333
219-msgid "New Global Event created"
220-msgstr ""
221-
222-#: events/views.py:344
223-msgid "You can not add a new global event."
224-msgstr ""
225-
226-#: events/views.py:360
227-msgid "Global Event updated"
228-msgstr ""
229-
230-#: events/views.py:371
231-msgid "You can not update this global event."
232+#: events/views.py:314
233+msgid "Global Event removed."
234+msgstr ""
235+
236+#: events/views.py:320
237+msgid "You can not remove this global event. You are not on the LoCo Council."
238+msgstr ""
239+
240+#: events/views.py:334
241+msgid "New Global Event created."
242+msgstr ""
243+
244+#: events/views.py:345
245+msgid "You can not add a new global event. You are not on the LoCo Council."
246+msgstr ""
247+
248+#: events/views.py:361
249+msgid "Global Event updated."
250+msgstr ""
251+
252+#: events/views.py:372
253+msgid "You can not update this global event. You are not on the LoCo Council."
254 msgstr ""
255
256 #: teams/forms.py:22 templates/teams/team_list.html:18

Subscribers

People subscribed via source and target branches