Merge lp:~dholbach/loco-team-portal/0.1-fixfor474124 into lp:~ltp-devs/loco-team-portal/0.1

Proposed by Daniel Holbach
Status: Merged
Merged at revision: not available
Proposed branch: lp:~dholbach/loco-team-portal/0.1-fixfor474124
Merge into: lp:~ltp-devs/loco-team-portal/0.1
Diff against target: 51 lines
3 files modified
loco_directory/teams/models.py (+2/-5)
loco_directory/teams/urls.py (+2/-2)
loco_directory/teams/views.py (+1/-1)
To merge this branch: bzr merge lp:~dholbach/loco-team-portal/0.1-fixfor474124
Reviewer Review Type Date Requested Status
Efrain Valles Approve
Review via email: mp+14432@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Efrain Valles (effie-jayx) wrote :

the fix works quite well

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'loco_directory/teams/models.py'
2--- loco_directory/teams/models.py 2009-10-31 01:12:09 +0000
3+++ loco_directory/teams/models.py 2009-11-04 18:10:23 +0000
4@@ -43,11 +43,8 @@
5 ordering = ('approved', 'name',)
6
7 def __unicode__(self):
8- return self.name
9+ return self.lp_name
10
11 @models.permalink
12 def get_absolute_url(self):
13- return ('team_slug', [self.name])
14-
15- def get_name(self):
16- return _(self.name)
17+ return ('team_slug', [self.lp_name])
18
19=== modified file 'loco_directory/teams/urls.py'
20--- loco_directory/teams/urls.py 2009-06-24 09:29:09 +0000
21+++ loco_directory/teams/urls.py 2009-11-04 18:10:23 +0000
22@@ -6,14 +6,14 @@
23 info_dict = {
24 'queryset': Team.objects.all(),
25 'template_object_name': 'team',
26- 'slug_field': 'name',
27+ 'slug_field': 'lp_name',
28 'extra_content': {'pageSection': 'teams'},
29 }
30
31 urlpatterns = patterns('',
32 url(r'reapprovals', 'teams.views.reapprovals', name='reapprovals'),
33 url(r'^$', 'teams.views.teams', name='teams'),
34- url(r'(?P<team_slug>[\w\ \-\_@]+)', 'teams.views.team', name='team_slug'),
35+ url(r'(?P<team_slug>[\.\w\ \-\_@]+)$', 'teams.views.team', name='team_slug'),
36 url(r'(?P<object_id>\d+)', 'django.views.generic.list_detail.object_detail',
37 dict(info_dict), 'team'),
38 )
39
40=== modified file 'loco_directory/teams/views.py'
41--- loco_directory/teams/views.py 2009-11-02 19:50:07 +0000
42+++ loco_directory/teams/views.py 2009-11-04 18:10:23 +0000
43@@ -35,7 +35,7 @@
44
45 def team(request, team_slug):
46 try:
47- team = Team.objects.get(name=team_slug)
48+ team = Team.objects.get(lp_name=team_slug)
49 except:
50 raise Team.DoesNotExist, "%s" % team_slug
51 context = {

Subscribers

People subscribed via source and target branches