Merge lp:~dholbach/launchpad/coc-2.0 into lp:launchpad
| Status: | Merged |
|---|---|
| Merged at revision: | 16283 |
| Proposed branch: | lp:~dholbach/launchpad/coc-2.0 |
| Merge into: | lp:launchpad |
| Diff against target: |
521 lines (+427/-12) 6 files modified
lib/lp/registry/browser/tests/test_codeofconduct.py (+2/-2) lib/lp/registry/codesofconduct/2.0.txt (+202/-0) lib/lp/registry/model/codeofconduct.py (+1/-1) lib/lp/registry/stories/gpg-coc/reformatted_20_coc.asc (+213/-0) lib/lp/registry/stories/gpg-coc/xx-gpg-coc.txt (+7/-7) lib/lp/services/webapp/doc/canonical_url_examples.txt (+2/-2) |
| To merge this branch: | bzr merge lp:~dholbach/launchpad/coc-2.0 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Richard Harding (community) | 2012-11-09 | Needs Information on 2012-11-15 | |
|
Review via email:
|
|||
| Daniel Holbach (dholbach) wrote : | # |
| Daniel Holbach (dholbach) wrote : | # |
I did not manage to update the signed code of conduct, because I didn't know how exactly it was generated. So with this piece I need some help.
| Richard Harding (rharding) wrote : | # |
> I did not manage to update the signed code of conduct, because I didn't know
> how exactly it was generated. So with this piece I need some help.
Hey Daniel, I *think* you're referring to the signed CoC in the test suite? If so, the tests are using the GPG keys in lp.testing.gpgkeys (data folder). So if that's what you mean you should be able to sign the new CoC for the test with the keys there using <email address hidden>
If I'm misunderstanding you let me know.
| Daniel Holbach (dholbach) wrote : | # |
Yes, I was referring to the signed CoC in the test suite. Can anyone help me sign it? I'm not quite sure how to get it done.
| Richard Harding (rharding) wrote : | # |
Daniel, I've managed to get the tests passing I think. I've pushed my branch over @
https:/
To sign the coc correctly I had to import the <email address hidden> key from lib/lp/
From there things seem to be going ok. If you're ok with it I'll just go through the normal ec2 land from my branch to get things finished up. If you'd prefer you can pull the file from my branch and I'll ok this MP for landing.
| Daniel Holbach (dholbach) wrote : | # |
Please go ahead. Thanks so much for your help with this!
| Richard Harding (rharding) wrote : | # |
This is merged and QA'd. It should go out in the first deploy of next week since no one wants to deploy on a Friday. Let me know if there's any issue or anything else that needs a hand.

The new CoC should be announced beginning of next week.