Merge lp:~dholbach/help-app/run-pep8-and-pyflakes3 into lp:help-app

[Daniel Holbach]

Run pyflakes3 and pep8 as part of the 'check' target.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:123
http://91.189.93.70:8080/job/help-app-ci/19/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/help-app-utopic-amd64-ci/19/console
    FAILURE: http://91.189.93.70:8080/job/help-app-vivid-amd64-ci/21/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/help-app-ci/19/rebuild

review: Needs Fixing (continuous-integration)

[Daniel Holbach (dholbach)]

Should pass tests once lp:~dholbach/help-app/1434415 is landed.

[Nicholas Skaggs (nskaggs)]

review: Approve

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/help-app-autolanding/1/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/help-app-utopic-amd64-autolanding/1/console
    FAILURE: http://91.189.93.70:8080/job/help-app-vivid-amd64-autolanding/1/console

review: Needs Fixing (continuous-integration)

[lp:~dholbach/help-app/run-pep8-and-pyflakes3]

123. By Daniel Holbach on 2015-03-25

Fix utopic build. Fixes: https://bugs.launchpad.net/bugs/1434415.

Approved by Nicholas Skaggs, Ubuntu Phone Apps Jenkins Bot.

[Daniel Holbach (dholbach)]

Approving again, the necessary requirement has landed now.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

review: Approve (continuous-integration)

[lp:~dholbach/help-app/run-pep8-and-pyflakes3]

124. By Daniel Holbach on 2015-03-25

Run pyflakes3 and pep8 as part of the 'check' target.

Approved by Ubuntu Phone Apps Jenkins Bot, Nicholas Skaggs.

=== modified file 'HACKING'
--- HACKING	2015-03-20 14:18:33 +0000
+++ HACKING	2015-03-25 10:14:58 +0000
@@ -86,7 +86,7 @@
 
   sudo apt install python-pelican po4a make bzrtools \
 	ubuntu-html5-ui-toolkit python3-polib python3-magic \
-	python3-markdown
+	python3-markdown pep8 pyflakes
 
 This will install the necessary files, so you can build the app or web build
 locally and check if your changes actually make sense and look and work well.

=== modified file 'Makefile'
--- Makefile	2015-03-20 12:25:41 +0000
+++ Makefile	2015-03-25 10:14:58 +0000
@@ -54,6 +54,7 @@
 
 check:
 	cd $(INTERNALS_DIR); ./run-tests
+	cd $(INTERNALS_DIR); ./run-other-tests
 
 translations:
 	cd $(INTERNALS_DIR); ./generate-translations

=== modified file 'debian/control'
--- debian/control	2015-03-11 11:57:50 +0000
+++ debian/control	2015-03-25 10:14:58 +0000
@@ -4,7 +4,9 @@
 Maintainer: Daniel Holbach <[e-mail]>
 Build-Depends: bzr,
                debhelper (>= 9),
+               pep8,
                po4a,
+               pyflakes,
                python-pelican (>= 3.5.0~),
                python3-magic,
                python3-markdown,

=== added file 'internals/run-other-tests'
--- internals/run-other-tests	1970-01-01 00:00:00 +0000
+++ internals/run-other-tests	2015-03-25 10:14:58 +0000
@@ -0,0 +1,4 @@
+#!/bin/sh -e
+
+pep8 --repeat --show-source .
+pyflakes3 .