Merge lp:~dholbach/help-app/metadata-fixes.fixes into lp:~dpm/help-app/metadata-fixes

Proposed by Daniel Holbach
Status: Merged
Merged at revision: 121
Proposed branch: lp:~dholbach/help-app/metadata-fixes.fixes
Merge into: lp:~dpm/help-app/metadata-fixes
Diff against target: 32 lines (+4/-3)
2 files modified
internals/tests/test_translations.py (+2/-2)
internals/translations/build.py (+2/-1)
To merge this branch: bzr merge lp:~dholbach/help-app/metadata-fixes.fixes
Reviewer Review Type Date Requested Status
David Planella Approve
Review via email: mp+253646@code.launchpad.net
To post a comment you must log in.
Revision history for this message
David Planella (dpm) wrote :

Merged, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'internals/tests/test_translations.py'
2--- internals/tests/test_translations.py 2015-03-19 13:36:54 +0000
3+++ internals/tests/test_translations.py 2015-03-20 10:41:16 +0000
4@@ -8,12 +8,12 @@
5 self.translations = Translations()
6 TestCase.__init__(self, *args)
7
8- def test_first_line_of_docs_is_title_line(self):
9+ def test_docs_start_with_title_line(self):
10 po = self.translations.po
11 self.assertTrue(po.gettextize(self.translations.documents))
12 results = []
13 for entry, first_line in po.pot_file_ob.find_title_lines():
14- results += [entry.msgid == first_line]
15+ results += [entry.msgid.startswith(first_line)]
16 self.assertNotIn(False, results)
17
18 def test_translated_filenames_in_markdown_links(self):
19
20=== modified file 'internals/translations/build.py'
21--- internals/translations/build.py 2015-03-20 06:36:39 +0000
22+++ internals/translations/build.py 2015-03-20 10:41:16 +0000
23@@ -279,7 +279,8 @@
24 po.langs[po_fn]['bcp47'])
25
26 # Flatten the metadata dict into a string
27- metadata_serialized = '\n'.join("{} {}".format(key, val)
28+ metadata_serialized = '\n'.join(
29+ "{} {}".format(key, val)
30 for (key, val) in metadata.items())
31
32 # Join the metadata and content into the final,

Subscribers

People subscribed via source and target branches

to all changes: