Code review comment for lp:~dholbach/help-app/

Revision history for this message
David Planella (dpm) wrote :

This is a really neat feature! It works well, so I'll go ahead and merge it.

However, I've noticed one minor issue:
- Running make launch and then closing the app does not return to the terminal prompt. You have to press Ctrl+C to return. If I just run the equivalent of the make rule on the terminal, when I close the app, then I'm returned to the prompt as expected:

ubuntu-html5-app-launcher --www=app/www --inspector

Not sure what it could be, but I thought I'd mention it.

review: Approve

« Back to merge proposal