Ubuntu Help App

Merge lp:~dholbach/help-app/1435783 into lp:help-app

  1. 1435783
  2. Merge into trunk
Proposed by Daniel Holbach on 2015-03-24
Status: Merged
Merged at revision: 121
Proposed branch: lp:~dholbach/help-app/1435783
Merge into: lp:help-app
Diff against target: 14 lines (+2/-2)
1 file modified
internals/translations/build.py (+2/-2)
To merge this branch: bzr merge lp:~dholbach/help-app/1435783
Reviewer Review Type Date Requested Status
Nicholas Skaggs 2015-03-24 Approve on 2015-03-24
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing on 2015-03-24
Review via email: mp+253952@code.launchpad.net

Commit Message

Fixes a path, so that translated markdown is written into the correct directory.

Test case in the description of https://bugs.launchpad.net/help-app/+bug/1435783

To post a comment you must log in.
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Nicholas Skaggs (nskaggs) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'internals/translations/build.py'
2--- internals/translations/build.py 2015-03-20 10:31:12 +0000
3+++ internals/translations/build.py 2015-03-24 11:00:30 +0000
4@@ -275,8 +275,8 @@
5
6 # Remove the metadata line
7 content = '\n'.join([line for line in output.split('\n')][1:])
8- new_path = self.translated_doc_fn(doc_fn,
9- po.langs[po_fn]['bcp47'])
10+ new_path = full_path(
11+ self.translated_doc_fn(doc_fn, po.langs[po_fn]['bcp47']))
12
13 # Flatten the metadata dict into a string
14 metadata_serialized = '\n'.join(

Subscribers

People subscribed via source and target branches