Merge lp:~dholbach/help-app/1435772 into lp:help-app

Proposed by Daniel Holbach
Status: Merged
Merged at revision: 122
Proposed branch: lp:~dholbach/help-app/1435772
Merge into: lp:help-app
Diff against target: 26 lines (+12/-0)
1 file modified
internals/tests/test_translations.py (+12/-0)
To merge this branch: bzr merge lp:~dholbach/help-app/1435772
Reviewer Review Type Date Requested Status
Nicholas Skaggs (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing
Review via email: mp+253954@code.launchpad.net

Commit message

add test to make sure we don't have markup tags in msgid of .po and .pot files

To post a comment you must log in.
lp:~dholbach/help-app/1435772 updated
122. By Daniel Holbach

remove code leftover

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'internals/tests/test_translations.py'
2--- internals/tests/test_translations.py 2015-03-20 10:40:27 +0000
3+++ internals/tests/test_translations.py 2015-03-24 12:45:22 +0000
4@@ -1,6 +1,7 @@
5 from unittest import TestCase
6
7 from translations.build import Translations
8+from pelicanconf import HIDE_FROM_POT
9
10
11 class HelpTestCase(TestCase):
12@@ -30,3 +31,14 @@
13 self.assertEqual(1, len(link_msgstr))
14 self.assertIn(po.langs[po_fn]['gettext_code'],
15 link_msgstr[0])
16+
17+ def test_markup_in_po_or_pot_files(self):
18+ po = self.translations.po
19+ files = [ po.pot_file_ob ]
20+ for po_fn in po.langs:
21+ po.load_pofile(po_fn)
22+ files += [ po.langs[po_fn]['pofile'] ]
23+ for po_file in files:
24+ for tag in HIDE_FROM_POT:
25+ self.assertEqual(po_file.find_in_msgid(tag), [])
26+

Subscribers

People subscribed via source and target branches