Merge lp:~dholbach/help-app/1434210 into lp:help-app
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Daniel Holbach on 2015-03-31 | ||||
| Approved revision: | 139 | ||||
| Merged at revision: | 129 | ||||
| Proposed branch: | lp:~dholbach/help-app/1434210 | ||||
| Merge into: | lp:help-app | ||||
| Diff against target: |
1217 lines (+168/-199) 13 files modified
HACKING (+1/-1) Makefile (+3/-1) internals/pelicanconf.py (+8/-1) internals/tests/test_links.py (+1/-2) internals/tests/test_translations.py (+1/-1) internals/translations/build.py (+10/-21) internals/translations/utils.py (+2/-2) po/de.po (+19/-24) po/es.po (+21/-25) po/fr.po (+26/-30) po/it.po (+26/-30) po/pt.po (+24/-31) po/ro.po (+26/-30) |
||||
| To merge this branch: | bzr merge lp:~dholbach/help-app/1434210 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve on 2015-03-31 | |
| David Planella | 2015-03-31 | Approve on 2015-03-31 | |
|
Review via email:
|
|||
Commit Message
Separate our build process steps further:
- Edits of our (English) content happen in ./content/
- Translations (from LP) are in ./po/
- 'make translations' generates translated markdown in ./build/i18n/
- pelican then uses this to generate HTML in either ./build/phone/
or ./build/web/ (depending on the theme or make target used).
Misc fixes:
- Remove cleanup function. It's not necessary any more.
- Fix test case (for en_US locale).
- Add 'date:' to translated markdown file if necessary.
PASSED: Continuous integration, rev:136
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| David Planella (dpm) wrote : | # |
Works well, but I've noticed a couple of things that might need fixing while we're at it:
- Running 'make html' and then 'make web' deletes the ./build/app directory. I'd expect the web build not to affect the app build, which would only be deleted after a 'make clean'
- It might be worth renaming 'make html' to 'make app' for consistency with the changes in the tree.
| Daniel Holbach (dholbach) wrote : | # |
Re: cleaning: this is from a time, when it was necessary to do this because else stuff would break. I'll investigate and see if this is still necessary.
In ./Makefile this is already an alias:
html: app (line 67).
PASSED: Continuous integration, rev:138
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| David Planella (dpm) wrote : | # |
LGTM now, thanks!
Just one typo on the HACKING doc `make appl` -> `make app`
FAILED: Autolanding.
Unapproved changes made after approval.
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
| Daniel Holbach (dholbach) wrote : | # |
Reapproving since it was an obvious change in the HACKING doc.

FAILED: Continuous integration, rev:134 91.189. 93.70:8080/ job/help- app-ci/ 22/ 91.189. 93.70:8080/ job/help- app-utopic- amd64-ci/ 22/console 91.189. 93.70:8080/ job/help- app-vivid- amd64-ci/ 24/console
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild: 91.189. 93.70:8080/ job/help- app-ci/ 22/rebuild
http://