Merge lp:~dholbach/help-app/1434125 into lp:~ubuntu-touch-coreapps-drivers/help-app/trunk

Proposed by Daniel Holbach on 2015-03-19
Status: Superseded
Proposed branch: lp:~dholbach/help-app/1434125
Merge into: lp:~ubuntu-touch-coreapps-drivers/help-app/trunk
Prerequisite: lp:~dholbach/help-app/1429896
Diff against target: 212 lines (+54/-27)
4 files modified
HACKING (+5/-0)
Makefile (+7/-1)
internals/web-publish (+19/-0)
po/de.po (+23/-26)
To merge this branch: bzr merge lp:~dholbach/help-app/1434125
Reviewer Review Type Date Requested Status
David Planella 2015-03-19 Needs Fixing on 2015-03-20
Review via email: mp+253526@code.launchpad.net

This proposal has been superseded by a proposal from 2015-03-20.

To post a comment you must log in.
David Planella (dpm) wrote :

Thanks! Added inline comments.

review: Needs Fixing
lp:~dholbach/help-app/1434125 updated on 2015-03-23
122. By Daniel Holbach on 2015-03-20

Require 'web' target to be executed before 'web-publish'. Make it possible to print out Makefile variables to use elsewhere

123. By Daniel Holbach on 2015-03-20

translation change for testing

124. By Daniel Holbach on 2015-03-20

update branch location (~help-app-dev), get OUTPUTDIR_WEB from Makefile, add revno to commit message, quote properly, fix test for retcode

125. By Daniel Holbach on 2015-03-20

merge from trunk

126. By Daniel Holbach on 2015-03-20

update docs

127. By Daniel Holbach on 2015-03-20

use trap (http://redsymbol.net/articles/bash-exit-traps/), thanks mvo! don't test rc of 'bzr commit', we use 'set -e' already

128. By Daniel Holbach on 2015-03-20

merge from trunk

129. By Daniel Holbach on 2015-03-20

update .po files

130. By Daniel Holbach on 2015-03-20

we need bzrtools, thanks Nick!

131. By Daniel Holbach on 2015-03-23

fix logic to obtain OUTPUTDIR_WEB value from Makefile

Unmerged revisions

131. By Daniel Holbach on 2015-03-23

fix logic to obtain OUTPUTDIR_WEB value from Makefile

130. By Daniel Holbach on 2015-03-20

we need bzrtools, thanks Nick!

129. By Daniel Holbach on 2015-03-20

update .po files

128. By Daniel Holbach on 2015-03-20

merge from trunk

127. By Daniel Holbach on 2015-03-20

use trap (http://redsymbol.net/articles/bash-exit-traps/), thanks mvo! don't test rc of 'bzr commit', we use 'set -e' already

126. By Daniel Holbach on 2015-03-20

update docs

125. By Daniel Holbach on 2015-03-20

merge from trunk

124. By Daniel Holbach on 2015-03-20

update branch location (~help-app-dev), get OUTPUTDIR_WEB from Makefile, add revno to commit message, quote properly, fix test for retcode

123. By Daniel Holbach on 2015-03-20

translation change for testing

122. By Daniel Holbach on 2015-03-20

Require 'web' target to be executed before 'web-publish'. Make it possible to print out Makefile variables to use elsewhere

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'HACKING'
2--- HACKING 2015-03-19 15:36:04 +0000
3+++ HACKING 2015-03-20 12:26:43 +0000
4@@ -141,6 +141,11 @@
5
6 Find the resulting files in the ./build/web directory.
7
8+To update the publishing branch (you need to be member of ~help-app-dev),
9+run
10+
11+ make web-publish
12+
13 We plan to make use of
14 http://www.w3.org/International/questions/qa-apache-lang-neg for publishing
15 this on the web.
16
17=== modified file 'Makefile'
18--- Makefile 2015-03-19 16:04:43 +0000
19+++ Makefile 2015-03-20 12:26:43 +0000
20@@ -27,6 +27,9 @@
21
22 ignored := $(shell bzr ignored | cut -d' ' -f1)
23
24+print-%:
25+ @echo -n '$*=$($*)'
26+
27 clean:
28 ifneq ($(strip $(ignored)),)
29 $(foreach fn, $(ignored), $(shell rm -r $(fn);))
30@@ -74,4 +77,7 @@
31 update-pot:
32 cd $(INTERNALS_DIR) && ./generate-pot
33
34-.PHONY: html help clean web check launch click app update-pot translations
35+web-publish: web
36+ cd $(INTERNALS_DIR) && ./web-publish
37+
38+.PHONY: html help clean web check launch click app update-pot translations web-publish
39
40=== added file 'internals/web-publish'
41--- internals/web-publish 1970-01-01 00:00:00 +0000
42+++ internals/web-publish 2015-03-20 12:26:43 +0000
43@@ -0,0 +1,19 @@
44+#!/bin/sh -e
45+
46+web_branch="lp:~help-app-dev/help-app/help-app-web"
47+outputdir_web=$(cd .. && make print-OUTPUTDIR_WEB | cut -d'=' -f2)
48+current_rev=$(bzr revno)
49+workingdir=$(pwd)
50+
51+tempdir=$(mktemp -d)
52+cd "$tempdir"
53+bzr branch "$web_branch" output-web
54+
55+cd output-web; bzr import "$outputdir_web"
56+
57+bzr commit -m "Update content (rev $current_rev)" -q
58+rc=$?; if [ $rc = 0 ]; then
59+ bzr push :parent
60+fi
61+
62+cd "$workingdir" && rm -r "$tempdir"
63
64=== modified file 'po/de.po'
65--- po/de.po 2015-03-20 05:25:22 +0000
66+++ po/de.po 2015-03-20 12:26:43 +0000
67@@ -11,12 +11,12 @@
68 "PO-Revision-Date: 2015-03-19 07:38+0000\n"
69 "Last-Translator: Daniel Holbach <daniel.holbach@ubuntu.com>\n"
70 "Language-Team: LANGUAGE <LL@li.org>\n"
71+"Language: \n"
72 "MIME-Version: 1.0\n"
73 "Content-Type: text/plain; charset=UTF-8\n"
74 "Content-Transfer-Encoding: 8bit\n"
75 "X-Launchpad-Export-Date: 2015-03-20 05:25+0000\n"
76 "X-Generator: Launchpad (build 17405)\n"
77-"Language: \n"
78
79 #. type: Plain text
80 #: content/pages/security.md:2
81@@ -30,9 +30,11 @@
82 msgstr "*Fragst Du Dich, wie Du das Telefon sicherer machen kannst?*\n"
83
84 #. type: Plain text
85-#: content/pages/security.md:6 content/pages/basic.md:6 content/pages/settings.md:6 content/pages/ui.md:6 content/pages/apps.md:7 content/pages/scopes.md:6
86+#: content/pages/security.md:6 content/pages/basic.md:6
87+#: content/pages/settings.md:6 content/pages/ui.md:6 content/pages/apps.md:7
88+#: content/pages/scopes.md:6
89 msgid "[TOC]"
90-msgstr ""
91+msgstr "[TOC]"
92
93 #. type: Title ###
94 #: content/pages/security.md:7
95@@ -91,23 +93,20 @@
96 #. type: Title ###
97 #: content/pages/security.md:19
98 #, no-wrap
99-msgid ""
100-"Why do I have to type my PIN when using File Manager & Terminal (not default "
101-"apps)? !!T"
102+msgid "Why do I have to type my PIN when using File Manager & Terminal (not default apps)? !!T"
103 msgstr ""
104
105 #. type: Plain text
106 #: content/pages/security.md:21
107 msgid ""
108-"Since these applications allow for invasive system changes, your "
109-"pin/passcode is required. This is for your phone security."
110+"Since these applications allow for invasive system changes, your pin/"
111+"passcode is required. This is for your phone security."
112 msgstr ""
113
114 #. type: Title ###
115 #: content/pages/security.md:22
116 #, no-wrap
117-msgid ""
118-"How can I stop someone using the indicators when the phone is unlocked? !!T"
119+msgid "How can I stop someone using the indicators when the phone is unlocked? !!T"
120 msgstr ""
121
122 #. type: Plain text
123@@ -154,6 +153,9 @@
124 "[scopes]({filename}scopes.md) such as 7digital and Grooveshark can also play "
125 "music."
126 msgstr ""
127+"The music app let's you play music copied to the device. In addition, "
128+"[scopes]({filename}scopes.de.md) such as 7digital and Grooveshark can also "
129+"play music."
130
131 #. type: Title ###
132 #: content/pages/basic.md:10
133@@ -343,12 +345,12 @@
134 #. type: Plain text
135 #: content/pages/index.md:11
136 msgid "[Take me to the FAQ!]({filename}faq.md)"
137-msgstr ""
138+msgstr "[Take me to the FAQ!]({filename}faq.de.md)"
139
140 #. type: Plain text
141 #: content/pages/index.md:12
142 msgid "[Get in touch]({filename}get-in-touch.md)"
143-msgstr ""
144+msgstr "[Get in touch]({filename}get-in-touch.de.md)"
145
146 #. type: Plain text
147 #: content/pages/settings.md:2
148@@ -386,8 +388,8 @@
149 #: content/pages/settings.md:13
150 msgid ""
151 "Open the *System Settings* application. For the time, check out the *Time & "
152-"Date* section. For language, select *Language & Text*. "
153-"![Icon]({filename}/images/settings.gif)"
154+"Date* section. For language, select *Language & Text*. ![Icon]({filename}/"
155+"images/settings.gif)"
156 msgstr ""
157
158 #. type: Title ###
159@@ -470,9 +472,7 @@
160 #. type: Plain text
161 #: content/pages/ui.md:4
162 #, no-wrap
163-msgid ""
164-"*Are you wondering about the dash, scopes, swiping? You've come to the right "
165-"place!*\n"
166+msgid "*Are you wondering about the dash, scopes, swiping? You've come to the right place!*\n"
167 msgstr ""
168
169 #. type: Title ###
170@@ -579,8 +579,7 @@
171 #. type: Title ###
172 #: content/pages/ui.md:30
173 #, no-wrap
174-msgid ""
175-"What are the small characters on the keyboard and how can I select them? !!T"
176+msgid "What are the small characters on the keyboard and how can I select them? !!T"
177 msgstr ""
178
179 #. type: Plain text
180@@ -658,9 +657,7 @@
181 #. type: Title ###
182 #: content/pages/ui.md:48
183 #, no-wrap
184-msgid ""
185-"What is the round circle on the welcome screen for? What does it show? Can I "
186-"configure it? !!T"
187+msgid "What is the round circle on the welcome screen for? What does it show? Can I configure it? !!T"
188 msgstr ""
189
190 #. type: Plain text
191@@ -715,8 +712,8 @@
192 #: content/pages/apps.md:15
193 msgid ""
194 "At the moment, the store is not able to be browsed from your PC. In the "
195-"meantime you can check the unofficial, [community-maintained "
196-"store](https://appstore.bhdouglass.com/apps)."
197+"meantime you can check the unofficial, [community-maintained store](https://"
198+"appstore.bhdouglass.com/apps)."
199 msgstr ""
200
201 #. type: Title ###
202@@ -749,8 +746,8 @@
203 #. type: Plain text
204 #: content/pages/apps.md:24
205 msgid ""
206-"If you have a Spotify premium account, just install 'CuteSpotify' "
207-"([video](https://www.youtube.com/watch?v=ea90rwK_VuI))."
208+"If you have a Spotify premium account, just install 'CuteSpotify' ([video]"
209+"(https://www.youtube.com/watch?v=ea90rwK_VuI))."
210 msgstr ""
211
212 #. type: Title ###

Subscribers

People subscribed via source and target branches