lp:~dholbach/help-app/1433525

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:help-app at revision 135

Nicholas Skaggs (community): Approve on 2015-05-13

Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration) on 2015-05-13

Diff: 371 lines (+195/-59)

8 files modified

HACKING (+1/-1)
debian/control (+2/-0)
internals/local/external-links.py (+26/-0)
internals/pelicanconf.py (+1/-1)
internals/tests/test_links.py (+150/-48)
internals/translations/build.py (+1/-1)
internals/translations/utils.py (+14/-1)
static/themes/app/static/css/app.css (+0/-7)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1433525: use target="_blank" to open links in the browser

High

Fix Released

Link a bug report

Related blueprints

141. By Daniel Holbach on 2015-05-13

fix links in the CSS

140. By Daniel Holbach on 2015-05-13

extend and generalise MyHTMLParser and HTMLLinkChecker so we can run other checks on links as well - added a test to see if the markdown extension for external links was run

139. By Daniel Holbach on 2015-05-13

fix tests run during package build, by fixing override of build location (temporary dir to avoid changing live data)

138. By Daniel Holbach on 2015-05-13

simplify code in link checking somewhat, this will allow us to add more tests to check links, add more atomic tests test_simple_local_broken_link, test_simple_local_working_link, test_non_existing_build

137. By Daniel Holbach on 2015-05-12

simplify python2/3 urlparse code

136. By Daniel Holbach on 2015-05-12

add markdown extension to make external links use target="_blank"

135. By Daniel Holbach on 2015-05-12

document missing imports for python2

134. By Daniel Holbach on 2015-05-12

make link_is_local python2-proof (pelican is python2)

133. By Daniel Holbach on 2015-05-12

merge from trunk

132. By Daniel Holbach on 2015-04-08

split out link checking functionality into utils.py