Merge lp:~dholbach/help-app/1430735-pt3 into lp:~ubuntu-touch-coreapps-drivers/help-app/trunk

Proposed by Daniel Holbach
Status: Merged
Merged at revision: 100
Proposed branch: lp:~dholbach/help-app/1430735-pt3
Merge into: lp:~ubuntu-touch-coreapps-drivers/help-app/trunk
Prerequisite: lp:~dholbach/help-app/1430735-2
Diff against target: 52 lines (+15/-12)
2 files modified
edit-here/tests/test_translations.py (+6/-4)
edit-here/translations.py (+9/-8)
To merge this branch: bzr merge lp:~dholbach/help-app/1430735-pt3
Reviewer Review Type Date Requested Status
Nicholas Skaggs (community) Approve
Review via email: mp+253167@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Nicholas Skaggs (nskaggs) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'edit-here/tests/test_translations.py'
2--- edit-here/tests/test_translations.py 2015-03-06 15:47:49 +0000
3+++ edit-here/tests/test_translations.py 2015-03-17 09:25:46 +0000
4@@ -24,7 +24,9 @@
5 for entry in pofile.find_in_msgid('{filename}'):
6 (link_msgid, link_msgstr) = \
7 pofile.find_link_in_markdown_message(entry)
8- self.assertNotIn(link_msgid, link_msgstr)
9- self.assertEqual(1, len(link_msgstr))
10- self.assertIn(po.langs[po_fn]['gettext_code'],
11- link_msgstr[0])
12+ if [doc for doc in self.translations.documents.docs
13+ if doc.endswith(link_msgid)]:
14+ self.assertNotIn(link_msgid, link_msgstr)
15+ self.assertEqual(1, len(link_msgstr))
16+ self.assertIn(po.langs[po_fn]['gettext_code'],
17+ link_msgstr[0])
18
19=== modified file 'edit-here/translations.py'
20--- edit-here/translations.py 2015-03-17 09:25:46 +0000
21+++ edit-here/translations.py 2015-03-17 09:25:46 +0000
22@@ -212,7 +212,7 @@
23 return True
24
25 def find_link_in_markdown_message(self, entry):
26- link_regex = r'\[.+?\]\(\{filename\}(.+?)\)'
27+ link_regex = r'\[.+?\]\(\{filename\}(.+?)\).*?'
28 link_msgid = re.findall(link_regex, entry.msgid)[0]
29 link_msgstr = list(re.findall(link_regex, entry.msgstr))
30 return (link_msgid, link_msgstr)
31@@ -221,13 +221,14 @@
32 for entry in self.find_in_msgid('{filename}'):
33 (link_msgid, link_msgstr) = \
34 self.find_link_in_markdown_message(entry)
35- translated_doc_fn = os.path.basename(
36- documents.translated_doc_fn(link_msgid, bcp47))
37- if not link_msgstr:
38- entry.msgstr = entry.msgid
39- link_msgstr = [link_msgid]
40- entry.msgstr = entry.msgstr.replace(link_msgstr[0],
41- translated_doc_fn)
42+ if [doc for doc in documents.docs if doc.endswith(link_msgid)]:
43+ translated_doc_fn = os.path.basename(
44+ documents.translated_doc_fn(link_msgid, bcp47))
45+ if not link_msgstr:
46+ entry.msgstr = entry.msgid
47+ link_msgstr = [link_msgid]
48+ entry.msgstr = entry.msgstr.replace(link_msgstr[0],
49+ translated_doc_fn)
50 self.save()
51
52 def find_translated_title_line(self, original_title):

Subscribers

People subscribed via source and target branches