Ubuntu Help App

Merge lp:~dholbach/help-app/1430326 into lp:~ubuntu-touch-coreapps-drivers/help-app/trunk

  1. 1430326
  2. Merge into trunk
Proposed by Daniel Holbach on 2015-03-10
Status: Merged
Merged at revision: 84
Proposed branch: lp:~dholbach/help-app/1430326
Merge into: lp:~ubuntu-touch-coreapps-drivers/help-app/trunk
Diff against target: 13 lines (+2/-1)
1 file modified
edit-here/translations.py (+2/-1)
To merge this branch: bzr merge lp:~dholbach/help-app/1430326
Reviewer Review Type Date Requested Status
David Planella 2015-03-10 Approve on 2015-03-10
Review via email: mp+252433@code.launchpad.net
To post a comment you must log in.
David Planella (dpm) wrote :

LGTM. Just one suggestion - perhaps testing for MIME type (text/plain or text/x-markdown) might be more robust?

Either way should work.

review: Approve
Daniel Holbach (dholbach) wrote :

I'll file a separate bug for that.

Daniel Holbach (dholbach) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'edit-here/translations.py'
2--- edit-here/translations.py 2015-03-05 09:32:33 +0000
3+++ edit-here/translations.py 2015-03-10 13:43:48 +0000
4@@ -213,7 +213,8 @@
5 def __init__(self):
6 self.docs = []
7 for dirpath, dirnames, fns in os.walk(PATH):
8- for fn in fns:
9+ for fn in [fn for fn in fns
10+ if fn.endswith('.md')]:
11 fn = os.path.relpath(os.path.join(dirpath, fn),
12 os.path.join(PATH, '..'))
13 self.docs += [fn]

Subscribers

People subscribed via source and target branches