Merge lp:~dholbach/help-app/1428671 into lp:~ubuntu-touch-coreapps-drivers/help-app/trunk

Proposed by Daniel Holbach
Status: Merged
Merged at revision: 97
Proposed branch: lp:~dholbach/help-app/1428671
Merge into: lp:~ubuntu-touch-coreapps-drivers/help-app/trunk
Diff against target: 52 lines (+2/-13)
3 files modified
edit-here/themes/web/static/js/global.js (+1/-7)
edit-here/themes/web/templates/_footer.html (+1/-1)
edit-here/themes/web/templates/base.html (+0/-5)
To merge this branch: bzr merge lp:~dholbach/help-app/1428671
Reviewer Review Type Date Requested Status
Nicholas Skaggs (community) Approve
Review via email: mp+253067@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

LGTM. All traces of d.u.c are gone.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'edit-here/themes/web/static/js/global.js'
--- edit-here/themes/web/static/js/global.js 2015-02-26 16:21:11 +0000
+++ edit-here/themes/web/static/js/global.js 2015-03-16 15:36:14 +0000
@@ -86,12 +86,6 @@
86};86};
8787
8888
89core.getURL = function(){
90 var url = document.URL;
91 url = url.replace('https://developer.ubuntu.com','http://developer.ubuntu.com');
92 return url;
93};
94
95core.trackClicks = function() {89core.trackClicks = function() {
96 YUI().use('node', function(Y) {90 YUI().use('node', function(Y) {
97 Y.all('#nav-global a').on('click',function(e) {91 Y.all('#nav-global a').on('click',function(e) {
@@ -108,4 +102,4 @@
108102
109if(!core.globalPrepend) {103if(!core.globalPrepend) {
110 core.setupGlobalNav();104 core.setupGlobalNav();
111}
112\ No newline at end of file105\ No newline at end of file
106}
113107
=== modified file 'edit-here/themes/web/templates/_footer.html'
--- edit-here/themes/web/templates/_footer.html 2015-03-09 14:59:58 +0000
+++ edit-here/themes/web/templates/_footer.html 2015-03-16 15:36:14 +0000
@@ -53,7 +53,7 @@
53 <ul class="inline clear">53 <ul class="inline clear">
54 <li><a href="http://www.ubuntu.com/legal">Legal information</a>54 <li><a href="http://www.ubuntu.com/legal">Legal information</a>
55 </li>55 </li>
56 <li><a href="https://bugs.launchpad.net/developer-ubuntu-com/">Report a bug on this site</a>56 <li><a href="https://bugs.launchpad.net/help-app/">Report a bug on this site</a>
57 </li>57 </li>
58 </ul>58 </ul>
59 <span class="accessibility-aid"><a href="#">Go to the top of the page</a></span>59 <span class="accessibility-aid"><a href="#">Go to the top of the page</a></span>
6060
=== modified file 'edit-here/themes/web/templates/base.html'
--- edit-here/themes/web/templates/base.html 2015-03-10 10:56:31 +0000
+++ edit-here/themes/web/templates/base.html 2015-03-16 15:36:14 +0000
@@ -58,11 +58,6 @@
58<script type="text/javascript">58<script type="text/javascript">
59 var _gaq = _gaq || [];59 var _gaq = _gaq || [];
60 60
61 /* Save to developer.ubuntu.com profile */
62 _gaq.push(['_setAccount', 'UA-1018242-33']);
63 _gaq.push(['_setDomainName', '.ubuntu.com']);
64 _gaq.push(['_trackPageview']);
65
66 /* Save to www.ubuntu.com profile */ 61 /* Save to www.ubuntu.com profile */
67 _gaq.push(['b._setAccount', 'UA-1018242-4']);62 _gaq.push(['b._setAccount', 'UA-1018242-4']);
68 _gaq.push(['b._setDomainName', '.ubuntu.com']);63 _gaq.push(['b._setDomainName', '.ubuntu.com']);

Subscribers

People subscribed via source and target branches