Merge lp:~dholbach/help-app/1428671 into lp:~ubuntu-touch-coreapps-drivers/help-app/trunk

Proposed by Daniel Holbach
Status: Merged
Merged at revision: 97
Proposed branch: lp:~dholbach/help-app/1428671
Merge into: lp:~ubuntu-touch-coreapps-drivers/help-app/trunk
Diff against target: 52 lines (+2/-13)
3 files modified
edit-here/themes/web/static/js/global.js (+1/-7)
edit-here/themes/web/templates/_footer.html (+1/-1)
edit-here/themes/web/templates/base.html (+0/-5)
To merge this branch: bzr merge lp:~dholbach/help-app/1428671
Reviewer Review Type Date Requested Status
Nicholas Skaggs (community) Approve
Review via email: mp+253067@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

LGTM. All traces of d.u.c are gone.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'edit-here/themes/web/static/js/global.js'
2--- edit-here/themes/web/static/js/global.js 2015-02-26 16:21:11 +0000
3+++ edit-here/themes/web/static/js/global.js 2015-03-16 15:36:14 +0000
4@@ -86,12 +86,6 @@
5 };
6
7
8-core.getURL = function(){
9- var url = document.URL;
10- url = url.replace('https://developer.ubuntu.com','http://developer.ubuntu.com');
11- return url;
12-};
13-
14 core.trackClicks = function() {
15 YUI().use('node', function(Y) {
16 Y.all('#nav-global a').on('click',function(e) {
17@@ -108,4 +102,4 @@
18
19 if(!core.globalPrepend) {
20 core.setupGlobalNav();
21-}
22\ No newline at end of file
23+}
24
25=== modified file 'edit-here/themes/web/templates/_footer.html'
26--- edit-here/themes/web/templates/_footer.html 2015-03-09 14:59:58 +0000
27+++ edit-here/themes/web/templates/_footer.html 2015-03-16 15:36:14 +0000
28@@ -53,7 +53,7 @@
29 <ul class="inline clear">
30 <li><a href="http://www.ubuntu.com/legal">Legal information</a>
31 </li>
32- <li><a href="https://bugs.launchpad.net/developer-ubuntu-com/">Report a bug on this site</a>
33+ <li><a href="https://bugs.launchpad.net/help-app/">Report a bug on this site</a>
34 </li>
35 </ul>
36 <span class="accessibility-aid"><a href="#">Go to the top of the page</a></span>
37
38=== modified file 'edit-here/themes/web/templates/base.html'
39--- edit-here/themes/web/templates/base.html 2015-03-10 10:56:31 +0000
40+++ edit-here/themes/web/templates/base.html 2015-03-16 15:36:14 +0000
41@@ -58,11 +58,6 @@
42 <script type="text/javascript">
43 var _gaq = _gaq || [];
44
45- /* Save to developer.ubuntu.com profile */
46- _gaq.push(['_setAccount', 'UA-1018242-33']);
47- _gaq.push(['_setDomainName', '.ubuntu.com']);
48- _gaq.push(['_trackPageview']);
49-
50 /* Save to www.ubuntu.com profile */
51 _gaq.push(['b._setAccount', 'UA-1018242-4']);
52 _gaq.push(['b._setDomainName', '.ubuntu.com']);

Subscribers

People subscribed via source and target branches