Merge lp:~dholbach/help-app/1426304 into lp:~ubuntu-touch-coreapps-drivers/help-app/trunk
| Status: | Merged |
|---|---|
| Merged at revision: | 67 |
| Proposed branch: | lp:~dholbach/help-app/1426304 |
| Merge into: | lp:~ubuntu-touch-coreapps-drivers/help-app/trunk |
| Diff against target: |
1083 lines (+391/-266) 10 files modified
edit-here/generate-pot (+1/-2) edit-here/generate-translations (+0/-1) edit-here/index.html (+4/-0) edit-here/po/de.po (+39/-26) edit-here/po/fr.po (+37/-25) edit-here/po/help.pot (+5/-5) edit-here/po/it.po (+37/-25) edit-here/po/pt.po (+38/-27) edit-here/po/ro.po (+37/-25) edit-here/translations.py (+193/-130) |
| To merge this branch: | bzr merge lp:~dholbach/help-app/1426304 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| David Planella | 2015-03-03 | Approve on 2015-03-05 | |
| Daniel Holbach (community) | Needs Fixing on 2015-03-04 | ||
|
Review via email:
|
|||
- 68. By Daniel Holbach on 2015-03-03
-
add require() function to simplify code a bit
- 69. By Daniel Holbach on 2015-03-03
-
update index.html with new languages
- 70. By Daniel Holbach on 2015-03-03
-
merge from trunk, resolve conflicts
- 71. By Daniel Holbach on 2015-03-03
-
update German translation, this will help as a test-case
- 72. By Daniel Holbach on 2015-03-03
-
omit untranslated 'Title:' line, as it would give us two 'Title:' lines
- 73. By Daniel Holbach on 2015-03-03
-
also bend links if the link title is translated
- 74. By Daniel Holbach on 2015-03-03
-
fix case where 'original_title in msgid' was not good enough, we need it exact
- 75. By Daniel Holbach on 2015-03-04
-
add Portoguese
| Daniel Holbach (dholbach) wrote : | # |
Ok, we decided to go without saving 'title_lines' anywhere, but just agree that the Title line is always the first. I'll add a piece of code in the "Title" line replacer which checks the line number.
Working on this now.
- 76. By Daniel Holbach on 2015-03-04
-
instead of doing internal bookkeeping, assume that the first line is the title_line - also error out, if we find a title line that doesn't have linenumber 1
| David Planella (dpm) wrote : | # |
Looks good to me, good work! I've just added an inline comment as a suggestion, but for me it's already good to go.
- 77. By Daniel Holbach on 2015-03-05
-
remove leftover print statement
| Daniel Holbach (dholbach) wrote : | # |
Fixed.

Looks good to me, just two inline comments.