Merge lp:~dholbach/help-app/1423871 into lp:~ubuntu-touch-coreapps-drivers/help-app/trunk
| Status: | Merged |
|---|---|
| Merged at revision: | 50 |
| Proposed branch: | lp:~dholbach/help-app/1423871 |
| Merge into: | lp:~ubuntu-touch-coreapps-drivers/help-app/trunk |
| Diff against target: |
610 lines (+119/-114) 14 files modified
.bzrignore (+1/-1) HACKING (+1/-1) Makefile (+6/-2) edit-here/content/pages/apps.md (+0/-2) edit-here/content/pages/faq.md (+1/-3) edit-here/content/pages/get-in-touch.md (+0/-2) edit-here/content/pages/index.md (+2/-4) edit-here/generate-pot (+2/-0) edit-here/pelicanconf.py (+7/-0) edit-here/po/de.po (+25/-17) edit-here/po/help.pot (+20/-46) edit-here/theme/templates/base.html (+2/-1) edit-here/theme/templates/page.html (+1/-0) edit-here/translations.py (+51/-35) |
| To merge this branch: | bzr merge lp:~dholbach/help-app/1423871 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Daniel Holbach (community) | Approve on 2015-02-24 | ||
| David Planella | 2015-02-24 | Needs Fixing on 2015-02-24 | |
| Nicholas Skaggs | 2015-02-20 | Needs Information on 2015-02-23 | |
|
Review via email:
|
|||
- 59. By Daniel Holbach on 2015-02-23
-
fix clean target
| Daniel Holbach (dholbach) wrote : | # |
The clean target in the makefile would ignore failures of the rm call. (Note the '-' at the start of the line.) Still I just pushed a cleaner version of the code.
I'll look into the linking next.
- 60. By Daniel Holbach on 2015-02-23
-
update .pot file
- 61. By Daniel Holbach on 2015-02-23
-
Remove erroneous 'Title' from generated markdown
- 62. By Daniel Holbach on 2015-02-23
-
make cleanup more robust and smaller
- 63. By Daniel Holbach on 2015-02-23
-
update .pot file
- 64. By Daniel Holbach on 2015-02-23
-
catch NotADirectoryError error more appropriately
| Daniel Holbach (dholbach) wrote : | # |
Hum, so I have problems figuring out how to make the linking work properly. According to http://
- 65. By Daniel Holbach on 2015-02-23
-
update German translation
- 66. By Daniel Holbach on 2015-02-23
-
fix typo
- 67. By Daniel Holbach on 2015-02-23
-
mention ubuntu-
html5-ui- toolkit as a prerequisite
| Daniel Holbach (dholbach) wrote : | # |
Can we please get this merged? I'll file a separate bug for the broken links.
| Daniel Holbach (dholbach) wrote : | # |
I filed bug 1424953 for this.
- 68. By Daniel Holbach on 2015-02-24
-
fix python code style issues
- 69. By Daniel Holbach on 2015-02-24
-
define common po4a args centrally, add comment
- 70. By Daniel Holbach on 2015-02-24
-
run po4a-updatepo as well
- 71. By Daniel Holbach on 2015-02-24
-
update German translation
- 72. By Daniel Holbach on 2015-02-24
-
update paths
| David Planella (dpm) wrote : | # |
Looks good to me, thanks!
Just two comments:
- I initially suggested using a directory for each language to contain the generated files. In a conversation on IRC, Daniel mentioned that this presents an issue with CSS/JS relative imports' for the toolkit theme.
- On second thoughts, and if we cannot use the above, I'd suggest keeping the same filename for all files, but adding the language as a suffix, just as the Apache docs suggest to load translations [1]. That is:
- index.en-us.html
- index.de.html
- get-in-
- get-in-
[1] http://
(*) Note the - vs. _ and lowercase. This is for converting gettext language codes to BCP-47 language codes, which are understood by the browser: http://
| David Planella (dpm) wrote : | # |
If this requires a big change to the branch, we could do the above on a separate one.
| Daniel Holbach (dholbach) wrote : | # |
<dholbach> dpm, ok, I'll work on bug 1425010 next now, but maybe it'd make sense to land the branches now, so it'll be easier for others to look at the branches
<dholbach> the code is in better shape now then it was
and I'll try to make the following MPs more targetted
<dpm> dholbach, makes sense, thanks!
<dholbach> ok

Our Makefile assumes a dirty build:
bzr ignored | cut -d' ' -f1 | xargs rm -r
rm: missing operand
Try 'rm --help' for more information.
Makefile:4: recipe for target 'clean' failed
make: [clean] Error 123 (ignored)
As for this merge, it appears you cloned the english into the german translation? It does indeed generate the proper files, but the linking seems to be off.